da6053d0a7
Previously we were a bit sloppy with the index and size types of arrays, we'd regularly use unsigned. While I don't think this ever resulted in real issues I think we should be more careful there and follow a stricter regime: unless there's a strong reason not to use size_t for array sizes and indexes, size_t it should be. Any allocations we do ultimately will use size_t anyway, and converting forth and back between unsigned and size_t will always be a source of problems. Note that on 32bit machines "unsigned" and "size_t" are equivalent, and on 64bit machines our arrays shouldn't grow that large anyway, and if they do we have a problem, however that kind of overly large allocation we have protections for usually, but for overflows we do not have that so much, hence let's add it. So yeah, it's a story of the current code being already "good enough", but I think some extra type hygiene is better. This patch tries to be comprehensive, but it probably isn't and I missed a few cases. But I guess we can cover that later as we notice it. Among smaller fixes, this changes: 1. strv_length()' return type becomes size_t 2. the unit file changes array size becomes size_t 3. DNS answer and query array sizes become size_t Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=76745
49 lines
1.6 KiB
C
49 lines
1.6 KiB
C
/* SPDX-License-Identifier: LGPL-2.1+ */
|
|
#pragma once
|
|
|
|
/***
|
|
This file is part of systemd.
|
|
|
|
Copyright 2016 Lennart Poettering
|
|
***/
|
|
|
|
#include "install.h"
|
|
#include "output-mode.h"
|
|
#include "sd-bus.h"
|
|
#include "unit-def.h"
|
|
|
|
typedef struct UnitInfo {
|
|
const char *machine;
|
|
const char *id;
|
|
const char *description;
|
|
const char *load_state;
|
|
const char *active_state;
|
|
const char *sub_state;
|
|
const char *following;
|
|
const char *unit_path;
|
|
uint32_t job_id;
|
|
const char *job_type;
|
|
const char *job_path;
|
|
} UnitInfo;
|
|
|
|
int bus_parse_unit_info(sd_bus_message *message, UnitInfo *u);
|
|
|
|
int bus_append_unit_property_assignment(sd_bus_message *m, UnitType t, const char *assignment);
|
|
int bus_append_unit_property_assignment_many(sd_bus_message *m, UnitType t, char **l);
|
|
|
|
typedef struct BusWaitForJobs BusWaitForJobs;
|
|
|
|
int bus_wait_for_jobs_new(sd_bus *bus, BusWaitForJobs **ret);
|
|
void bus_wait_for_jobs_free(BusWaitForJobs *d);
|
|
int bus_wait_for_jobs_add(BusWaitForJobs *d, const char *path);
|
|
int bus_wait_for_jobs(BusWaitForJobs *d, bool quiet, const char* const* extra_args);
|
|
int bus_wait_for_jobs_one(BusWaitForJobs *d, const char *path, bool quiet);
|
|
|
|
DEFINE_TRIVIAL_CLEANUP_FUNC(BusWaitForJobs*, bus_wait_for_jobs_free);
|
|
|
|
int bus_deserialize_and_dump_unit_file_changes(sd_bus_message *m, bool quiet, UnitFileChange **changes, size_t *n_changes);
|
|
|
|
int unit_show_processes(sd_bus *bus, const char *unit, const char *cgroup_path, const char *prefix, unsigned n_columns, OutputFlags flags, sd_bus_error *error);
|
|
|
|
int unit_load_state(sd_bus *bus, const char *name, char **load_state);
|