37c1d5e97d
When we are attempting to create directory somewhere in the bowels of /var/lib and get an error that it already exists, it can be quite hard to diagnose what is wrong (especially for a user who is not aware that the directory must have the specified owner, and permissions not looser than what was requested). Let's print a warning in most cases. A warning is appropriate, because such state is usually a sign of borked installation and needs to be resolved by the adminstrator. $ build/test-fs-util Path "/tmp/test-readlink_and_make_absolute" already exists and is not a directory, refusing. (or) Directory "/tmp/test-readlink_and_make_absolute" already exists, but has mode 0775 that is too permissive (0755 was requested), refusing. (or) Directory "/tmp/test-readlink_and_make_absolute" already exists, but is owned by 1001:1000 (1000:1000 was requested), refusing. Assertion 'mkdir_safe(tempdir, 0755, getuid(), getgid(), MKDIR_WARN_MODE) >= 0' failed at ../src/test/test-fs-util.c:320, function test_readlink_and_make_absolute(). Aborting. No functional change except for the new log lines.
179 lines
5.7 KiB
C
179 lines
5.7 KiB
C
/* SPDX-License-Identifier: LGPL-2.1+ */
|
|
/***
|
|
This file is part of systemd.
|
|
|
|
Copyright 2010 Lennart Poettering
|
|
|
|
systemd is free software; you can redistribute it and/or modify it
|
|
under the terms of the GNU Lesser General Public License as published by
|
|
the Free Software Foundation; either version 2.1 of the License, or
|
|
(at your option) any later version.
|
|
|
|
systemd is distributed in the hope that it will be useful, but
|
|
WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public License
|
|
along with systemd; If not, see <http://www.gnu.org/licenses/>.
|
|
***/
|
|
|
|
#include <errno.h>
|
|
#include <stdbool.h>
|
|
#include <string.h>
|
|
#include <sys/stat.h>
|
|
|
|
#include "alloc-util.h"
|
|
#include "fs-util.h"
|
|
#include "macro.h"
|
|
#include "mkdir.h"
|
|
#include "path-util.h"
|
|
#include "stat-util.h"
|
|
#include "stdio-util.h"
|
|
#include "user-util.h"
|
|
|
|
int mkdir_safe_internal(const char *path, mode_t mode, uid_t uid, gid_t gid, MkdirFlags flags, mkdir_func_t _mkdir) {
|
|
struct stat st;
|
|
int r;
|
|
|
|
assert(_mkdir != mkdir);
|
|
|
|
if (_mkdir(path, mode) >= 0) {
|
|
r = chmod_and_chown(path, mode, uid, gid);
|
|
if (r < 0)
|
|
return r;
|
|
}
|
|
|
|
if (lstat(path, &st) < 0)
|
|
return -errno;
|
|
|
|
if ((flags & MKDIR_FOLLOW_SYMLINK) && S_ISLNK(st.st_mode)) {
|
|
_cleanup_free_ char *p = NULL;
|
|
|
|
r = chase_symlinks(path, NULL, CHASE_NONEXISTENT, &p);
|
|
if (r < 0)
|
|
return r;
|
|
if (r == 0)
|
|
return mkdir_safe_internal(p, mode, uid, gid,
|
|
flags & ~MKDIR_FOLLOW_SYMLINK,
|
|
_mkdir);
|
|
|
|
if (lstat(p, &st) < 0)
|
|
return -errno;
|
|
}
|
|
|
|
if (!S_ISDIR(st.st_mode)) {
|
|
log_full(flags & MKDIR_WARN_MODE ? LOG_WARNING : LOG_DEBUG,
|
|
"Path \"%s\" already exists and is not a directory, refusing.", path);
|
|
return -ENOTDIR;
|
|
}
|
|
if ((st.st_mode & 0007) > (mode & 0007) ||
|
|
(st.st_mode & 0070) > (mode & 0070) ||
|
|
(st.st_mode & 0700) > (mode & 0700)) {
|
|
log_full(flags & MKDIR_WARN_MODE ? LOG_WARNING : LOG_DEBUG,
|
|
"Directory \"%s\" already exists, but has mode %04o that is too permissive (%04o was requested), refusing.",
|
|
path, st.st_mode & 0777, mode);
|
|
return -EEXIST;
|
|
}
|
|
if ((uid != UID_INVALID && st.st_uid != uid) ||
|
|
(gid != GID_INVALID && st.st_gid != gid)) {
|
|
char u[DECIMAL_STR_MAX(uid_t)] = "-", g[DECIMAL_STR_MAX(gid_t)] = "-";
|
|
|
|
if (uid != UID_INVALID)
|
|
xsprintf(u, UID_FMT, uid);
|
|
if (gid != UID_INVALID)
|
|
xsprintf(g, GID_FMT, gid);
|
|
log_full(flags & MKDIR_WARN_MODE ? LOG_WARNING : LOG_DEBUG,
|
|
"Directory \"%s\" already exists, but is owned by "UID_FMT":"GID_FMT" (%s:%s was requested), refusing.",
|
|
path, st.st_uid, st.st_gid, u, g);
|
|
return -EEXIST;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
int mkdir_errno_wrapper(const char *pathname, mode_t mode) {
|
|
if (mkdir(pathname, mode) < 0)
|
|
return -errno;
|
|
return 0;
|
|
}
|
|
|
|
int mkdir_safe(const char *path, mode_t mode, uid_t uid, gid_t gid, MkdirFlags flags) {
|
|
return mkdir_safe_internal(path, mode, uid, gid, flags, mkdir_errno_wrapper);
|
|
}
|
|
|
|
int mkdir_parents_internal(const char *prefix, const char *path, mode_t mode, mkdir_func_t _mkdir) {
|
|
const char *p, *e;
|
|
int r;
|
|
|
|
assert(path);
|
|
assert(_mkdir != mkdir);
|
|
|
|
if (prefix && !path_startswith(path, prefix))
|
|
return -ENOTDIR;
|
|
|
|
/* return immediately if directory exists */
|
|
e = strrchr(path, '/');
|
|
if (!e)
|
|
return -EINVAL;
|
|
|
|
if (e == path)
|
|
return 0;
|
|
|
|
p = strndupa(path, e - path);
|
|
r = is_dir(p, true);
|
|
if (r > 0)
|
|
return 0;
|
|
if (r == 0)
|
|
return -ENOTDIR;
|
|
|
|
/* create every parent directory in the path, except the last component */
|
|
p = path + strspn(path, "/");
|
|
for (;;) {
|
|
char t[strlen(path) + 1];
|
|
|
|
e = p + strcspn(p, "/");
|
|
p = e + strspn(e, "/");
|
|
|
|
/* Is this the last component? If so, then we're done */
|
|
if (*p == 0)
|
|
return 0;
|
|
|
|
memcpy(t, path, e - path);
|
|
t[e-path] = 0;
|
|
|
|
if (prefix && path_startswith(prefix, t))
|
|
continue;
|
|
|
|
r = _mkdir(t, mode);
|
|
if (r < 0 && r != -EEXIST)
|
|
return r;
|
|
}
|
|
}
|
|
|
|
int mkdir_parents(const char *path, mode_t mode) {
|
|
return mkdir_parents_internal(NULL, path, mode, mkdir_errno_wrapper);
|
|
}
|
|
|
|
int mkdir_p_internal(const char *prefix, const char *path, mode_t mode, mkdir_func_t _mkdir) {
|
|
int r;
|
|
|
|
/* Like mkdir -p */
|
|
|
|
assert(_mkdir != mkdir);
|
|
|
|
r = mkdir_parents_internal(prefix, path, mode, _mkdir);
|
|
if (r < 0)
|
|
return r;
|
|
|
|
r = _mkdir(path, mode);
|
|
if (r < 0 && (r != -EEXIST || is_dir(path, true) <= 0))
|
|
return r;
|
|
|
|
return 0;
|
|
}
|
|
|
|
int mkdir_p(const char *path, mode_t mode) {
|
|
return mkdir_p_internal(NULL, path, mode, mkdir_errno_wrapper);
|
|
}
|