picnoir/glibc
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

BZ #16529: Fix pedantic warning with netinet/in.h.

Browse source 
When compiling with pedantic the following warning is seen:

gcc -Wall -pedantic -O0 -o test test.c
In file included from test.c:3:0:
/path/inet/netinet/in.h:111:21: warning: comma at end of \
enumerator list [-Wpedantic]
     IPPROTO_MH = 135,      /* IPv6 mobility header.  */
                     ^

It is valid C99 to have a trailing comma after the last item in
an enumeration. However it is not valid C90. If possible glibc
attempts to keep all headers C90 + long long without requiring
C99 features. In this case it's easy to fix the headers and it
removes the warning seem with -pedantic.
This commit is contained in:
Carlos O'Donell 2014-02-06 11:12:48 -05:00
parent ee7cc38537
commit 3bfff2edbe
3 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
ChangeLog
View file

@ -1,3 +1,8 @@
2014-02-06 Carlos O'Donell <carlos@redhat.com>
[BZ #16529]
* inet/netinet/in.h: Remove comma after IPPROTO_MH.
2014-02-06 Siddhesh Poyarekar <siddhesh@redhat.com>
* manual/contrib.texi: Update entry for Carlos O'Donell,

2
NEWS
View file

@ -26,7 +26,7 @@ Version 2.19
16283, 16289, 16293, 16314, 16316, 16330, 16337, 16338, 16356, 16365,
16366, 16369, 16372, 16375, 16379, 16384, 16385, 16386, 16387, 16390,
16394, 16398, 16400, 16407, 16408, 16414, 16430, 16431, 16453, 16474,
16506, 16510
16506, 16510, 16529
* Slovenian translations for glibc messages have been contributed by the
Translation Project's Slovenian team of translators.

2
inet/netinet/in.h
View file

@ -108,7 +108,7 @@ enum
#define IPPROTO_NONE IPPROTO_NONE
IPPROTO_DSTOPTS = 60, /* IPv6 destination options. */
#define IPPROTO_DSTOPTS IPPROTO_DSTOPTS
IPPROTO_MH = 135, /* IPv6 mobility header. */
IPPROTO_MH = 135 /* IPv6 mobility header. */
#define IPPROTO_MH IPPROTO_MH
};
#endif /* !__USE_KERNEL_IPV6_DEFS */