picnoir/glibc
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

hurd: Global signal disposition

Browse source 
This adds _hurd_sigstate_set_global_rcv used by libpthread to enable
POSIX-confirming behavior of signals on a per-thread basis.

This also provides a sigstate destructor _hurd_sigstate_delete, and a
global process signal state, which needs to be locked and check when
global disposition is enabled, thus the addition of _hurd_sigstate_lock
_hurd_sigstate_actions _hurd_sigstate_pending _hurd_sigstate_unlock helpers.

This also updates all the glibc code accordingly.

This also drops support for get_int(INIT_SIGMASK), which did not make sense
any more since we do not have a single signal thread any more.

During fork/spawn, this also reinitializes the child global sigstate's
lock. That cures an issue that would very rarely cause a deadlock in the
child in fork, tries to unlock ss' critical section lock at the end of
fork.  This will typically (always?) be observed in /bin/sh, which is not
surprising as that is the foremost caller of fork.

To reproduce an intermediate state, add an endless loop if
_hurd_global_sigstate is locked after __proc_dostop (cast through
volatile); that is, while still being in the fork's parent process.

When that triggers (use the libtool testsuite), the signal thread has
already locked ss (which is _hurd_global_sigstate), and is stuck at
hurdsig.c:685 in post_signal, trying to lock _hurd_siglock (which the
main thread already has locked and keeps locked until after
__task_create).  This is the case that ss->thread == MACH_PORT_NULL, that
is, a global signal.  In the main thread, between __proc_dostop and
__task_create is the __thread_abort call on the signal thread which would
abort any current kernel operation (but leave ss locked).  Later in fork,
in the parent, when _hurd_siglock is unlocked in fork, the parent's
signal thread can proceed and will unlock eventually the global sigstate.
In the client, _hurd_siglock will likewise be unlocked, but the global
sigstate never will be, as the client's signal thread has been configured
to restart execution from _hurd_msgport_receive.  Thus, when the child
tries to unlock ss' critical section lock at the end of fork, it will
first lock the global sigstate, will spin trying to lock it, which can
never be successful, and we get our deadlock.

Options seem to be:

  * Move the locking of _hurd_siglock earlier in post_signal -- but that
    may generally impact performance, if this locking isn't generally
    needed anyway?

    On the other hand, would it actually make sense to wait here until we
    are not any longer in a critical section (which is meant to disable
    signal delivery anyway (but not for preempted signals?))?

  * Clear the global sigstate in the fork's child with the rationale that
    we're anyway restarting the signal thread from a clean state.  This
    has now been implemented.

Why has this problem not been observed before Jérémie's patches?  (Or has
it?  Perhaps even more rarely?)  In _S_msg_sig_post, the signal is now
posted to a *global receiver thread*, whereas previously it was posted to
the *designated signal-receiving thread*.  The latter one was in a
critical section in fork, so didn't try to handle the signal until after
leaving the critical section?  (Not completely analyzed and verified.)

Another question is what the signal is that is being received
during/around the time __proc_dostop executes.
This commit is contained in:
Jeremie Koenig 2019-12-29 17:59:55 +01:00 committed by Samuel Thibault
parent eb87a46c56
commit 653d74f12a
21 changed files with 385 additions and 162 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
hurd/Versions
View file

@ -159,5 +159,12 @@ libc {
__lll_abstimed_lock; __lll_robust_lock;
__lll_robust_abstimed_lock; __lll_robust_trylock;
__lll_robust_unlock;
# Used by libpthread.
_hurd_sigstate_set_global_rcv;
_hurd_sigstate_lock;
_hurd_sigstate_pending;
_hurd_sigstate_unlock;
_hurd_sigstate_delete;
}
}

16
hurd/ctty-input.c
View file

@ -43,12 +43,15 @@ _hurd_ctty_input (io_t port, io_t ctty, error_t (*rpc) (io_t))
else
{
struct hurd_sigstate *ss = _hurd_self_sigstate ();
__spin_lock (&ss->lock);
struct sigaction *actions;
_hurd_sigstate_lock (ss);
actions = _hurd_sigstate_actions (ss);
if (__sigismember (&ss->blocked, SIGTTIN)
|| ss->actions[SIGTTIN].sa_handler == SIG_IGN)
|| actions[SIGTTIN].sa_handler == SIG_IGN)
/* We are blocking or ignoring SIGTTIN. Just fail. */
err = EIO;
__spin_unlock (&ss->lock);
_hurd_sigstate_unlock (ss);
if (err == EBACKGROUND)
{
@ -65,10 +68,11 @@ _hurd_ctty_input (io_t port, io_t ctty, error_t (*rpc) (io_t))
SIGTTIN or resumed after being stopped. Now this is
still a "system call", so check to see if we should
restart it. */
__spin_lock (&ss->lock);
if (!(ss->actions[SIGTTIN].sa_flags & SA_RESTART))
_hurd_sigstate_lock (ss);
actions = _hurd_sigstate_actions (ss);
if (!(actions[SIGTTIN].sa_flags & SA_RESTART))
err = EINTR;
__spin_unlock (&ss->lock);
_hurd_sigstate_unlock (ss);
}
}
}

16
hurd/ctty-output.c
View file

@ -34,16 +34,19 @@ _hurd_ctty_output (io_t port, io_t ctty, error_t (*rpc) (io_t))
do
{
struct sigaction *actions;
/* Don't use the ctty io port if we are blocking or ignoring
SIGTTOU. We redo this check at the top of the loop in case
the signal handler changed the state. */
__spin_lock (&ss->lock);
_hurd_sigstate_lock (ss);
actions = _hurd_sigstate_actions (ss);
if (__sigismember (&ss->blocked, SIGTTOU)
|| ss->actions[SIGTTOU].sa_handler == SIG_IGN)
|| actions[SIGTTOU].sa_handler == SIG_IGN)
err = EIO;
else
err = 0;
__spin_unlock (&ss->lock);
_hurd_sigstate_unlock (ss);
if (err)
return (*rpc) (port);
@ -70,10 +73,11 @@ _hurd_ctty_output (io_t port, io_t ctty, error_t (*rpc) (io_t))
SIGTTOU or resumed after being stopped. Now this is
still a "system call", so check to see if we should
restart it. */
__spin_lock (&ss->lock);
if (!(ss->actions[SIGTTOU].sa_flags & SA_RESTART))
_hurd_sigstate_lock (ss);
actions = _hurd_sigstate_actions (ss);
if (!(actions[SIGTTOU].sa_flags & SA_RESTART))
err = EINTR;
__spin_unlock (&ss->lock);
_hurd_sigstate_unlock (ss);
}
}
/* If the last RPC generated a SIGTTOU, loop to try it again. */

38
hurd/hurd/signal.h
View file

@ -73,7 +73,13 @@ struct hurd_sigstate
sigset_t blocked; /* What signals are blocked. */
sigset_t pending; /* Pending signals, possibly blocked. */
/* Signal handlers. ACTIONS[0] is used to mark the threads with POSIX
semantics: if sa_handler is SIG_IGN instead of SIG_DFL, this thread
will receive global signals and use the process-wide action vector
instead of this one. */
struct sigaction actions[_NSIG];
stack_t sigaltstack;
/* Chain of thread-local signal preemptors; see <hurd/sigpreempt.h>.
@ -129,6 +135,26 @@ extern struct hurd_sigstate *_hurd_self_sigstate (void)
by different threads. */
__attribute__ ((__const__));
/* Process-wide signal state. */
extern struct hurd_sigstate *_hurd_global_sigstate;
/* Mark the given thread as a process-wide signal receiver. */
extern void _hurd_sigstate_set_global_rcv (struct hurd_sigstate *ss);
/* A thread can either use its own action vector and pending signal set
or use the global ones, depending on wether it has been marked as a
global receiver. The accessors below take that into account. */
extern void _hurd_sigstate_lock (struct hurd_sigstate *ss);
extern struct sigaction *_hurd_sigstate_actions (struct hurd_sigstate *ss);
extern sigset_t _hurd_sigstate_pending (const struct hurd_sigstate *ss);
extern void _hurd_sigstate_unlock (struct hurd_sigstate *ss);
/* Used by libpthread to remove stale sigstate structures. */
extern void _hurd_sigstate_delete (thread_t thread);
#ifndef _HURD_SIGNAL_H_EXTERN_INLINE
#define _HURD_SIGNAL_H_EXTERN_INLINE __extern_inline
#endif
@ -154,12 +180,6 @@ extern thread_t _hurd_msgport_thread;
extern mach_port_t _hurd_msgport;
/* Thread to receive process-global signals. */
extern thread_t _hurd_sigthread;
/* Resource limit on core file size. Enforced by hurdsig.c. */
extern int _hurd_core_limit;
@ -227,10 +247,10 @@ _hurd_critical_section_unlock (void *our_lock)
/* It was us who acquired the critical section lock. Unlock it. */
struct hurd_sigstate *ss = (struct hurd_sigstate *) our_lock;
sigset_t pending;
__spin_lock (&ss->lock);
_hurd_sigstate_lock (ss);
__spin_unlock (&ss->critical_section_lock);
pending = ss->pending & ~ss->blocked;
__spin_unlock (&ss->lock);
pending = _hurd_sigstate_pending(ss) & ~ss->blocked;
_hurd_sigstate_unlock (ss);
if (! __sigisemptyset (&pending))
/* There are unblocked signals pending, which weren't
delivered because we were in the critical section.

9
hurd/hurdexec.c
View file

@ -126,12 +126,13 @@ _hurd_exec_paths (task_t task, file_t file,
assert (! __spin_lock_locked (&ss->critical_section_lock));
__spin_lock (&ss->critical_section_lock);
__spin_lock (&ss->lock);
_hurd_sigstate_lock (ss);
struct sigaction *actions = _hurd_sigstate_actions (ss);
ints[INIT_SIGMASK] = ss->blocked;
ints[INIT_SIGPENDING] = ss->pending;
ints[INIT_SIGPENDING] = _hurd_sigstate_pending (ss);
ints[INIT_SIGIGN] = 0;
for (i = 1; i < NSIG; ++i)
if (ss->actions[i].sa_handler == SIG_IGN)
if (actions[i].sa_handler == SIG_IGN)
ints[INIT_SIGIGN] |= __sigmask (i);
/* We hold the sigstate lock until the exec has failed so that no signal
@ -142,7 +143,7 @@ _hurd_exec_paths (task_t task, file_t file,
critical section flag avoids anything we call trying to acquire the
sigstate lock. */
__spin_unlock (&ss->lock);
_hurd_sigstate_unlock (ss);
/* Pack up the descriptor table to give the new program. */
__mutex_lock (&_hurd_dtable_lock);

24
hurd/hurdmsg.c
View file

@ -121,17 +121,9 @@ get_int (int which, int *value)
case INIT_UMASK:
*value = _hurd_umask;
return 0;
case INIT_SIGMASK:
{
struct hurd_sigstate *ss = _hurd_thread_sigstate (_hurd_sigthread);
__spin_lock (&ss->lock);
*value = ss->blocked;
__spin_unlock (&ss->lock);
return 0;
}
case INIT_SIGPENDING:
{
struct hurd_sigstate *ss = _hurd_thread_sigstate (_hurd_sigthread);
struct hurd_sigstate *ss = _hurd_global_sigstate;
__spin_lock (&ss->lock);
*value = ss->pending;
__spin_unlock (&ss->lock);
@ -139,7 +131,7 @@ get_int (int which, int *value)
}
case INIT_SIGIGN:
{
struct hurd_sigstate *ss = _hurd_thread_sigstate (_hurd_sigthread);
struct hurd_sigstate *ss = _hurd_global_sigstate;
sigset_t ign;
int sig;
__spin_lock (&ss->lock);
@ -207,17 +199,9 @@ set_int (int which, int value)
return 0;
/* These are pretty odd things to do. But you asked for it. */
case INIT_SIGMASK:
{
struct hurd_sigstate *ss = _hurd_thread_sigstate (_hurd_sigthread);
__spin_lock (&ss->lock);
ss->blocked = value;
__spin_unlock (&ss->lock);
return 0;
}
case INIT_SIGPENDING:
{
struct hurd_sigstate *ss = _hurd_thread_sigstate (_hurd_sigthread);
struct hurd_sigstate *ss = _hurd_global_sigstate;
__spin_lock (&ss->lock);
ss->pending = value;
__spin_unlock (&ss->lock);
@ -225,7 +209,7 @@ set_int (int which, int value)
}
case INIT_SIGIGN:
{
struct hurd_sigstate *ss = _hurd_thread_sigstate (_hurd_sigthread);
struct hurd_sigstate *ss = _hurd_global_sigstate;
int sig;
const sigset_t ign = value;
__spin_lock (&ss->lock);

280
hurd/hurdsig.c
View file

@ -46,9 +46,6 @@ mach_port_t _hurd_msgport;
/* Thread listening on it. */
thread_t _hurd_msgport_thread;
/* Thread which receives task-global signals. */
thread_t _hurd_sigthread;
/* These are set up by _hurdsig_init. */
unsigned long int __hurd_sigthread_stack_base;
unsigned long int __hurd_sigthread_stack_end;
@ -56,6 +53,9 @@ unsigned long int __hurd_sigthread_stack_end;
/* Linked-list of per-thread signal state. */
struct hurd_sigstate *_hurd_sigstates;
/* Sigstate for the task-global signals. */
struct hurd_sigstate *_hurd_global_sigstate;
/* Timeout for RPC's after interrupt_operation. */
mach_msg_timeout_t _hurd_interrupted_rpc_timeout = 60000;
@ -84,7 +84,7 @@ _hurd_thread_sigstate (thread_t thread)
{
ss = malloc (sizeof (*ss));
if (ss == NULL)
__libc_fatal ("hurd: Can't allocate thread sigstate\n");
__libc_fatal ("hurd: Can't allocate sigstate\n");
ss->thread = thread;
__spin_lock_init (&ss->lock);
@ -98,16 +98,19 @@ _hurd_thread_sigstate (thread_t thread)
ss->intr_port = MACH_PORT_NULL;
ss->context = NULL;
/* Initialize the sigaction vector from the default signal receiving
thread's state, and its from the system defaults. */
if (thread == _hurd_sigthread)
default_sigaction (ss->actions);
if (thread == MACH_PORT_NULL)
{
/* Process-wide sigstate, use the system defaults. */
default_sigaction (ss->actions);
/* The global sigstate is not added to the _hurd_sigstates list.
It is created with _hurd_thread_sigstate (MACH_PORT_NULL)
but should be accessed through _hurd_global_sigstate. */
}
else
{
struct hurd_sigstate *s;
for (s = _hurd_sigstates; s != NULL; s = s->next)
if (s->thread == _hurd_sigthread)
break;
/* Use the global actions as a default for new threads. */
struct hurd_sigstate *s = _hurd_global_sigstate;
if (s)
{
__spin_lock (&s->lock);
@ -116,15 +119,115 @@ _hurd_thread_sigstate (thread_t thread)
}
else
default_sigaction (ss->actions);
}
ss->next = _hurd_sigstates;
_hurd_sigstates = ss;
ss->next = _hurd_sigstates;
_hurd_sigstates = ss;
}
}
__mutex_unlock (&_hurd_siglock);
return ss;
}
libc_hidden_def (_hurd_thread_sigstate)
/* Destroy a sigstate structure. Called by libpthread just before the
* corresponding thread is terminated (the kernel thread port must remain valid
* until this function is called.) */
void
_hurd_sigstate_delete (thread_t thread)
{
struct hurd_sigstate **ssp, *ss;
__mutex_lock (&_hurd_siglock);
for (ssp = &_hurd_sigstates; *ssp; ssp = &(*ssp)->next)
if ((*ssp)->thread == thread)
break;
ss = *ssp;
if (ss)
*ssp = ss->next;
__mutex_unlock (&_hurd_siglock);
if (ss)
free (ss);
}
/* Make SS a global receiver, with pthread signal semantics. */
void
_hurd_sigstate_set_global_rcv (struct hurd_sigstate *ss)
{
assert (ss->thread != MACH_PORT_NULL);
ss->actions[0].sa_handler = SIG_IGN;
}
/* Check whether SS is a global receiver. */
static int
sigstate_is_global_rcv (const struct hurd_sigstate *ss)
{
return (_hurd_global_sigstate != NULL)
&& (ss->actions[0].sa_handler == SIG_IGN);
}
libc_hidden_def (_hurd_sigstate_delete)
/* Lock/unlock a hurd_sigstate structure. If the accessors below require
it, the global sigstate will be locked as well. */
void
_hurd_sigstate_lock (struct hurd_sigstate *ss)
{
if (sigstate_is_global_rcv (ss))
__spin_lock (&_hurd_global_sigstate->lock);
__spin_lock (&ss->lock);
}
void
_hurd_sigstate_unlock (struct hurd_sigstate *ss)
{
__spin_unlock (&ss->lock);
if (sigstate_is_global_rcv (ss))
__spin_unlock (&_hurd_global_sigstate->lock);
}
libc_hidden_def (_hurd_sigstate_set_global_rcv)
/* Retreive a thread's full set of pending signals, including the global
ones if appropriate. SS must be locked. */
sigset_t
_hurd_sigstate_pending (const struct hurd_sigstate *ss)
{
sigset_t pending = ss->pending;
if (sigstate_is_global_rcv (ss))
__sigorset (&pending, &pending, &_hurd_global_sigstate->pending);
return pending;
}
/* Clear a pending signal and return the associated detailed
signal information. SS must be locked, and must have signal SIGNO
pending, either directly or through the global sigstate. */
static struct hurd_signal_detail
sigstate_clear_pending (struct hurd_sigstate *ss, int signo)
{
if (sigstate_is_global_rcv (ss)
&& __sigismember (&_hurd_global_sigstate->pending, signo))
{
__sigdelset (&_hurd_global_sigstate->pending, signo);
return _hurd_global_sigstate->pending_data[signo];
}
assert (__sigismember (&ss->pending, signo));
__sigdelset (&ss->pending, signo);
return ss->pending_data[signo];
}
libc_hidden_def (_hurd_sigstate_lock)
libc_hidden_def (_hurd_sigstate_unlock)
/* Retreive a thread's action vector. SS must be locked. */
struct sigaction *
_hurd_sigstate_actions (struct hurd_sigstate *ss)
{
if (sigstate_is_global_rcv (ss))
return _hurd_global_sigstate->actions;
else
return ss->actions;
}
libc_hidden_def (_hurd_sigstate_pending)
/* Signal delivery itself is on this page. */
@ -219,6 +322,8 @@ static void
abort_thread (struct hurd_sigstate *ss, struct machine_thread_all_state *state,
void (*reply) (void))
{
assert (ss->thread != MACH_PORT_NULL);
if (!(state->set & THREAD_ABORTED))
{
error_t err = __thread_abort (ss->thread);
@ -367,7 +472,7 @@ _hurdsig_abort_rpcs (struct hurd_sigstate *ss, int signo, int sigthread,
call above will retry their RPCs unless we clear SS->intr_port.
So we clear it for the thread taking a signal when SA_RESTART is
clear, so that its call returns EINTR. */
if (! signo || !(ss->actions[signo].sa_flags & SA_RESTART))
if (! signo || !(_hurd_sigstate_actions (ss) [signo].sa_flags & SA_RESTART))
ss->intr_port = MACH_PORT_NULL;
}
@ -490,9 +595,11 @@ weak_alias (_hurdsig_preemptors, _hurdsig_preempters)
| sigmask (SIGSTOP) | sigmask (SIGTSTP))
/* Actual delivery of a single signal. Called with SS unlocked. When
the signal is delivered, return 1 with SS locked. If the signal is
being traced, return 0 with SS unlocked. */
static int
the signal is delivered, return SS, locked (or, if SS was originally
_hurd_global_sigstate, the sigstate of the actual thread the signal
was delivered to). If the signal is being traced, return NULL with
SS unlocked. */
static struct hurd_sigstate *
post_signal (struct hurd_sigstate *ss,
int signo, struct hurd_signal_detail *detail,
int untraced, void (*reply) (void))
@ -545,8 +652,12 @@ post_signal (struct hurd_sigstate *ss,
assert_perror (err);
for (i = 0; i < nthreads; ++i)
{
if (threads[i] != _hurd_msgport_thread
&& (act != handle || threads[i] != ss->thread))
if (act == handle && threads[i] == ss->thread)
{
/* The thread that will run the handler is kept suspended. */
ss_suspended = 1;
}
else if (threads[i] != _hurd_msgport_thread)
{
err = __thread_resume (threads[i]);
assert_perror (err);
@ -559,9 +670,6 @@ post_signal (struct hurd_sigstate *ss,
(vm_address_t) threads,
nthreads * sizeof *threads);
_hurd_stopped = 0;
if (act == handle)
/* The thread that will run the handler is already suspended. */
ss_suspended = 1;
}
error_t err;
@ -577,13 +685,43 @@ post_signal (struct hurd_sigstate *ss,
}
/* This call is just to check for pending signals. */
__spin_lock (&ss->lock);
return 1;
_hurd_sigstate_lock (ss);
return ss;
}
thread_state.set = 0; /* We know nothing. */
__spin_lock (&ss->lock);
_hurd_sigstate_lock (ss);
/* If this is a global signal, try to find a thread ready to accept
it right away. This is especially important for untraced signals,
since going through the global pending mask would de-untrace them. */
if (ss->thread == MACH_PORT_NULL)
{
struct hurd_sigstate *rss;
__mutex_lock (&_hurd_siglock);
for (rss = _hurd_sigstates; rss != NULL; rss = rss->next)
{
if (! sigstate_is_global_rcv (rss))
continue;
/* The global sigstate is already locked. */
__spin_lock (&rss->lock);
if (! __sigismember (&rss->blocked, signo))
{
ss = rss;
break;
}
__spin_unlock (&rss->lock);
}
__mutex_unlock (&_hurd_siglock);
}
/* We want the preemptors to be able to update the blocking mask
without affecting the delivery of this signal, so we save the
current value to test against later. */
sigset_t blocked = ss->blocked;
/* Check for a preempted signal. Preempted signals can arrive during
critical sections. */
@ -641,12 +779,12 @@ post_signal (struct hurd_sigstate *ss,
mark_pending ();
else
suspend ();
__spin_unlock (&ss->lock);
_hurd_sigstate_unlock (ss);
reply ();
return 0;
return NULL;
}
handler = ss->actions[signo].sa_handler;
handler = _hurd_sigstate_actions (ss) [signo].sa_handler;
if (handler == SIG_DFL)
/* Figure out the default action for this signal. */
@ -739,9 +877,7 @@ post_signal (struct hurd_sigstate *ss,
}
/* Handle receipt of a blocked signal, or any signal while stopped. */
if (act != ignore /* Signals ignored now are forgotten now. */
&& __sigismember (&ss->blocked, signo)
|| (signo != SIGKILL && _hurd_stopped))
if (__sigismember (&blocked, signo) || (signo != SIGKILL && _hurd_stopped))
{
mark_pending ();
act = ignore;
@ -776,6 +912,7 @@ post_signal (struct hurd_sigstate *ss,
now's the time to set it going. */
if (ss_suspended)
{
assert (ss->thread != MACH_PORT_NULL);
err = __thread_resume (ss->thread);
assert_perror (err);
ss_suspended = 0;
@ -820,6 +957,8 @@ post_signal (struct hurd_sigstate *ss,
struct sigcontext *scp, ocontext;
int wait_for_reply, state_changed;
assert (ss->thread != MACH_PORT_NULL);
/* Stop the thread and abort its pending RPC operations. */
if (! ss_suspended)
{
@ -956,23 +1095,25 @@ post_signal (struct hurd_sigstate *ss,
}
}
struct sigaction *action = & _hurd_sigstate_actions (ss) [signo];
/* Backdoor extra argument to signal handler. */
scp->sc_error = detail->error;
/* Block requested signals while running the handler. */
scp->sc_mask = ss->blocked;
__sigorset (&ss->blocked, &ss->blocked, &ss->actions[signo].sa_mask);
__sigorset (&ss->blocked, &ss->blocked, &action->sa_mask);
/* Also block SIGNO unless we're asked not to. */
if (! (ss->actions[signo].sa_flags & (SA_RESETHAND | SA_NODEFER)))
if (! (action->sa_flags & (SA_RESETHAND | SA_NODEFER)))
__sigaddset (&ss->blocked, signo);
/* Reset to SIG_DFL if requested. SIGILL and SIGTRAP cannot
be automatically reset when delivered; the system silently
enforces this restriction. */
if (ss->actions[signo].sa_flags & SA_RESETHAND
if (action->sa_flags & SA_RESETHAND
&& signo != SIGILL && signo != SIGTRAP)
ss->actions[signo].sa_handler = SIG_DFL;
action->sa_handler = SIG_DFL;
/* Any sigsuspend call must return after the handler does. */
wake_sigsuspend (ss);
@ -990,7 +1131,7 @@ post_signal (struct hurd_sigstate *ss,
}
}
return 1;
return ss;
}
/* Return the set of pending signals in SS which should be delivered. */
@ -1005,7 +1146,7 @@ pending_signals (struct hurd_sigstate *ss)
if (_hurd_stopped || __spin_lock_locked (&ss->critical_section_lock))
return 0;
return ss->pending & ~ss->blocked;
return _hurd_sigstate_pending (ss) & ~ss->blocked;
}
/* Post the specified pending signals in SS and return 1. If one of
@ -1017,12 +1158,15 @@ post_pending (struct hurd_sigstate *ss, sigset_t pending, void (*reply) (void))
int signo;
struct hurd_signal_detail detail;
/* Make sure SS corresponds to an actual thread, since we assume it won't
change in post_signal. */
assert (ss->thread != MACH_PORT_NULL);
for (signo = 1; signo < NSIG; ++signo)
if (__sigismember (&pending, signo))
{
__sigdelset (&ss->pending, signo);
detail = ss->pending_data[signo];
__spin_unlock (&ss->lock);
detail = sigstate_clear_pending (ss, signo);
_hurd_sigstate_unlock (ss);
/* Will reacquire the lock, except if the signal is traced. */
if (! post_signal (ss, signo, &detail, 0, reply))
@ -1030,7 +1174,7 @@ post_pending (struct hurd_sigstate *ss, sigset_t pending, void (*reply) (void))
}
/* No more signals pending; SS->lock is still locked. */
__spin_unlock (&ss->lock);
_hurd_sigstate_unlock (ss);
return 1;
}
@ -1048,14 +1192,14 @@ post_all_pending_signals (void (*reply) (void))
__mutex_lock (&_hurd_siglock);
for (ss = _hurd_sigstates; ss != NULL; ss = ss->next)
{
__spin_lock (&ss->lock);
_hurd_sigstate_lock (ss);
pending = pending_signals (ss);
if (pending)
/* post_pending() below will unlock SS. */
break;
__spin_unlock (&ss->lock);
_hurd_sigstate_unlock (ss);
}
__mutex_unlock (&_hurd_siglock);
@ -1088,11 +1232,12 @@ _hurd_internal_post_signal (struct hurd_sigstate *ss,
assert_perror (err);
}
if (! post_signal (ss, signo, detail, untraced, reply))
ss = post_signal (ss, signo, detail, untraced, reply);
if (! ss)
return;
/* The signal was neither fatal nor traced. We still hold SS->lock. */
if (signo != 0)
if (signo != 0 && ss->thread != MACH_PORT_NULL)
{
/* The signal has either been ignored or is now being handled. We can
consider it delivered and reply to the killer. */
@ -1104,8 +1249,9 @@ _hurd_internal_post_signal (struct hurd_sigstate *ss,
}
else
{
/* We need to check for pending signals for all threads. */
__spin_unlock (&ss->lock);
/* If this was a process-wide signal or a poll request, we need
to check for pending signals for all threads. */
_hurd_sigstate_unlock (ss);
if (! post_all_pending_signals (reply))
return;
@ -1231,9 +1377,10 @@ _S_msg_sig_post (mach_port_t me,
d.code = sigcode;
d.exc = 0;
/* Post the signal to the designated signal-receiving thread. This will
reply when the signal can be considered delivered. */
_hurd_internal_post_signal (_hurd_thread_sigstate (_hurd_sigthread),
/* Post the signal to a global receiver thread (or mark it pending in
the global sigstate). This will reply when the signal can be
considered delivered. */
_hurd_internal_post_signal (_hurd_global_sigstate,
signo, &d, reply_port, reply_port_type,
0); /* Stop if traced. */
@ -1261,7 +1408,7 @@ _S_msg_sig_post_untraced (mach_port_t me,
/* Post the signal to the designated signal-receiving thread. This will
reply when the signal can be considered delivered. */
_hurd_internal_post_signal (_hurd_thread_sigstate (_hurd_sigthread),
_hurd_internal_post_signal (_hurd_global_sigstate,
signo, &d, reply_port, reply_port_type,
1); /* Untraced flag. */
@ -1272,8 +1419,8 @@ extern void __mig_init (void *);
#include <mach/task_special_ports.h>
/* Initialize the message port and _hurd_sigthread and start the signal
thread. */
/* Initialize the message port, _hurd_global_sigstate, and start the
signal thread. */
void
_hurdsig_init (const int *intarray, size_t intarraysize)
@ -1296,27 +1443,34 @@ _hurdsig_init (const int *intarray, size_t intarraysize)
MACH_MSG_TYPE_MAKE_SEND);
assert_perror (err);
/* Initialize the global signal state. */
_hurd_global_sigstate = _hurd_thread_sigstate (MACH_PORT_NULL);
/* We block all signals, and let actual threads pull them from the
pending mask. */
__sigfillset(& _hurd_global_sigstate->blocked);
/* Initialize the main thread's signal state. */
ss = _hurd_self_sigstate ();
/* Copy inherited values from our parent (or pre-exec process state)
into the signal settings of the main thread. */
/* Mark it as a process-wide signal receiver. Threads in this set use
the common action vector in _hurd_global_sigstate. */
_hurd_sigstate_set_global_rcv (ss);
/* Copy inherited signal settings from our parent (or pre-exec process
state) */
if (intarraysize > INIT_SIGMASK)
ss->blocked = intarray[INIT_SIGMASK];
if (intarraysize > INIT_SIGPENDING)
ss->pending = intarray[INIT_SIGPENDING];
_hurd_global_sigstate->pending = intarray[INIT_SIGPENDING];
if (intarraysize > INIT_SIGIGN && intarray[INIT_SIGIGN] != 0)
{
int signo;
for (signo = 1; signo < NSIG; ++signo)
if (intarray[INIT_SIGIGN] & __sigmask(signo))
ss->actions[signo].sa_handler = SIG_IGN;
_hurd_global_sigstate->actions[signo].sa_handler = SIG_IGN;
}
/* Set the default thread to receive task-global signals
to this one, the main (first) user thread. */
_hurd_sigthread = ss->thread;
/* Start the signal thread listening on the message port. */
#pragma weak __cthread_fork

5
sysdeps/hurd/include/hurd/signal.h
View file

@ -11,6 +11,11 @@ libc_hidden_proto (_hurd_exception2signal)
libc_hidden_proto (_hurd_intr_rpc_mach_msg)
libc_hidden_proto (_hurd_thread_sigstate)
libc_hidden_proto (_hurd_raise_signal)
libc_hidden_proto (_hurd_sigstate_set_global_rcv)
libc_hidden_proto (_hurd_sigstate_lock)
libc_hidden_proto (_hurd_sigstate_pending)
libc_hidden_proto (_hurd_sigstate_unlock)
libc_hidden_proto (_hurd_sigstate_delete)
#endif
#ifdef _HURD_SIGNAL_H_HIDDEN_DEF
libc_hidden_def (_hurd_self_sigstate)

2
sysdeps/mach/hurd/Makefile
View file

@ -211,4 +211,6 @@ ifeq ($(subdir),nis)
CFLAGS-ypclnt.c += -DUSE_BINDINGDIR=1
endif
LDLIBS-pthread.so += $(objdir)/hurd/libhurduser.so
endif # in-Makerules

28
sysdeps/mach/hurd/fork.c
View file

@ -445,6 +445,7 @@ __fork (void)
thread,
MACH_MSG_TYPE_COPY_SEND)))
LOSE;
/* XXX consumed? (_hurd_sigthread is no more) */
if (thread_refs > 1
&& (err = __mach_port_mod_refs (newtask, ss->thread,
MACH_PORT_RIGHT_SEND,
@ -610,10 +611,6 @@ __fork (void)
for (i = 0; i < _hurd_nports; ++i)
__spin_unlock (&_hurd_ports[i].lock);
/* We are one of the (exactly) two threads in this new task, we
will take the task-global signals. */
_hurd_sigthread = ss->thread;
/* Claim our sigstate structure and unchain the rest: the
threads existed in the parent task but don't exist in this
task (the child process). Delay freeing them until later
@ -633,6 +630,25 @@ __fork (void)
ss->next = NULL;
_hurd_sigstates = ss;
__mutex_unlock (&_hurd_siglock);
/* Earlier on, the global sigstate may have been tainted and now needs to
be reinitialized. Nobody is interested in its present state anymore:
we're not, the signal thread will be restarted, and there are no other
threads.
We can't simply allocate a fresh global sigstate here, as
_hurd_thread_sigstate will call malloc and that will deadlock trying
to determine the current thread's sigstate. */
#if 0
_hurd_thread_sigstate_init (_hurd_global_sigstate, MACH_PORT_NULL);
#else
/* Only reinitialize the lock -- otherwise we might have to do additional
setup as done in hurdsig.c:_hurdsig_init. */
__spin_lock_init (&_hurd_global_sigstate->lock);
#endif
/* We are one of the (exactly) two threads in this new task, we
will take the task-global signals. */
_hurd_sigstate_set_global_rcv (ss);
/* Fetch our new process IDs from the proc server. No need to
refetch our pgrp; it is always inherited from the parent (so
@ -641,8 +657,10 @@ __fork (void)
err = __USEPORT (PROC, __proc_getpids (port, &_hurd_pid, &_hurd_ppid,
&_hurd_orphaned));
/* Forking clears the trace flag. */
/* Forking clears the trace flag and pending masks. */
__sigemptyset (&_hurdsig_traced);
__sigemptyset (&_hurd_global_sigstate->pending);
__sigemptyset (&ss->pending);
/* Release malloc locks. */
_hurd_malloc_fork_child ();

2
sysdeps/mach/hurd/htl/pt-sigstate-destroy.c
View file

@ -17,10 +17,12 @@
<https://www.gnu.org/licenses/>. */
#include <pthread.h>
#include <hurd/signal.h>
#include <pt-internal.h>
void
__pthread_sigstate_destroy (struct __pthread *thread)
{
_hurd_sigstate_delete (thread->kernel_thread);
}

2
sysdeps/mach/hurd/htl/pt-sigstate-init.c
View file

@ -35,7 +35,7 @@ __pthread_sigstate_init (struct __pthread *thread)
if (do_init_global)
{
struct hurd_sigstate *ss = _hurd_thread_sigstate (thread->kernel_thread);
(void) ss;
_hurd_sigstate_set_global_rcv (ss);
}
else if (__pthread_num_threads >= 2)
do_init_global = 1;

12
sysdeps/mach/hurd/htl/pt-sigstate.c
View file

@ -20,6 +20,7 @@
#include <assert.h>
#include <signal.h>
#include <hurd/signal.h>
#include <hurd/msg.h>
#include <pt-internal.h>
@ -29,11 +30,12 @@ __pthread_sigstate (struct __pthread *thread, int how,
{
error_t err = 0;
struct hurd_sigstate *ss;
sigset_t pending;
ss = _hurd_thread_sigstate (thread->kernel_thread);
assert (ss);
__spin_lock (&ss->lock);
_hurd_sigstate_lock (ss);
if (oset != NULL)
*oset = ss->blocked;
@ -64,7 +66,13 @@ __pthread_sigstate (struct __pthread *thread, int how,
if (!err && clear_pending)
__sigemptyset (&ss->pending);
__spin_unlock (&ss->lock);
pending = _hurd_sigstate_pending (ss) & ~ss->blocked;
_hurd_sigstate_unlock (ss);
if (!err && pending)
/* Send a message to the signal thread so it
will wake up and check for pending signals. */
__msg_sig_post (_hurd_msgport, 0, 0, __mach_task_self ());
return err;
}

10
sysdeps/mach/hurd/i386/sigreturn.c
View file

@ -30,7 +30,7 @@ static void
__sigreturn2 (int *usp)
{
struct hurd_sigstate *ss = _hurd_self_sigstate ();
__spin_unlock (&ss->lock);
_hurd_sigstate_unlock (ss);
sp = usp;
#define A(line) asm volatile (#line)
@ -68,7 +68,7 @@ __sigreturn (struct sigcontext *scp)
}
ss = _hurd_self_sigstate ();
__spin_lock (&ss->lock);
_hurd_sigstate_lock (ss);
/* Remove the link on the `active resources' chain added by
_hurd_setup_sighandler. Its purpose was to make sure
@ -80,19 +80,19 @@ __sigreturn (struct sigcontext *scp)
ss->intr_port = scp->sc_intr_port;
/* Check for pending signals that were blocked by the old set. */
if (ss->pending & ~ss->blocked)
if (_hurd_sigstate_pending (ss) & ~ss->blocked)
{
/* There are pending signals that just became unblocked. Wake up the
signal thread to deliver them. But first, squirrel away SCP where
the signal thread will notice it if it runs another handler, and
arrange to have us called over again in the new reality. */
ss->context = scp;
__spin_unlock (&ss->lock);
_hurd_sigstate_unlock (ss);
__msg_sig_post (_hurd_msgport, 0, 0, __mach_task_self ());
/* If a pending signal was handled, sig_post never returned.
If it did return, the pending signal didn't run a handler;
proceed as usual. */
__spin_lock (&ss->lock);
_hurd_sigstate_lock (ss);
ss->context = NULL;
}

7
sysdeps/mach/hurd/i386/trampoline.c
View file

@ -37,6 +37,7 @@ _hurd_setup_sighandler (struct hurd_sigstate *ss, __sighandler_t handler,
void firewall (void);
extern const void _hurd_intr_rpc_msg_cx_sp;
extern const void _hurd_intr_rpc_msg_sp_restored;
const struct sigaction *action;
void *volatile sigsp;
struct sigcontext *scp;
struct
@ -93,7 +94,11 @@ _hurd_setup_sighandler (struct hurd_sigstate *ss, __sighandler_t handler,
the SP on sigreturn. */
state->basic.uesp = state->basic.ecx;
if ((ss->actions[signo].sa_flags & SA_ONSTACK)
/* XXX what if handler != action->handler (for instance, if a signal
* preemptor took over) ? */
action = & _hurd_sigstate_actions (ss) [signo];
if ((action->sa_flags & SA_ONSTACK)
&& !(ss->sigaltstack.ss_flags & (SS_DISABLE|SS_ONSTACK)))
{
sigsp = ss->sigaltstack.ss_sp + ss->sigaltstack.ss_size;

16
sysdeps/mach/hurd/sigaction.c
View file

@ -46,15 +46,15 @@ __sigaction (int sig, const struct sigaction *act, struct sigaction *oact)
ss = _hurd_self_sigstate ();
__spin_lock (&ss->critical_section_lock);
__spin_lock (&ss->lock);
old = ss->actions[sig];
_hurd_sigstate_lock (ss);
old = _hurd_sigstate_actions (ss) [sig];
if (act != NULL)
ss->actions[sig] = a;
_hurd_sigstate_actions (ss) [sig] = a;
if (act != NULL && sig == SIGCHLD
&& (a.sa_flags & SA_NOCLDSTOP) != (old.sa_flags & SA_NOCLDSTOP))
{
__spin_unlock (&ss->lock);
_hurd_sigstate_unlock (ss);
/* Inform the proc server whether or not it should send us SIGCHLD for
stopped children. We do this in a critical section so that no
@ -62,8 +62,8 @@ __sigaction (int sig, const struct sigaction *act, struct sigaction *oact)
__USEPORT (PROC,
__proc_mod_stopchild (port, !(a.sa_flags & SA_NOCLDSTOP)));
__spin_lock (&ss->lock);
pending = ss->pending & ~ss->blocked;
_hurd_sigstate_lock (ss);
pending = _hurd_sigstate_pending (ss) & ~ss->blocked;
}
else if (act != NULL && (a.sa_handler == SIG_IGN || a.sa_handler == SIG_DFL))
/* We are changing to an action that might be to ignore SIG signals.
@ -72,11 +72,11 @@ __sigaction (int sig, const struct sigaction *act, struct sigaction *oact)
back and then SIG is unblocked, the signal pending now should not
arrive. So wake up the signal thread to check the new state and do
the right thing. */
pending = ss->pending & __sigmask (sig);
pending = _hurd_sigstate_pending (ss) & __sigmask (sig);
else
pending = 0;
__spin_unlock (&ss->lock);
_hurd_sigstate_unlock (ss);
__spin_unlock (&ss->critical_section_lock);
if (pending)

6
sysdeps/mach/hurd/sigpending.c
View file

@ -36,9 +36,9 @@ sigpending (sigset_t *set)
}
ss = _hurd_self_sigstate ();
__spin_lock (&ss->lock);
pending = ss->pending;
__spin_unlock (&ss->lock);
_hurd_sigstate_lock (ss);
pending = _hurd_sigstate_pending (ss);
_hurd_sigstate_unlock (ss);
*set = pending;
return 0;

8
sysdeps/mach/hurd/sigprocmask.c
View file

@ -36,7 +36,7 @@ __sigprocmask (int how, const sigset_t *set, sigset_t *oset)
ss = _hurd_self_sigstate ();
__spin_lock (&ss->lock);
_hurd_sigstate_lock (ss);
old = ss->blocked;
@ -57,7 +57,7 @@ __sigprocmask (int how, const sigset_t *set, sigset_t *oset)
break;
default:
__spin_unlock (&ss->lock);
_hurd_sigstate_unlock (ss);
errno = EINVAL;
return -1;
}
@ -65,9 +65,9 @@ __sigprocmask (int how, const sigset_t *set, sigset_t *oset)
ss->blocked &= ~_SIG_CANT_MASK;
}
pending = ss->pending & ~ss->blocked;
pending = _hurd_sigstate_pending (ss) & ~ss->blocked;
__spin_unlock (&ss->lock);
_hurd_sigstate_unlock (ss);
if (oset != NULL)
*oset = old;

15
sysdeps/mach/hurd/sigsuspend.c
View file

@ -40,7 +40,7 @@ __sigsuspend (const sigset_t *set)
ss = _hurd_self_sigstate ();
__spin_lock (&ss->lock);
_hurd_sigstate_lock (ss);
oldmask = ss->blocked;
if (set != NULL)
@ -48,11 +48,11 @@ __sigsuspend (const sigset_t *set)
ss->blocked = newmask & ~_SIG_CANT_MASK;
/* Notice if any pending signals just became unblocked. */
pending = ss->pending & ~ss->blocked;
pending = _hurd_sigstate_pending (ss) & ~ss->blocked;
/* Tell the signal thread to message us when a signal arrives. */
ss->suspended = wait;
__spin_unlock (&ss->lock);
_hurd_sigstate_unlock (ss);
if (pending)
/* Tell the signal thread to check for pending signals. */
@ -63,10 +63,11 @@ __sigsuspend (const sigset_t *set)
MACH_MSG_TIMEOUT_NONE, MACH_PORT_NULL);
__mach_port_destroy (__mach_task_self (), wait);
__spin_lock (&ss->lock);
ss->blocked = oldmask; /* Restore the old mask. */
pending = ss->pending & ~ss->blocked; /* Again check for pending signals. */
__spin_unlock (&ss->lock);
/* Restore the old mask and check for pending signals again. */
_hurd_sigstate_lock (ss);
ss->blocked = oldmask;
pending = _hurd_sigstate_pending(ss) & ~ss->blocked;
_hurd_sigstate_unlock (ss);
if (pending)
/* Tell the signal thread to check for pending signals. */

21
sysdeps/mach/hurd/sigwait.c
View file

@ -27,7 +27,7 @@ int
__sigwait (const sigset_t *set, int *sig)
{
struct hurd_sigstate *ss;
sigset_t mask, ready;
sigset_t mask, ready, blocked;
int signo = 0;
struct hurd_signal_preemptor preemptor;
jmp_buf buf;
@ -49,8 +49,8 @@ __sigwait (const sigset_t *set, int *sig)
/* Make sure this is all kosher */
assert (__sigismember (&mask, signo));
/* Make sure this signal is unblocked */
__sigdelset (&ss->blocked, signo);
/* Restore the blocking mask. */
ss->blocked = blocked;
return pe->handler;
}
@ -71,10 +71,11 @@ __sigwait (const sigset_t *set, int *sig)
__sigemptyset (&mask);
ss = _hurd_self_sigstate ();
__spin_lock (&ss->lock);
_hurd_sigstate_lock (ss);
/* See if one of these signals is currently pending. */
__sigandset (&ready, &ss->pending, &mask);
sigset_t pending = _hurd_sigstate_pending (ss);
__sigandset (&ready, &pending, &mask);
if (! __sigisemptyset (&ready))
{
for (signo = 1; signo < NSIG; signo++)
@ -102,7 +103,11 @@ __sigwait (const sigset_t *set, int *sig)
preemptor.next = ss->preemptors;
ss->preemptors = &preemptor;
__spin_unlock (&ss->lock);
/* Unblock the expected signals */
blocked = ss->blocked;
ss->blocked &= ~mask;
_hurd_sigstate_unlock (ss);
/* Wait. */
__mach_msg (&msg, MACH_RCV_MSG, 0, sizeof (msg), wait,
@ -113,7 +118,7 @@ __sigwait (const sigset_t *set, int *sig)
{
assert (signo);
__spin_lock (&ss->lock);
_hurd_sigstate_lock (ss);
/* Delete our preemptor. */
assert (ss->preemptors == &preemptor);
@ -122,7 +127,7 @@ __sigwait (const sigset_t *set, int *sig)
all_done:
spin_unlock (&ss->lock);
_hurd_sigstate_unlock (ss);
__mach_port_destroy (__mach_task_self (), wait);
*sig = signo;

23
sysdeps/mach/hurd/spawni.c
View file

@ -336,26 +336,29 @@ __spawni (pid_t *pid, const char *file,
assert (! __spin_lock_locked (&ss->critical_section_lock));
__spin_lock (&ss->critical_section_lock);
__spin_lock (&ss->lock);
_hurd_sigstate_lock (ss);
ints[INIT_SIGMASK] = ss->blocked;
ints[INIT_SIGPENDING] = ss->pending;
ints[INIT_SIGPENDING] = 0;
ints[INIT_SIGIGN] = 0;
/* Unless we were asked to reset all handlers to SIG_DFL,
pass down the set of signals that were set to SIG_IGN. */
if ((flags & POSIX_SPAWN_SETSIGDEF) == 0)
for (i = 1; i < NSIG; ++i)
if (ss->actions[i].sa_handler == SIG_IGN)
ints[INIT_SIGIGN] |= __sigmask (i);
{
struct sigaction *actions = _hurd_sigstate_actions (ss);
if ((flags & POSIX_SPAWN_SETSIGDEF) == 0)
for (i = 1; i < NSIG; ++i)
if (actions[i].sa_handler == SIG_IGN)
ints[INIT_SIGIGN] |= __sigmask (i);
}
/* We hold the sigstate lock until the exec has failed so that no signal
can arrive between when we pack the blocked and ignored signals, and
when the exec actually happens. A signal handler could change what
/* We hold the critical section lock until the exec has failed so that no
signal can arrive between when we pack the blocked and ignored signals,
and when the exec actually happens. A signal handler could change what
signals are blocked and ignored. Either the change will be reflected
in the exec, or the signal will never be delivered. Setting the
critical section flag avoids anything we call trying to acquire the
sigstate lock. */
__spin_unlock (&ss->lock);
_hurd_sigstate_unlock (ss);
/* Set signal mask. */
if ((flags & POSIX_SPAWN_SETSIGMASK) != 0)