picnoir/glibc
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

locale: Use compat_symbol_reference in _nl_postload_ctype

Browse source 
These symbol usages are not definitions, so compat_symbol_reference is
more appropriate than compat_symbol.  compat_symbol_reference is also
safe to emit multiple times (in case the inline assembly is
duplicated; this is possible because it is nested in a function).
compat_symbol does not necessarily have this property because it is
intended to provide a symbol definition.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
This commit is contained in:
Florian Weimer 2021-03-25 11:05:37 +01:00
parent 3a24ddeab5
commit 6d8fcee694
1 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
locale/lc-ctype.c
View file

@ -93,12 +93,14 @@ _nl_postload_ctype (void)
We need those relocations so that a versioned definition with a COPY
reloc in an executable will override the libc.so definition. */
compat_symbol (libc, __ctype_b, __ctype_b, GLIBC_2_0);
compat_symbol (libc, __ctype_tolower, __ctype_tolower, GLIBC_2_0);
compat_symbol (libc, __ctype_toupper, __ctype_toupper, GLIBC_2_0);
compat_symbol (libc, __ctype32_b, __ctype32_b, GLIBC_2_0);
compat_symbol (libc, __ctype32_tolower, __ctype32_tolower, GLIBC_2_2);
compat_symbol (libc, __ctype32_toupper, __ctype32_toupper, GLIBC_2_2);
compat_symbol_reference (libc, __ctype_b, __ctype_b, GLIBC_2_0);
compat_symbol_reference (libc, __ctype_tolower, __ctype_tolower, GLIBC_2_0);
compat_symbol_reference (libc, __ctype_toupper, __ctype_toupper, GLIBC_2_0);
compat_symbol_reference (libc, __ctype32_b, __ctype32_b, GLIBC_2_0);
compat_symbol_reference (libc, __ctype32_tolower, __ctype32_tolower,
GLIBC_2_2);
compat_symbol_reference (libc, __ctype32_toupper, __ctype32_toupper,
GLIBC_2_2);
__ctype_b = current (uint16_t, CLASS, 128);
__ctype_toupper = current (int32_t, TOUPPER, 128);