picnoir/glibc
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Add sysdeps/ieee754/soft-fp.

Browse source 
The default sysdeps/ieee754 fma implementations rely on exceptions and
rounding modes to achieve correct results through internal use of
round-to-odd.  Thus, glibc configurations without support for
exceptions and rounding modes instead need to use implementations of
fma based on soft-fp.

At present, this is achieved via having implementation files in
soft-fp/ that are #included by sysdeps files for each glibc
configuration that needs them.  In general this means such a
configuration has its own s_fma.c and s_fmaf.c.

TS 18661-1 adds functions that do an operation (+ - * / sqrt fma) on
arguments wider than the return type, with a single rounding of the
infinite-precision result to that return type.  These are also
naturally implemented using round-to-odd on platforms with hardware
support for rounding modes and exceptions but lacking hardware support
for these narrowing operations themselves.  (Platforms that have
direct hardware support for such narrowing operations include at least
ia64, and Power ISA 2.07 or later, which I think means POWER8 or
later.)

So adding the remaining TS 18661-1 functions would mean at least six
narrowing function implementations (fadd fsub fmul fdiv ffma fsqrt),
with aliases for other types and further implementations in some
configurations, that need to be overridden for configurations lacking
hardware exceptions and rounding modes.  Requiring all such
configurations (currently seven of them) to have their own source
files for all those functions seems undesirable.

Thus, this patch adds a directory sysdeps/ieee754/soft-fp to contain
libm function implementations based on soft-fp.  This directory is
then used via Implies from all the configurations that need it, so no
more files need adding to every such configuration when adding more
functions with soft-fp implementations.  A configuration can still
selectively #include a particular file from this directory if desired;
thus, the MIPS #include of the fmal implementation is retained, since
that's appropriate even for hard float (because long double is always
implementated in software for MIPS64, so the soft-fp implementation of
fmal is better than the ldbl-128 one).

This also provides additional motivation for my recent patch removing
--with-fp / --without-fp: previously there was no need for correct use
of --without-fp for no-FPU ARM or SH3, and now we have autodetection
nofpu/ sysdeps directories can be used by this patch for those
configurations without imposing any new requirements on how glibc is
configured.

(The mips64/*/fpu/s_fma.c files added by this patch are needed to keep
the dbl-64 version of fma for double, rather than the ldbl-128 one,
used in that case.)

Tested with build-many-glibcs.py that installed stripped shared
libraries are unchanged by this patch.

	* soft-fp/fmadf4.c: Move to ....
	* sysdeps/ieee754/soft-fp/s_fma.c: ... here.
	* soft-fp/fmasf4.c: Move to ....
	* sysdeps/ieee754/soft-fp/s_fmaf.c: ... here.
	* soft-fp/fmatf4.c: Move to ....
	* sysdeps/ieee754/soft-fp/s_fmal.c: ... here.
	* sysdeps/ieee754/soft-fp/Makefile: New file.
	* sysdeps/arm/preconfigure.ac: Define with_fp_cond.
	* sysdeps/arm/preconfigure: Regenerated.
	* sysdeps/arm/nofpu/Implies: New file.
	* sysdeps/arm/s_fma.c: Remove file.
	* sysdeps/arm/s_fmaf.c: Likewise.
	* sysdeps/m68k/coldfire/nofpu/Implies: New file.
	* sysdeps/m68k/coldfire/nofpu/s_fma.c: Remove file.
	* sysdeps/m68k/coldfire/nofpu/s_fmaf.c: Likewise.
	* sysdeps/microblaze/Implies: Add ieee754/soft-fp.
	* sysdeps/microblaze/s_fma.c: Remove file.
	* sysdeps/microblaze/s_fmaf.c: Likewise.
	* sysdeps/mips/mips32/nofpu/Implies: New file.
	* sysdeps/mips/mips64/n32/fpu/s_fma.c: Likewise.
	* sysdeps/mips/mips64/n32/nofpu/Implies: Likewise.
	* sysdeps/mips/mips64/n64/fpu/s_fma.c: Likewise.
	* sysdeps/mips/mips64/n64/nofpu/Implies: Likewise.
	* sysdeps/mips/ieee754/s_fma.c: Remove file.
	* sysdeps/mips/ieee754/s_fmaf.c: Likewise.
	* sysdeps/mips/ieee754/s_fmal.c: Update include for move of fmal
	implementation.
	* sysdeps/nios2/Implies: Add ieee754/soft-fp.
	* sysdeps/nios2/s_fma.c: Remove file.
	* sysdeps/nios2/s_fmaf.c: Likewise.
	* sysdeps/sh/nofpu/Implies: New file.
	* sysdeps/sh/s_fma.c: Remove file.
	* sysdeps/sh/s_fmaf.c: Likewise.
	* sysdeps/tile/Implies: Add ieee754/soft-fp.
	* sysdeps/tile/s_fma.c: Remove file.
	* sysdeps/tile/s_fmaf.c: Likewise.
This commit is contained in:
Joseph Myers 2017-12-12 23:34:05 +00:00
parent ac817e083b
commit 6f7c009282
33 changed files with 56 additions and 39 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

39
ChangeLog
View file

@ -1,3 +1,42 @@
2017-12-12 Joseph Myers <joseph@codesourcery.com>
* soft-fp/fmadf4.c: Move to ....
* sysdeps/ieee754/soft-fp/s_fma.c: ... here.
* soft-fp/fmasf4.c: Move to ....
* sysdeps/ieee754/soft-fp/s_fmaf.c: ... here.
* soft-fp/fmatf4.c: Move to ....
* sysdeps/ieee754/soft-fp/s_fmal.c: ... here.
* sysdeps/ieee754/soft-fp/Makefile: New file.
* sysdeps/arm/preconfigure.ac: Define with_fp_cond.
* sysdeps/arm/preconfigure: Regenerated.
* sysdeps/arm/nofpu/Implies: New file.
* sysdeps/arm/s_fma.c: Remove file.
* sysdeps/arm/s_fmaf.c: Likewise.
* sysdeps/m68k/coldfire/nofpu/Implies: New file.
* sysdeps/m68k/coldfire/nofpu/s_fma.c: Remove file.
* sysdeps/m68k/coldfire/nofpu/s_fmaf.c: Likewise.
* sysdeps/microblaze/Implies: Add ieee754/soft-fp.
* sysdeps/microblaze/s_fma.c: Remove file.
* sysdeps/microblaze/s_fmaf.c: Likewise.
* sysdeps/mips/mips32/nofpu/Implies: New file.
* sysdeps/mips/mips64/n32/fpu/s_fma.c: Likewise.
* sysdeps/mips/mips64/n32/nofpu/Implies: Likewise.
* sysdeps/mips/mips64/n64/fpu/s_fma.c: Likewise.
* sysdeps/mips/mips64/n64/nofpu/Implies: Likewise.
* sysdeps/mips/ieee754/s_fma.c: Remove file.
* sysdeps/mips/ieee754/s_fmaf.c: Likewise.
* sysdeps/mips/ieee754/s_fmal.c: Update include for move of fmal
implementation.
* sysdeps/nios2/Implies: Add ieee754/soft-fp.
* sysdeps/nios2/s_fma.c: Remove file.
* sysdeps/nios2/s_fmaf.c: Likewise.
* sysdeps/sh/nofpu/Implies: New file.
* sysdeps/sh/s_fma.c: Remove file.
* sysdeps/sh/s_fmaf.c: Likewise.
* sysdeps/tile/Implies: Add ieee754/soft-fp.
* sysdeps/tile/s_fma.c: Remove file.
* sysdeps/tile/s_fmaf.c: Likewise.
2017-12-12 H.J. Lu <hongjiu.lu@intel.com>
* sysdeps/x86_64/fpu/multiarch/Makefile (libm-sysdep_routines):

1
sysdeps/arm/nofpu/Implies Normal file
View file

@ -0,0 +1 @@
ieee754/soft-fp

1
sysdeps/arm/preconfigure
View file

@ -52,4 +52,5 @@ $as_echo "$as_me: WARNING: arm/preconfigure: Did not find ARM architecture type;
esac
machine=arm/$machine
with_fp_cond="!defined __SOFTFP__"
esac

1
sysdeps/arm/preconfigure.ac
View file

@ -47,4 +47,5 @@ arm*)
esac
machine=arm/$machine
with_fp_cond="!defined __SOFTFP__"
esac

5
sysdeps/arm/s_fma.c
View file

@ -1,5 +0,0 @@
#ifdef __SOFTFP__
# include <soft-fp/fmadf4.c>
#else
# include <sysdeps/ieee754/dbl-64/s_fma.c>
#endif

5
sysdeps/arm/s_fmaf.c
View file

@ -1,5 +0,0 @@
#ifdef __SOFTFP__
# include <soft-fp/fmasf4.c>
#else
# include <sysdeps/ieee754/dbl-64/s_fmaf.c>
#endif

3
sysdeps/ieee754/soft-fp/Makefile Normal file
View file

@ -0,0 +1,3 @@
ifeq ($(subdir),math)
CPPFLAGS += -I../soft-fp
endif

0
soft-fp/fmadf4.c → sysdeps/ieee754/soft-fp/s_fma.c
View file

0
soft-fp/fmasf4.c → sysdeps/ieee754/soft-fp/s_fmaf.c
View file

0
soft-fp/fmatf4.c → sysdeps/ieee754/soft-fp/s_fmal.c
View file

1
sysdeps/m68k/coldfire/nofpu/Implies Normal file
View file

@ -0,0 +1 @@
ieee754/soft-fp

1
sysdeps/m68k/coldfire/nofpu/s_fma.c
View file

@ -1 +0,0 @@
#include <soft-fp/fmadf4.c>

1
sysdeps/m68k/coldfire/nofpu/s_fmaf.c
View file

@ -1 +0,0 @@
#include <soft-fp/fmasf4.c>

1
sysdeps/microblaze/Implies
View file

@ -1,4 +1,5 @@
wordsize-32
# MicroBlaze uses IEEE 754 floating point.
ieee754/soft-fp
ieee754/flt-32
ieee754/dbl-64

1
sysdeps/microblaze/s_fma.c
View file

@ -1 +0,0 @@
#include <soft-fp/fmadf4.c>

1
sysdeps/microblaze/s_fmaf.c
View file

@ -1 +0,0 @@
#include <soft-fp/fmasf4.c>

5
sysdeps/mips/ieee754/s_fma.c
View file

@ -1,5 +0,0 @@
#ifdef __mips_hard_float
# include <sysdeps/ieee754/dbl-64/s_fma.c>
#else
# include <soft-fp/fmadf4.c>
#endif

5
sysdeps/mips/ieee754/s_fmaf.c
View file

@ -1,5 +0,0 @@
#ifdef __mips_hard_float
# include <sysdeps/ieee754/dbl-64/s_fmaf.c>
#else
# include <soft-fp/fmasf4.c>
#endif

2
sysdeps/mips/ieee754/s_fmal.c
View file

@ -4,4 +4,4 @@
# error "long double fma being compiled for o32 ABI"
#endif
#include <soft-fp/fmatf4.c>
#include <sysdeps/ieee754/soft-fp/s_fmal.c>

1
sysdeps/mips/mips32/nofpu/Implies Normal file
View file

@ -0,0 +1 @@
ieee754/soft-fp

1
sysdeps/mips/mips64/n32/fpu/s_fma.c Normal file
View file

@ -0,0 +1 @@
#include <sysdeps/ieee754/dbl-64/s_fma.c>

1
sysdeps/mips/mips64/n32/nofpu/Implies Normal file
View file

@ -0,0 +1 @@
ieee754/soft-fp

1
sysdeps/mips/mips64/n64/fpu/s_fma.c Normal file
View file

@ -0,0 +1 @@
#include <sysdeps/ieee754/dbl-64/s_fma.c>

1
sysdeps/mips/mips64/n64/nofpu/Implies Normal file
View file

@ -0,0 +1 @@
ieee754/soft-fp

1
sysdeps/nios2/Implies
View file

@ -1,3 +1,4 @@
wordsize-32
ieee754/soft-fp
ieee754/dbl-64
ieee754/flt-32

1
sysdeps/nios2/s_fma.c
View file

@ -1 +0,0 @@
#include <soft-fp/fmadf4.c>

1
sysdeps/nios2/s_fmaf.c
View file

@ -1 +0,0 @@
#include <soft-fp/fmasf4.c>

1
sysdeps/sh/nofpu/Implies Normal file
View file

@ -0,0 +1 @@
ieee754/soft-fp

5
sysdeps/sh/s_fma.c
View file

@ -1,5 +0,0 @@
#ifdef __SH_FPU_ANY__
# include <sysdeps/ieee754/dbl-64/s_fma.c>
#else
# include <soft-fp/fmadf4.c>
#endif

5
sysdeps/sh/s_fmaf.c
View file

@ -1,5 +0,0 @@
#ifdef __SH_FPU_ANY__
# include <sysdeps/ieee754/dbl-64/s_fmaf.c>
#else
# include <soft-fp/fmasf4.c>
#endif

1
sysdeps/tile/Implies
View file

@ -1,2 +1,3 @@
ieee754/soft-fp
ieee754/dbl-64
ieee754/flt-32

1
sysdeps/tile/s_fma.c
View file

@ -1 +0,0 @@
#include <soft-fp/fmadf4.c>

1
sysdeps/tile/s_fmaf.c
View file

@ -1 +0,0 @@
#include <soft-fp/fmasf4.c>