picnoir/glibc
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Succeed if make check does not report any errors

Browse source 
The conditional that evaluates if there are any FAILed test cases
currently always fails, since we ensure it fails if we find any
unexpected results in tests.sum and it would obviously fail if it does
not find failed results in tests.sum.  This patch fixes this by simply
inverting the result of the egrep, i.e. succeed if egrep fails (to
find failed results) and fail if it succeeds.

Tested with 'make subdirs=localedata check' and 'make subdirs=locale
check' where all tests succeed and with 'make subdirs=elf check' where
a couple of tests fail for me.

	 * Makefile (summarize-tests): Fix return value on success.
This commit is contained in:
Siddhesh Poyarekar 2015-05-19 06:36:29 +05:30
parent 920d70128b
commit 99db95db37
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ChangeLog
View file

@ -1,5 +1,7 @@
2015-05-19 Siddhesh Poyarekar <siddhesh@redhat.com>
* Makefile (summarize-tests): Fix return value on success.
* manual/string.texi (Envz Functions): Add envz_remove.
2015-05-18 Roland McGrath <roland@hack.frob.com>

2
Makefile
View file

@ -320,7 +320,7 @@ define summarize-tests
@egrep -v '^(PASS|XFAIL):' $(objpfx)$1 || true
@echo "Summary of test results$2:"
@sed 's/:.*//' < $(objpfx)$1 | sort | uniq -c
@egrep -q -v '^(X?PASS|XFAIL|UNSUPPORTED):' $(objpfx)$1 && false
@! egrep -q -v '^(X?PASS|XFAIL|UNSUPPORTED):' $(objpfx)$1
endef
tests-special-notdir = $(patsubst $(objpfx)%, %, $(tests-special))