picnoir/glibc
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

support_blob_repeat: Call mkstemp directory for the backing file

Browse source 
This avoids a warning during post-test cleanup.
This commit is contained in:
Florian Weimer 2018-10-30 13:55:50 +01:00
parent 07da99aad9
commit a91e9301c4
2 changed files with 13 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ChangeLog
View file

@ -1,3 +1,7 @@
2018-10-30 Florian Weimer <fweimer@redhat.com>
* support/blob_repeat.c (allocate_big): Call mkstemp directly.
2018-10-30 Florian Weimer <fweimer@redhat.com>
* stdlib/tst-strtod-overflow.c (do_test): Switch to

14
support/blob_repeat.c
View file

@ -23,8 +23,8 @@
#include <string.h>
#include <support/blob_repeat.h>
#include <support/check.h>
#include <support/test-driver.h>
#include <support/support.h>
#include <support/temp_file.h>
#include <support/xunistd.h>
#include <sys/mman.h>
#include <unistd.h>
@ -155,13 +155,17 @@ allocate_big (size_t total_size, const void *element, size_t element_size,
if (target == MAP_FAILED)
return (struct support_blob_repeat) { 0 };
/* Create the backing file for the repeated mapping. */
/* Create the backing file for the repeated mapping. Call mkstemp
directly to remove the resources backing the temporary file
immediately, once support_blob_repeat_free is called. Using
create_temp_file would result in a warning during post-test
cleanup. */
int fd;
{
char *temppath;
fd = create_temp_file ("support_blob_repeat-", &temppath);
char *temppath = xasprintf ("%s/support_blob_repeat-XXXXXX", test_dir);
fd = mkstemp (temppath);
if (fd < 0)
FAIL_EXIT1 ("create_temp_file: %m");
FAIL_EXIT1 ("mkstemp (\"%s\"): %m", temppath);
xunlink (temppath);
free (temppath);
}