iconv, localedef: avoid floating point rounding differences [BZ #24372]

Two cases of "int * 1.4" may result in imprecise results, which
in at least one case resulted in i686 and x86-64 producing
different locale files.  This replaced that floating point multiply
with integer operations.  While the hash table margin is increased
from 40% to 50%, testing shows only 2% increase in overall size
of the locale archive.

https://bugzilla.redhat.com/show_bug.cgi?id=1311954

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
This commit is contained in:
DJ Delorie 2019-03-20 23:56:59 -04:00
parent 61f5e9470f
commit ac64195ccd
3 changed files with 11 additions and 4 deletions

View file

@ -1,3 +1,10 @@
2019-03-21 DJ Delorie <dj@redhat.com>
[BZ #24372]
* iconv/iconvconfig.c (write_output): Replace floating point math
with integer math to avoid imprecise results.
* locale/programs/ld-collate.c (collate_output): Likewise.
2019-03-21 Stefan Liebler <stli@linux.ibm.com>
* sysdeps/s390/dl-procinfo.h (HWCAP_IMPORTANT):

View file

@ -1079,9 +1079,9 @@ write_output (void)
/* Create the hashing table. We know how many strings we have.
Creating a perfect hash table is not reasonable here. Therefore
we use open hashing and a table size which is the next prime 40%
we use open hashing and a table size which is the next prime 50%
larger than the number of strings. */
hash_size = next_prime (nnames * 1.4);
hash_size = next_prime (nnames + nnames >> 1);
hash_table = (struct hash_entry *) xcalloc (hash_size,
sizeof (struct hash_entry));
/* Fill the hash table. */

View file

@ -2401,8 +2401,8 @@ collate_output (struct localedef_t *locale, const struct charmap_t *charmap,
runp = runp->next;
}
/* Add 40% and find the next prime number. */
elem_size = next_prime (elem_size * 1.4);
/* Add 50% and find the next prime number. */
elem_size = next_prime (elem_size + elem_size >> 1);
/* Allocate the table. Each entry consists of two words: the hash
value and an index in a secondary table which provides the index