picnoir/glibc
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

tst-fmon/tst-numeric: switch malloc to static stack space [BZ #19671]

Browse source 
The current test code doesn't check the return value of malloc.
This should rarely (if ever) cause a problem, but rather than add
some return value checks, just statically allocate the buffer on
the stack.  This will never fail (or if it does, we've got much
bigger problems that don't matter to the test).
This commit is contained in:
Mike Frysinger 2016-04-22 17:11:09 -04:00
parent 4964bb4591
commit b2cae5d3f5
3 changed files with 11 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
localedata/ChangeLog
View file

@ -1,3 +1,10 @@
2016-04-23 Mike Frysinger <vapier@gentoo.org>
[BZ #19671]
* tst-fmon.c (main): Change s from malloc to s[200]. Change 2nd
arg to strfmon from 200 to sizeof (s).
* tst-numeric.c (main): Likewise.
2016-04-23 Mike Frysinger <vapier@gentoo.org>
* tst-langinfo.sh: Update YESEXPR & NOEXPR baselines to match

4
localedata/tst-fmon.c
View file

@ -40,7 +40,7 @@
int
main (int argc, char *argv[])
{
char *s = malloc (201);
char s[200];
if (setlocale (LC_MONETARY, argv[1]) == NULL)
{
@ -48,7 +48,7 @@ main (int argc, char *argv[])
exit (EXIT_SETLOCALE);
}
if (strfmon (s, 200, argv[2], (double) atof (argv[3])) == -1)
if (strfmon (s, sizeof (s), argv[2], (double) atof (argv[3])) == -1)
{
perror ("strfmon");
exit (EXIT_STRFMON);

4
localedata/tst-numeric.c
View file

@ -41,7 +41,7 @@
int
main (int argc, char *argv[])
{
char *s = malloc (201);
char s[200];
double val;
/* Make sure to read the value before setting of the locale, as
@ -54,7 +54,7 @@ main (int argc, char *argv[])
exit (EXIT_SETLOCALE);
}
if (snprintf (s, 200, argv[2], val) == -1)
if (snprintf (s, sizeof (s), argv[2], val) == -1)
{
perror ("snprintf");
exit (EXIT_SNPRINTF);