picnoir/glibc
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

configure.ac: fix bashisms in configure.ac

Browse source 
configure scripts need to be runnable with a POSIX-compliant /bin/sh.

On many (but not all!) systems, /bin/sh is provided by Bash, so errors
like this aren't spotted. Notably Debian defaults to /bin/sh provided
by dash which doesn't tolerate such bashisms as '=='.

This retains compatibility with bash.

Fixes configure warnings/errors like:
```
checking if compiler warns about alias for function with incompatible types... yes
/var/tmp/portage/sys-libs/glibc-2.34-r10/work/glibc-2.34/configure: 4209: test: xyes: unexpected operator
```

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Signed-off-by: Sam James <sam@gentoo.org>
This commit is contained in:
Sam James 2022-03-22 17:33:09 +00:00 committed by Mike Frysinger
parent d3f2c2c8b5
commit cb7b1c9014
6 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
configure vendored
View file

@ -4232,7 +4232,7 @@ if test x"$libc_cv_gcc_indirect_function" != xyes; then
# GCC 8+ emits a warning for alias with incompatible types and it might
# fail to build ifunc resolvers aliases to either weak or internal
# symbols. Disables multiarch build in this case.
if test x"$libc_cv_gcc_incompatible_alias" == xyes; then
if test x"$libc_cv_gcc_incompatible_alias" = xyes; then
{ $as_echo "$as_me:${as_lineno-$LINENO}: WARNING: gcc emits a warning for alias between functions of incompatible types" >&5
$as_echo "$as_me: WARNING: gcc emits a warning for alias between functions of incompatible types" >&2;}
if test x"$multi_arch" = xyes; then

2
configure.ac
View file

@ -767,7 +767,7 @@ if test x"$libc_cv_gcc_indirect_function" != xyes; then
# GCC 8+ emits a warning for alias with incompatible types and it might
# fail to build ifunc resolvers aliases to either weak or internal
# symbols. Disables multiarch build in this case.
if test x"$libc_cv_gcc_incompatible_alias" == xyes; then
if test x"$libc_cv_gcc_incompatible_alias" = xyes; then
AC_MSG_WARN([gcc emits a warning for alias between functions of incompatible types])
if test x"$multi_arch" = xyes; then
AC_MSG_ERROR([--enable-multi-arch support requires a gcc with gnu-indirect-function support])

2
sysdeps/powerpc/powerpc64/le/configure vendored
View file

@ -113,7 +113,7 @@ CFLAGS="$save_CFLAGS"
fi
{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $libc_cv_compiler_powerpc64le_ldbl128_mabi" >&5
$as_echo "$libc_cv_compiler_powerpc64le_ldbl128_mabi" >&6; }
if test "$libc_cv_compiler_powerpc64le_ldbl128_mabi" == "no"; then :
if test "$libc_cv_compiler_powerpc64le_ldbl128_mabi" = "no"; then :
critic_missing="$critic_missing The compiler must support -mabi=ieeelongdouble and -mlong-double-128 simultaneously."
fi

2
sysdeps/powerpc/powerpc64/le/configure.ac
View file

@ -63,7 +63,7 @@ long double x;
[libc_cv_compiler_powerpc64le_ldbl128_mabi=yes],
[libc_cv_compiler_powerpc64le_ldbl128_mabi=no])
CFLAGS="$save_CFLAGS"])
AS_IF([test "$libc_cv_compiler_powerpc64le_ldbl128_mabi" == "no"],
AS_IF([test "$libc_cv_compiler_powerpc64le_ldbl128_mabi" = "no"],
[critic_missing="$critic_missing The compiler must support -mabi=ieeelongdouble and -mlong-double-128 simultaneously."])
dnl objcopy (binutils) 2.26 or newer required to support the --update-section

2
sysdeps/powerpc/powerpc64/le/fpu/multiarch/configure vendored
View file

@ -25,7 +25,7 @@ fi
$as_echo "$libc_cv_mcpu_power10" >&6; }
config_vars="$config_vars
mcpu-power10 = $libc_cv_mcpu_power10"
if test "$libc_cv_mcpu_power10" == "yes"; then :
if test "$libc_cv_mcpu_power10" = "yes"; then :
$as_echo "#define USE_PPC64_MCPU_POWER10 1" >>confdefs.h

2
sysdeps/powerpc/powerpc64/le/fpu/multiarch/configure.ac
View file

@ -9,6 +9,6 @@ AC_COMPILE_IFELSE([AC_LANG_SOURCE([[
[libc_cv_mcpu_power10=yes],
[libc_cv_mcpu_power10=no])])
LIBC_CONFIG_VAR([mcpu-power10], [$libc_cv_mcpu_power10])
AS_IF([[test "$libc_cv_mcpu_power10" == "yes"]],[
AS_IF([[test "$libc_cv_mcpu_power10" = "yes"]],[
AC_DEFINE(USE_PPC64_MCPU_POWER10)])
CFLAGS="$OLD_CFLAGS"