picnoir/glibc
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity
glibc/libio
History
Gabriel F. T. Gomes 2d9837c1fb Set behavior of sprintf-like functions with overlapping source and destination 
According to ISO C99, passing the same buffer as source and destination
to sprintf, snprintf, vsprintf, or vsnprintf has undefined behavior.
Until the commit

  commit 4e2f43f842
  Author: Zack Weinberg <zackw@panix.com>
  Date:   Wed Mar 7 14:32:03 2018 -0500

      Use PRINTF_FORTIFY instead of _IO_FLAGS2_FORTIFY (bug 11319)

a call to sprintf or vsprintf with overlapping buffers, for instance
vsprintf (buf, "%sTEXT", buf), would append `TEXT' into buf, while a
call to snprintf or vsnprintf would override the contents of buf.
After the aforementioned commit, the behavior of sprintf and vsprintf
changed (so that they also override the contents of buf).

This patch reverts this behavioral change, because it will likely break
applications that rely on the previous behavior, even though it is
undefined by ISO C.  As noted by Szabolcs Nagy, this is used in SPEC2017
507.cactuBSSN_r/src/PUGH/PughUtils.c:

  sprintf(mess,"  Size:");
  for (i=0;i<dim+1;i++)
  {
      sprintf(mess,"%s %d",mess,pughGH->GFExtras[dim]->nsize[i]);
  }

More important to notice is the fact that the overwriting of the
destination buffer is not the only behavior affected by the refactoring.
Before the refactoring, sprintf and vsprintf would use _IO_str_jumps,
whereas __sprintf_chk and __vsprintf_chk would use _IO_str_chk_jumps.
After the refactoring, all use _IO_str_chk_jumps, which would make
sprintf and vsprintf report buffer overflows and terminate the program.
This patch also reverts this behavior, by installing the appropriate
jump table for each *sprintf functions.

Apart from reverting the changes, this patch adds a test case that has
the old behavior hardcoded, so that regressions are noticed if something
else unintentionally changes the behavior.

Tested for powerpc64le.
2019-01-02 13:53:52 -02:00
..
bits Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
__fbufsize.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
__flbf.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
__fpending.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
__fpurge.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
__freadable.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
__freading.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
__fsetlocking.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
__fwritable.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
__fwriting.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
bug-fopena+.c
bug-fseek.c
bug-ftell.c
bug-memstream1.c Add missing header files throughout the testsuite. 2017-02-16 17:33:18 -05:00
bug-mmap-fflush.c
bug-rewind.c Fix warnings in fwscanf / rewind tests. 2014-11-26 12:54:39 +00:00
bug-rewind2.c Fix warnings in fwscanf / rewind tests. 2014-11-26 12:54:39 +00:00
bug-ungetc.c
bug-ungetc2.c
bug-ungetc3.c
bug-ungetc4.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
bug-ungetwc1.c Fix libio/bug-ungetwc1.c warning. 2014-11-27 16:01:04 +00:00
bug-ungetwc2.c
bug-wfflush.c
bug-wmemstream1.c Add missing header files throughout the testsuite. 2017-02-16 17:33:18 -05:00
bug-wsetpos.c
clearerr.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
clearerr_u.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
Depend
fcloseall.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
feof.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
feof_u.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
ferror.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
ferror_u.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
filedoalloc.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
fileno.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
fileops.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
fmemopen.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
fputc.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
fputc_u.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
fputwc.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
fputwc_u.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
freopen.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
freopen64.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
fseek.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
fseeko.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
fseeko64.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
ftello.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
ftello64.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
fwide.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
fwprintf.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
fwscanf.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
genops.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
getc.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
getc_u.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
getchar.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
getchar_u.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
getwc.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
getwc_u.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
getwchar.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
getwchar_u.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
iofclose.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
iofdopen.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
iofflush.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
iofflush_u.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
iofgetpos.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
iofgetpos64.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
iofgets.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
iofgets_u.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
iofgetws.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
iofgetws_u.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
iofopen.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
iofopen64.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
iofopncook.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
iofputs.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
iofputs_u.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
iofputws.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
iofputws_u.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
iofread.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
iofread_u.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
iofsetpos.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
iofsetpos64.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
ioftell.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
iofwide.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
iofwrite.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
iofwrite_u.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
iogetdelim.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
iogetline.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
iogets.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
iogetwline.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
iolibio.h Add __v*printf_internal with flags arguments 2018-12-05 18:15:42 -02:00
iopadn.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
iopopen.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
ioputs.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
ioseekoff.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
ioseekpos.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
iosetbuffer.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
iosetvbuf.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
ioungetc.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
ioungetwc.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
iovdprintf.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
iovsprintf.c Set behavior of sprintf-like functions with overlapping source and destination 2019-01-02 13:53:52 -02:00
iovsscanf.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
iovswscanf.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
iowpadn.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
libc_fatal.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
libio.h Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
libioP.h Set behavior of sprintf-like functions with overlapping source and destination 2019-01-02 13:53:52 -02:00
Makefile Set behavior of sprintf-like functions with overlapping source and destination 2019-01-02 13:53:52 -02:00
memstream.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
obprintf.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
oldfileops.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
oldfmemopen.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
oldiofclose.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
oldiofdopen.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
oldiofgetpos.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
oldiofgetpos64.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
oldiofopen.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
oldiofsetpos.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
oldiofsetpos64.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
oldiopopen.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
oldpclose.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
oldstdfiles.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
oldtmpfile.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
pclose.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
peekc.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
putc.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
putc_u.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
putchar.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
putchar_u.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
putwc.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
putwc_u.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
putwchar.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
putwchar_u.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
readline.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
rewind.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
setbuf.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
setlinebuf.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
stdfiles.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
stdio.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
stdio.h Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
strfile.h Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
strops.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
swprintf.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
swscanf.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
test-fmemopen.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
test-freopen.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
test-freopen.sh Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-atime.c Don't reduce test timeout to less than default 2018-10-17 09:34:13 +02:00
tst-bz22415.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-eof.c
tst-ext.c
tst-ext2.c
tst-fgetc-after-eof.c [BZ 1190] Make EOF sticky in stdio. 2018-03-13 08:31:56 -04:00
tst-fgetwc.c
tst-fgetwc.input
tst-fgetws.c
tst-fopenloc.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-fopenloc2.c
tst-fputws.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-freopen.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-fseek.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-ftell-active-handler.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-ftell-append.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-ftell-partial-wide.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-fwrite-error.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-memstream.h Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-memstream1.c Add missing header files throughout the testsuite. 2017-02-16 17:33:18 -05:00
tst-memstream2.c Add missing header files throughout the testsuite. 2017-02-16 17:33:18 -05:00
tst-memstream3.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-memstream4.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-mmap-eofsync.c Remove miscellaneous debris from libio. 2018-02-21 14:39:54 -05:00
tst-mmap-fflushsync.c
tst-mmap-offend.c
tst-mmap-setvbuf.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-mmap2-eofsync.c 2016-06-11 Paul Pluzhnikov <ppluzhnikov@google.com> 2016-06-11 14:50:16 -07:00
tst-popen1.c
tst-readline.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-setvbuf1.c
tst-sprintf-chk-ub.c Set behavior of sprintf-like functions with overlapping source and destination 2019-01-02 13:53:52 -02:00
tst-sprintf-ub.c Set behavior of sprintf-like functions with overlapping source and destination 2019-01-02 13:53:52 -02:00
tst-sscanf.c Modify several tests to use test-skeleton.c 2014-11-05 15:24:08 +05:30
tst-swscanf.c
tst-ungetwc1.c Modify several tests to use test-skeleton.c 2014-11-05 15:24:08 +05:30
tst-ungetwc2.c Modify several tests to use test-skeleton.c 2014-11-05 15:24:08 +05:30
tst-vtables-common.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-vtables-interposed.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-vtables.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-widetext.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-widetext.input Finish change from “Bengali” to “Bangla” 2017-09-09 12:41:54 +02:00
tst-wmemstream1.c
tst-wmemstream2.c
tst-wmemstream3.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst-wmemstream4.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst_getwc.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst_getwc.input
tst_putwc.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
tst_swprintf.c
tst_swscanf.c
tst_wprintf.c
tst_wprintf2.c Add dependencies on needed locales in each subdir tests (bug 18969) 2015-10-12 15:18:08 +02:00
tst_wscanf.c
tst_wscanf.input
vasprintf.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
Versions libio: Implement internal function __libc_readline_unlocked 2018-07-06 17:52:54 +02:00
vscanf.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
vsnprintf.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
vswprintf.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
vtables.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
vwprintf.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
vwscanf.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
wfiledoalloc.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
wfileops.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
wgenops.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
wmemstream.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
wprintf.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
wscanf.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00
wstrops.c Update copyright dates with scripts/update-copyrights. 2019-01-01 00:11:28 +00:00