picnoir
/
glibc
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
glibc/soft-fp
History
Joseph Myers 049375e2b5 Do not use packed structures in soft-fp. 
Building for soft-float ColdFire produces an error in soft-fp:

In file included from ../sysdeps/ieee754/soft-fp/s_fmaf.c:42:
../soft-fp/single.h:85:3: error: 'packed' attribute ignored for field of type 'struct <anonymous>' [-Werror=attributes]
   } bits __attribute__ ((packed));
   ^

While this error only appears in that particular case, this attribute
is in fact never useful, on any architecture.  If you have

  struct __attribute__ ((packed)) { ... } bits;

or

  struct { ... } __attribute__ ((packed)) bits;

then the attribute affects the layout of the structure type.  But with
the form used in this code

  struct { ... } bits __attribute__ ((packed));

the field bits is being declared packed, but the layout of its type
has already been determined at that point.  If on any platform the
layout of the sequence of bit-fields were wrong without the use of a
packed attribute, the attribute would need to be used via a definition
of _FP_STRUCT_LAYOUT, not in its present position.

So this patch removes the useless attribute to fix the build for
ColdFire soft-float.  Tested with build-many-glibcs.py that installed
stripped shared libraries are unchanged by the patch.

	* soft-fp/double.h (union _FP_UNION_D): Do not use attribute
	packed on bits.
	* soft-fp/extended.h (union _FP_UNION_E): Likewise.
	* soft-fp/half.h (union _FP_UNION_H): Likewise.
	* soft-fp/quad.h (union _FP_UNION_Q): Likewise.
	* soft-fp/single.h (union _FP_UNION_S): Likewise.
 		2018-02-01 20:44:49 +00:00
..
Makefile Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
adddf3.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
addsf3.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
addtf3.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
divdf3.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
divsf3.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
divtf3.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
double.h Do not use packed structures in soft-fp. 2018-02-01 20:44:49 +00:00
eqdf2.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
eqsf2.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
eqtf2.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
extenddftf2.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
extended.h Do not use packed structures in soft-fp. 2018-02-01 20:44:49 +00:00
extendhftf2.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
extendsfdf2.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
extendsftf2.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
extendxftf2.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
fixdfdi.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
fixdfsi.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
fixdfti.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
fixhfti.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
fixsfdi.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
fixsfsi.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
fixsfti.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
fixtfdi.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
fixtfsi.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
fixtfti.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
fixunsdfdi.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
fixunsdfsi.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
fixunsdfti.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
fixunshfti.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
fixunssfdi.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
fixunssfsi.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
fixunssfti.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
fixunstfdi.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
fixunstfsi.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
fixunstfti.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
floatdidf.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
floatdisf.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
floatditf.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
floatsidf.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
floatsisf.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
floatsitf.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
floattidf.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
floattihf.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
floattisf.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
floattitf.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
floatundidf.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
floatundisf.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
floatunditf.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
floatunsidf.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
floatunsisf.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
floatunsitf.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
floatuntidf.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
floatuntihf.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
floatuntisf.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
floatuntitf.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
gedf2.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
gesf2.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
getf2.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
half.h Do not use packed structures in soft-fp. 2018-02-01 20:44:49 +00:00
ledf2.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
lesf2.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
letf2.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
muldf3.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
mulsf3.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
multf3.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
negdf2.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
negsf2.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
negtf2.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
op-1.h Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
op-2.h Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
op-4.h Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
op-8.h Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
op-common.h Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
quad.h Do not use packed structures in soft-fp. 2018-02-01 20:44:49 +00:00
single.h Do not use packed structures in soft-fp. 2018-02-01 20:44:49 +00:00
soft-fp.h Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
sqrtdf2.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
sqrtsf2.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
sqrttf2.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
subdf3.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
subsf3.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
subtf3.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
testit.c Remove trailing whitespace. 2013-06-05 20:44:03 +00:00
truncdfsf2.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
trunctfdf2.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
trunctfhf2.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
trunctfsf2.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
trunctfxf2.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
unorddf2.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
unordsf2.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
unordtf2.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00