picnoir
/
my-repo-pins
mirror of https://github.com/NinjaTrappeur/my-repo-pins.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

evil-mode bindings: remove eval-based dirty hack. 

We use the declare-function function to declare the evil-local-set-key
function to the bytecode compiler instead.

Massive kudos to riscy for this tip!

Related to the Melpa review comment
https://github.com/melpa/melpa/pull/8093#issuecomment-1173207615
This commit is contained in:
Félix Baylac-Jacqué 2022-07-05 10:08:27 +02:00
parent 9aee11bb38
commit 4f20fc55dc
No known key found for this signature in database
GPG Key ID: EFD315F31848DBA4
1 changed files with 4 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
my-repo-pins.el
View File

@ -506,20 +506,11 @@ is used, the key binding will be bound to the normal mode as well."
(if evil-mode-enabled
(progn
(local-set-key kbd action)
(when (require 'evil-core nil t)
;; Buckle up, dirty hack ahead:
;;
;; As I am writing this, there's no way to tell the emacs
;; byte compiler a particular dependency is optional.
;; Here, I want to use a evil-mode function *IFF*
;; evil-mode is already installed and used for the current
;; buffer.
;; The only way around I found is to prevent emacs to
;; bytecode-compile the evil function by deffering the
;; evaluation through a runtime eval. It's not a big deal
;; performance-wise: evil-local-set-key is pretty cheap
;; and not frequently used in our codebase.
(eval `(evil-local-set-key 'normal ,kbd ',action))))
(progn
(declare-function evil-local-set-key "ext:evil-core.el" "STATE" "KEY" "DEF" t)
(evil-local-set-key 'normal kbd action))))
(local-set-key kbd action))))
(defun my-repo-pins--draw-ui-buffer (forge-query-status user-query)