* Flag `--no-build-hook' to disable distributed builds.

* queryDeriver in daemon mode: don't barf if the other side returns an
  empty string (which means there is no deriver).
This commit is contained in:
Eelco Dolstra 2007-11-16 16:15:26 +00:00
parent c05783ad67
commit c370755583
9 changed files with 23 additions and 6 deletions

View file

@ -146,7 +146,7 @@ while (scalar @tmp > 0) {
# probably wouldn't make that much sense; pumping lots of data
# around just to compress them won't gain that much.
$ENV{"NIX_BUILD_HOOK"} = "";
my $pid = open(READ, "$binDir/nix-store --realise @tmp2|")
my $pid = open(READ, "$binDir/nix-store --no-build-hook --realise @tmp2|")
or die "cannot run nix-store";
while (<READ>) {
chomp;

View file

@ -212,6 +212,8 @@ static void initAndRun(int argc, char * * argv)
readOnlyMode = true;
else if (arg == "--max-silent-time")
maxSilentTime = getIntArg(arg, i, args.end());
else if (arg == "--no-build-hook")
useBuildHook = false;
else remaining.push_back(arg);
}

View file

@ -1247,6 +1247,7 @@ static string makeValidityRegistration(const PathSet & paths,
DerivationGoal::HookReply DerivationGoal::tryBuildHook()
{
if (!useBuildHook) return rpDecline;
Path buildHook = getEnv("NIX_BUILD_HOOK");
if (buildHook == "") return rpDecline;
buildHook = absPath(buildHook);

View file

@ -26,6 +26,7 @@ bool readOnlyMode = false;
string thisSystem = "unset";
unsigned int maxSilentTime = 0;
Paths substituters;
bool useBuildHook = true;
static bool settingsRead = false;

View file

@ -72,6 +72,10 @@ extern unsigned int maxSilentTime;
from a CD. */
extern Paths substituters;
/* Whether to use build hooks (for distributed builds). Sometimes
users want to disable this from the command-line. */
extern bool useBuildHook;
Strings querySetting(const string & name, const Strings & def);

View file

@ -59,7 +59,7 @@ RemoteStore::RemoteStore()
unsigned int magic = readInt(from);
if (magic != WORKER_MAGIC_2) throw Error("protocol mismatch");
unsigned int daemonVersion = readInt(from);
daemonVersion = readInt(from);
if (GET_PROTOCOL_MAJOR(daemonVersion) != GET_PROTOCOL_MAJOR(PROTOCOL_VERSION))
throw Error("Nix daemon protocol version not supported");
writeInt(PROTOCOL_VERSION, to);
@ -169,6 +169,8 @@ void RemoteStore::setOptions()
writeInt(verbosity, to);
writeInt(maxBuildJobs, to);
writeInt(maxSilentTime, to);
if (GET_PROTOCOL_MINOR(daemonVersion) >= 2)
writeInt(useBuildHook, to);
processStderr();
}
@ -230,7 +232,9 @@ Path RemoteStore::queryDeriver(const Path & path)
writeInt(wopQueryDeriver, to);
writeString(path, to);
processStderr();
return readStorePath(from);
Path drvPath = readString(from);
if (drvPath != "") assertStorePath(drvPath);
return drvPath;
}

View file

@ -71,6 +71,7 @@ private:
FdSink to;
FdSource from;
Pid child;
unsigned int daemonVersion;
void processStderr(Sink * sink = 0, Source * source = 0);

View file

@ -8,8 +8,9 @@ namespace nix {
#define WORKER_MAGIC_1 0x6e697863
#define WORKER_MAGIC_2 0x6478696f
#define PROTOCOL_VERSION 0x101
#define PROTOCOL_VERSION 0x102
#define GET_PROTOCOL_MAJOR(x) ((x) & 0xff00)
#define GET_PROTOCOL_MINOR(x) ((x) & 0x00ff)
typedef enum {

View file

@ -223,7 +223,8 @@ struct TunnelSource : Source
};
static void performOp(Source & from, Sink & to, unsigned int op)
static void performOp(unsigned int clientVersion,
Source & from, Sink & to, unsigned int op)
{
switch (op) {
@ -422,6 +423,8 @@ static void performOp(Source & from, Sink & to, unsigned int op)
verbosity = (Verbosity) readInt(from);
maxBuildJobs = readInt(from);
maxSilentTime = readInt(from);
if (GET_PROTOCOL_MINOR(clientVersion) >= 2)
useBuildHook = readInt(from) != 0;
startWork();
stopWork();
break;
@ -492,7 +495,7 @@ static void processConnection()
opCount++;
try {
performOp(from, to, op);
performOp(clientVersion, from, to, op);
} catch (Error & e) {
stopWork(false, e.msg());
}