picnoir
/
Nix
1
0
Fork 0
Code Issues Pull Requests 1 Releases Wiki Activity

Key repeated values on attribute binding pointers, not value pointers 

Closes #8672
This commit is contained in:
Rebecca Turner 2024-02-03 19:17:22 -08:00
parent 49cf090cb2
commit 770d2bc779
No known key found for this signature in database
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/libexpr/print.cc
View File

@ -152,7 +152,7 @@ struct ImportantFirstAttrNameCmp
} }
}; };
typedef std::set<Value *> ValuesSeen; typedef std::set<const void *> ValuesSeen;
class Printer class Printer
{ {
@ -262,7 +262,7 @@ private:
void printAttrs(Value & v, size_t depth) void printAttrs(Value & v, size_t depth)
{ {
if (seen && !seen->insert(&v).second) { if (seen && !seen->insert(v.attrs).second) {
printRepeated(); printRepeated();
return; return;
} }

4
tests/functional/repl.sh
View File

@ -156,7 +156,7 @@ testReplResponseNoRegex '
# Same for let expressions # Same for let expressions
testReplResponseNoRegex ' testReplResponseNoRegex '
let x = { y = { a = 1; }; inherit x; }; in x let x = { y = { a = 1; }; inherit x; }; in x
' '{ x = { ... }; y = { ... }; }' ' '{ x = «repeated»; y = { ... }; }'
# The :p command should recursively print sets, but prevent infinite recursion # The :p command should recursively print sets, but prevent infinite recursion
testReplResponseNoRegex ' testReplResponseNoRegex '
@ -171,4 +171,4 @@ testReplResponseNoRegex '
# Same for let expressions # Same for let expressions
testReplResponseNoRegex ' testReplResponseNoRegex '
:p let x = { y = { a = 1; }; inherit x; }; in x :p let x = { y = { a = 1; }; inherit x; }; in x
' '{ x = { x = «repeated»; y = { a = 1; }; }; y = «repeated»; }' ' '{ x = «repeated»; y = { a = 1; }; }'