2017-11-18 17:09:20 +01:00
|
|
|
/* SPDX-License-Identifier: LGPL-2.1+ */
|
2012-04-10 21:54:31 +02:00
|
|
|
|
|
|
|
#include <errno.h>
|
2015-11-30 21:43:37 +01:00
|
|
|
#include <stdbool.h>
|
2015-11-16 22:09:36 +01:00
|
|
|
#include <string.h>
|
2015-11-30 21:43:37 +01:00
|
|
|
#include <sys/stat.h>
|
2012-04-10 21:54:31 +02:00
|
|
|
|
2017-10-06 09:03:33 +02:00
|
|
|
#include "alloc-util.h"
|
2015-10-26 21:16:26 +01:00
|
|
|
#include "fs-util.h"
|
2015-12-01 23:22:03 +01:00
|
|
|
#include "macro.h"
|
2013-06-27 04:14:27 +02:00
|
|
|
#include "mkdir.h"
|
2015-10-26 21:16:26 +01:00
|
|
|
#include "path-util.h"
|
2015-10-26 22:01:44 +01:00
|
|
|
#include "stat-util.h"
|
tree-wide: warn when a directory path already exists but has bad mode/owner/type
When we are attempting to create directory somewhere in the bowels of /var/lib
and get an error that it already exists, it can be quite hard to diagnose what
is wrong (especially for a user who is not aware that the directory must have
the specified owner, and permissions not looser than what was requested). Let's
print a warning in most cases. A warning is appropriate, because such state is
usually a sign of borked installation and needs to be resolved by the adminstrator.
$ build/test-fs-util
Path "/tmp/test-readlink_and_make_absolute" already exists and is not a directory, refusing.
(or)
Directory "/tmp/test-readlink_and_make_absolute" already exists, but has mode 0775 that is too permissive (0755 was requested), refusing.
(or)
Directory "/tmp/test-readlink_and_make_absolute" already exists, but is owned by 1001:1000 (1000:1000 was requested), refusing.
Assertion 'mkdir_safe(tempdir, 0755, getuid(), getgid(), MKDIR_WARN_MODE) >= 0' failed at ../src/test/test-fs-util.c:320, function test_readlink_and_make_absolute(). Aborting.
No functional change except for the new log lines.
2018-03-22 13:03:41 +01:00
|
|
|
#include "stdio-util.h"
|
2015-10-27 00:42:07 +01:00
|
|
|
#include "user-util.h"
|
2012-04-10 21:54:31 +02:00
|
|
|
|
2018-03-22 12:38:01 +01:00
|
|
|
int mkdir_safe_internal(const char *path, mode_t mode, uid_t uid, gid_t gid, MkdirFlags flags, mkdir_func_t _mkdir) {
|
2012-04-10 21:54:31 +02:00
|
|
|
struct stat st;
|
2017-08-09 12:46:09 +02:00
|
|
|
int r;
|
2012-04-10 21:54:31 +02:00
|
|
|
|
2017-12-15 17:08:13 +01:00
|
|
|
assert(_mkdir != mkdir);
|
|
|
|
|
2017-08-09 12:46:09 +02:00
|
|
|
if (_mkdir(path, mode) >= 0) {
|
|
|
|
r = chmod_and_chown(path, mode, uid, gid);
|
|
|
|
if (r < 0)
|
|
|
|
return r;
|
|
|
|
}
|
2012-04-10 21:54:31 +02:00
|
|
|
|
|
|
|
if (lstat(path, &st) < 0)
|
|
|
|
return -errno;
|
|
|
|
|
2018-03-22 12:38:01 +01:00
|
|
|
if ((flags & MKDIR_FOLLOW_SYMLINK) && S_ISLNK(st.st_mode)) {
|
2017-10-06 09:03:33 +02:00
|
|
|
_cleanup_free_ char *p = NULL;
|
|
|
|
|
|
|
|
r = chase_symlinks(path, NULL, CHASE_NONEXISTENT, &p);
|
|
|
|
if (r < 0)
|
|
|
|
return r;
|
|
|
|
if (r == 0)
|
2018-03-22 12:38:01 +01:00
|
|
|
return mkdir_safe_internal(p, mode, uid, gid,
|
|
|
|
flags & ~MKDIR_FOLLOW_SYMLINK,
|
|
|
|
_mkdir);
|
2017-10-06 09:03:33 +02:00
|
|
|
|
|
|
|
if (lstat(p, &st) < 0)
|
|
|
|
return -errno;
|
|
|
|
}
|
|
|
|
|
tree-wide: warn when a directory path already exists but has bad mode/owner/type
When we are attempting to create directory somewhere in the bowels of /var/lib
and get an error that it already exists, it can be quite hard to diagnose what
is wrong (especially for a user who is not aware that the directory must have
the specified owner, and permissions not looser than what was requested). Let's
print a warning in most cases. A warning is appropriate, because such state is
usually a sign of borked installation and needs to be resolved by the adminstrator.
$ build/test-fs-util
Path "/tmp/test-readlink_and_make_absolute" already exists and is not a directory, refusing.
(or)
Directory "/tmp/test-readlink_and_make_absolute" already exists, but has mode 0775 that is too permissive (0755 was requested), refusing.
(or)
Directory "/tmp/test-readlink_and_make_absolute" already exists, but is owned by 1001:1000 (1000:1000 was requested), refusing.
Assertion 'mkdir_safe(tempdir, 0755, getuid(), getgid(), MKDIR_WARN_MODE) >= 0' failed at ../src/test/test-fs-util.c:320, function test_readlink_and_make_absolute(). Aborting.
No functional change except for the new log lines.
2018-03-22 13:03:41 +01:00
|
|
|
if (!S_ISDIR(st.st_mode)) {
|
|
|
|
log_full(flags & MKDIR_WARN_MODE ? LOG_WARNING : LOG_DEBUG,
|
|
|
|
"Path \"%s\" already exists and is not a directory, refusing.", path);
|
|
|
|
return -ENOTDIR;
|
|
|
|
}
|
2014-03-11 02:41:13 +01:00
|
|
|
if ((st.st_mode & 0007) > (mode & 0007) ||
|
|
|
|
(st.st_mode & 0070) > (mode & 0070) ||
|
tree-wide: warn when a directory path already exists but has bad mode/owner/type
When we are attempting to create directory somewhere in the bowels of /var/lib
and get an error that it already exists, it can be quite hard to diagnose what
is wrong (especially for a user who is not aware that the directory must have
the specified owner, and permissions not looser than what was requested). Let's
print a warning in most cases. A warning is appropriate, because such state is
usually a sign of borked installation and needs to be resolved by the adminstrator.
$ build/test-fs-util
Path "/tmp/test-readlink_and_make_absolute" already exists and is not a directory, refusing.
(or)
Directory "/tmp/test-readlink_and_make_absolute" already exists, but has mode 0775 that is too permissive (0755 was requested), refusing.
(or)
Directory "/tmp/test-readlink_and_make_absolute" already exists, but is owned by 1001:1000 (1000:1000 was requested), refusing.
Assertion 'mkdir_safe(tempdir, 0755, getuid(), getgid(), MKDIR_WARN_MODE) >= 0' failed at ../src/test/test-fs-util.c:320, function test_readlink_and_make_absolute(). Aborting.
No functional change except for the new log lines.
2018-03-22 13:03:41 +01:00
|
|
|
(st.st_mode & 0700) > (mode & 0700)) {
|
|
|
|
log_full(flags & MKDIR_WARN_MODE ? LOG_WARNING : LOG_DEBUG,
|
|
|
|
"Directory \"%s\" already exists, but has mode %04o that is too permissive (%04o was requested), refusing.",
|
|
|
|
path, st.st_mode & 0777, mode);
|
|
|
|
return -EEXIST;
|
|
|
|
}
|
|
|
|
if ((uid != UID_INVALID && st.st_uid != uid) ||
|
|
|
|
(gid != GID_INVALID && st.st_gid != gid)) {
|
|
|
|
char u[DECIMAL_STR_MAX(uid_t)] = "-", g[DECIMAL_STR_MAX(gid_t)] = "-";
|
|
|
|
|
|
|
|
if (uid != UID_INVALID)
|
|
|
|
xsprintf(u, UID_FMT, uid);
|
|
|
|
if (gid != UID_INVALID)
|
|
|
|
xsprintf(g, GID_FMT, gid);
|
|
|
|
log_full(flags & MKDIR_WARN_MODE ? LOG_WARNING : LOG_DEBUG,
|
|
|
|
"Directory \"%s\" already exists, but is owned by "UID_FMT":"GID_FMT" (%s:%s was requested), refusing.",
|
|
|
|
path, st.st_uid, st.st_gid, u, g);
|
2015-03-16 16:34:39 +01:00
|
|
|
return -EEXIST;
|
tree-wide: warn when a directory path already exists but has bad mode/owner/type
When we are attempting to create directory somewhere in the bowels of /var/lib
and get an error that it already exists, it can be quite hard to diagnose what
is wrong (especially for a user who is not aware that the directory must have
the specified owner, and permissions not looser than what was requested). Let's
print a warning in most cases. A warning is appropriate, because such state is
usually a sign of borked installation and needs to be resolved by the adminstrator.
$ build/test-fs-util
Path "/tmp/test-readlink_and_make_absolute" already exists and is not a directory, refusing.
(or)
Directory "/tmp/test-readlink_and_make_absolute" already exists, but has mode 0775 that is too permissive (0755 was requested), refusing.
(or)
Directory "/tmp/test-readlink_and_make_absolute" already exists, but is owned by 1001:1000 (1000:1000 was requested), refusing.
Assertion 'mkdir_safe(tempdir, 0755, getuid(), getgid(), MKDIR_WARN_MODE) >= 0' failed at ../src/test/test-fs-util.c:320, function test_readlink_and_make_absolute(). Aborting.
No functional change except for the new log lines.
2018-03-22 13:03:41 +01:00
|
|
|
}
|
2012-04-10 21:54:31 +02:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2017-12-15 17:08:13 +01:00
|
|
|
int mkdir_errno_wrapper(const char *pathname, mode_t mode) {
|
|
|
|
if (mkdir(pathname, mode) < 0)
|
|
|
|
return -errno;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2018-04-27 12:55:56 +02:00
|
|
|
int mkdirat_errno_wrapper(int dirfd, const char *pathname, mode_t mode) {
|
|
|
|
if (mkdirat(dirfd, pathname, mode) < 0)
|
|
|
|
return -errno;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2018-03-22 12:38:01 +01:00
|
|
|
int mkdir_safe(const char *path, mode_t mode, uid_t uid, gid_t gid, MkdirFlags flags) {
|
|
|
|
return mkdir_safe_internal(path, mode, uid, gid, flags, mkdir_errno_wrapper);
|
2012-05-31 13:17:26 +02:00
|
|
|
}
|
|
|
|
|
2013-07-26 03:34:18 +02:00
|
|
|
int mkdir_parents_internal(const char *prefix, const char *path, mode_t mode, mkdir_func_t _mkdir) {
|
2012-04-10 21:54:31 +02:00
|
|
|
const char *p, *e;
|
2013-06-27 04:14:27 +02:00
|
|
|
int r;
|
2012-04-10 21:54:31 +02:00
|
|
|
|
|
|
|
assert(path);
|
2017-12-15 17:08:13 +01:00
|
|
|
assert(_mkdir != mkdir);
|
2012-04-10 21:54:31 +02:00
|
|
|
|
2013-06-27 04:14:27 +02:00
|
|
|
if (prefix && !path_startswith(path, prefix))
|
|
|
|
return -ENOTDIR;
|
|
|
|
|
2012-04-17 00:26:02 +02:00
|
|
|
/* return immediately if directory exists */
|
|
|
|
e = strrchr(path, '/');
|
|
|
|
if (!e)
|
|
|
|
return -EINVAL;
|
2013-06-27 04:14:27 +02:00
|
|
|
|
|
|
|
if (e == path)
|
|
|
|
return 0;
|
|
|
|
|
2012-04-17 00:26:02 +02:00
|
|
|
p = strndupa(path, e - path);
|
2014-06-10 23:42:16 +02:00
|
|
|
r = is_dir(p, true);
|
2013-06-27 04:14:27 +02:00
|
|
|
if (r > 0)
|
|
|
|
return 0;
|
|
|
|
if (r == 0)
|
|
|
|
return -ENOTDIR;
|
2012-04-10 21:54:31 +02:00
|
|
|
|
2012-04-17 00:26:02 +02:00
|
|
|
/* create every parent directory in the path, except the last component */
|
2012-04-10 21:54:31 +02:00
|
|
|
p = path + strspn(path, "/");
|
|
|
|
for (;;) {
|
2013-06-27 04:14:27 +02:00
|
|
|
char t[strlen(path) + 1];
|
2012-04-10 21:54:31 +02:00
|
|
|
|
|
|
|
e = p + strcspn(p, "/");
|
|
|
|
p = e + strspn(e, "/");
|
|
|
|
|
2017-12-15 17:08:13 +01:00
|
|
|
/* Is this the last component? If so, then we're done */
|
2012-04-10 21:54:31 +02:00
|
|
|
if (*p == 0)
|
|
|
|
return 0;
|
|
|
|
|
2013-06-27 04:14:27 +02:00
|
|
|
memcpy(t, path, e - path);
|
|
|
|
t[e-path] = 0;
|
2012-04-10 21:54:31 +02:00
|
|
|
|
2013-06-27 04:14:27 +02:00
|
|
|
if (prefix && path_startswith(prefix, t))
|
|
|
|
continue;
|
2012-04-10 21:54:31 +02:00
|
|
|
|
2013-07-26 03:34:18 +02:00
|
|
|
r = _mkdir(t, mode);
|
2017-12-15 17:08:13 +01:00
|
|
|
if (r < 0 && r != -EEXIST)
|
|
|
|
return r;
|
2012-04-10 21:54:31 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2012-05-31 13:17:26 +02:00
|
|
|
int mkdir_parents(const char *path, mode_t mode) {
|
2017-12-15 17:08:13 +01:00
|
|
|
return mkdir_parents_internal(NULL, path, mode, mkdir_errno_wrapper);
|
2012-10-02 14:42:10 +02:00
|
|
|
}
|
|
|
|
|
2013-07-26 03:34:18 +02:00
|
|
|
int mkdir_p_internal(const char *prefix, const char *path, mode_t mode, mkdir_func_t _mkdir) {
|
2012-04-10 21:54:31 +02:00
|
|
|
int r;
|
|
|
|
|
|
|
|
/* Like mkdir -p */
|
|
|
|
|
2017-12-15 17:08:13 +01:00
|
|
|
assert(_mkdir != mkdir);
|
|
|
|
|
2013-07-26 03:34:18 +02:00
|
|
|
r = mkdir_parents_internal(prefix, path, mode, _mkdir);
|
2012-05-31 13:17:26 +02:00
|
|
|
if (r < 0)
|
2012-04-10 21:54:31 +02:00
|
|
|
return r;
|
|
|
|
|
2013-07-26 03:34:18 +02:00
|
|
|
r = _mkdir(path, mode);
|
2017-12-15 17:08:13 +01:00
|
|
|
if (r < 0 && (r != -EEXIST || is_dir(path, true) <= 0))
|
|
|
|
return r;
|
2012-04-10 21:54:31 +02:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
2012-05-31 13:17:26 +02:00
|
|
|
|
|
|
|
int mkdir_p(const char *path, mode_t mode) {
|
2017-12-15 17:08:13 +01:00
|
|
|
return mkdir_p_internal(NULL, path, mode, mkdir_errno_wrapper);
|
2013-06-27 04:14:27 +02:00
|
|
|
}
|