[PATCH] clean up the logging patch a bit to make the option more like the other options.

Also documented it and added it to the .spec file.
This commit is contained in:
greg@kroah.com 2004-01-15 22:00:58 -08:00 committed by Greg KH
parent 54988802b7
commit 0523018487
4 changed files with 28 additions and 9 deletions

View File

@ -18,7 +18,7 @@
# Set the following to control the use of syslog # Set the following to control the use of syslog
# Set it to `false' to remove all logging # Set it to `false' to remove all logging
LOG = true USE_LOG = true
# Set the following to `true' to log the debug # Set the following to `true' to log the debug
# and make a unstripped, unoptimized binary. # and make a unstripped, unoptimized binary.
@ -109,7 +109,7 @@ else
CFLAGS+=-pipe CFLAGS+=-pipe
endif endif
ifeq ($(strip $(LOG)),true) ifeq ($(strip $(USE_LOG)),true)
CFLAGS += -DLOG CFLAGS += -DLOG
endif endif

22
README
View File

@ -30,18 +30,28 @@ To use:
Note: Note:
There are a number of different flags that you can use when building There are a number of different flags that you can use when building
udev. They are as follows: udev. They are as follows:
prefix - set this to the default root that you want udev to be prefix
set this to the default root that you want udev to be
installed into. This works just like the 'configure --prefix' installed into. This works just like the 'configure --prefix'
script does. Default value is ''. Only override this if you script does. Default value is ''. Only override this if you
really know what you are doing. really know what you are doing.
USE_KLIBC - if set to 'true', udev is built and linked against the included USE_KLIBC
version of klibc. Default value is 'false'. if set to 'true', udev is built and linked against the
DEBUG - if set to 'true', debugging messages will be sent to the syslog included version of klibc. Default value is 'false'.
as udev is run. Default value is 'false'. USE_LOG
USE_DBUS - if set to 'true', DBUS messages will be sent everytime udev if set to 'true', udev will emit messages to the syslog when
it creates or removes device nodes. This is helpful to see
what udev is doing. This is enabled by default. Note, if you
are building udev against klibc it is recommended that you
disable this option (due to klibc's syslog implementation.)
USE_DBUS
if set to 'true', DBUS messages will be sent everytime udev
creates or removes a device node. This requires that DBUS creates or removes a device node. This requires that DBUS
development headers and libraries be present on your system to development headers and libraries be present on your system to
build properly. Default value is 'false'. build properly. Default value is 'false'.
DEBUG
if set to 'true', debugging messages will be sent to the syslog
as udev is run. Default value is 'false'.
So, if you want to build udev using klibc with debugging messages, you So, if you want to build udev using klibc with debugging messages, you
would do: would do:

View File

@ -1,5 +1,5 @@
/* /*
* udev.h * logging.h
* *
* Userspace devfs * Userspace devfs
* *

View File

@ -5,6 +5,12 @@
# it probably is not where you want it to be. # it probably is not where you want it to be.
%define klibc 1 %define klibc 1
# if we want to have logging support in or not.
# 0 - no logging support
# 1 - logging support
# Note, it is not recommend if you use klibc to enable logging.
%define log 0
# if we want to build DBUS support in or not. # if we want to build DBUS support in or not.
# 0 - no DBUS support # 0 - no DBUS support
# 1 - DBUS support # 1 - DBUS support
@ -45,6 +51,9 @@ make CC="gcc $RPM_OPT_FLAGS" \
%if %{klibc} %if %{klibc}
USE_KLIBC=true \ USE_KLIBC=true \
%endif %endif
%if %{log}
USE_LOG=true \
%endif
%if %{dbus} %if %{dbus}
USE_DBUS=true \ USE_DBUS=true \
%endif %endif