picnoir
/
Systemd
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

CONTRIBUTING: recommend force-push (#3273)

This commit is contained in:
Zbigniew Jędrzejewski-Szmek 2016-05-16 15:44:35 -04:00 committed by Lennart Poettering
parent cd042078df
commit a87c45a84b
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
.github/CONTRIBUTING.md vendored
View File

@ -24,10 +24,7 @@ right-away for being misfiled.
code. This is a requirement for all code we merge.
* Make sure to run "make check" locally, before posting your PR. We use a CI system, meaning we don't even look at your
PR, if the build and tests don't pass.
* If you need to update the code in an existing PR, please consider opening a new PR (mentioning in it which old PR it
replaces) and closing the old PR. This is much preferable over force-pushing a new patch set into the PR's branch, as
commit comments aren't lost that way. That said, we don't follow this rule ourselves quite often, hence this is
really just a say as we say, not say as we do...
* If you need to update the code in an existing PR, force-push into the same branch, overriding old commits with new versions.
## Final Words