CONTRIBUTING: recommend force-push (#3273)
This commit is contained in:
parent
cd042078df
commit
a87c45a84b
5
.github/CONTRIBUTING.md
vendored
5
.github/CONTRIBUTING.md
vendored
|
@ -24,10 +24,7 @@ right-away for being misfiled.
|
||||||
code. This is a requirement for all code we merge.
|
code. This is a requirement for all code we merge.
|
||||||
* Make sure to run "make check" locally, before posting your PR. We use a CI system, meaning we don't even look at your
|
* Make sure to run "make check" locally, before posting your PR. We use a CI system, meaning we don't even look at your
|
||||||
PR, if the build and tests don't pass.
|
PR, if the build and tests don't pass.
|
||||||
* If you need to update the code in an existing PR, please consider opening a new PR (mentioning in it which old PR it
|
* If you need to update the code in an existing PR, force-push into the same branch, overriding old commits with new versions.
|
||||||
replaces) and closing the old PR. This is much preferable over force-pushing a new patch set into the PR's branch, as
|
|
||||||
commit comments aren't lost that way. That said, we don't follow this rule ourselves quite often, hence this is
|
|
||||||
really just a say as we say, not say as we do...
|
|
||||||
|
|
||||||
## Final Words
|
## Final Words
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue