picnoir
/
Systemd
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

test: use KILL instead of SIGKILL in TEST-52-HONORFIRSTSHUTDOWN 

SIG-prefixed signals for `kill` are not POSIX compliant, so on Ubuntu CI
(which defaults to dash instead of bash) the TEST-52 contains following
error:

[ 9693.549638] sh[51]: + systemctl poweroff --no-block
[ 9693.553130] systemd-logind[26]: System is powering down.
[ 9693.608911] sh[54]: /bin/sh: 1: kill: Illegal option -S

This can be reproduced manually as well, either by running dash, or bash
in POSIX mode:

$ dash -c 'kill -SIGKILL 123'
dash: 1: kill: Illegal option -S

$ bash --posix -c 'kill -SIGKILL 123'
bash: line 0: kill: SIGKILL: invalid signal specification
This commit is contained in:
Frantisek Sumsal 2020-07-04 20:18:02 +02:00 committed by Daan De Meyer
parent 2fadbb4535
commit bf795c47bc
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/units/test-honor-first-shutdown.service
View File

@ -4,8 +4,8 @@ After=multi-user.target
[Service]
ExecStart=/usr/lib/systemd/tests/testdata/units/%N.sh
ExecStop=sh -c 'kill -SIGKILL $MAINPID'
ExecStop=sh -c 'kill -KILL $MAINPID'
FailureAction=reboot
[Install]
WantedBy=multi-user.target
WantedBy=multi-user.target