Lennart Poettering
3cc2aff1ab
tree-wide: don't do assignments within if checks
...
Turn this:
if ((r = foo()) < 0) { ...
into this:
r = foo();
if (r < 0) { ...
2015-09-09 08:20:20 +02:00
Lennart Poettering
7f6e12b033
tree-wide: drop redundant if checks before safe_close()
...
Replace this:
if (fd >= 0)
safe_close(fd);
by this:
safe_close(fd);
2015-09-09 08:20:19 +02:00
Lennart Poettering
66e405837b
tree-wide: make more code use safe_close()
...
Replace this:
close(fd);
fd = -1;
write this:
fd = safe_close(fd);
2015-09-09 08:20:19 +02:00
Lennart Poettering
a1e58e8ee1
tree-wide: use coccinelle to patch a lot of code to use mfree()
...
This replaces this:
free(p);
p = NULL;
by this:
p = mfree(p);
Change generated using coccinelle. Semantic patch is added to the
sources.
2015-09-09 08:19:27 +02:00
Daniel Mack
da323858ef
Merge pull request #1190 from poettering/rework-virt
...
basic: rework virtualization detection API
2015-09-08 15:53:56 +02:00
David Herrmann
4211d5bd13
sd-login: fix sd_seat_get_active() to return ENODATA
...
This seems to be an oversight from:
707b66c663
We have to return ENODATA instead of ENOENT if a requested entry is
non-present. Also fix the call-site in udev to check for these errors.
2015-09-08 14:03:22 +02:00
David Herrmann
23d08d1b2b
build: prepare for v226
...
Bump version info and update NEWS for the upcoming release.
2015-09-08 13:31:57 +02:00
David Herrmann
2b3b433dbb
Merge pull request #1201 from torstehu/fix-typo
...
treewide: fix typos
2015-09-08 13:23:24 +02:00
Daniel Mack
a7adabc96e
Merge pull request #1192 from poettering/sd-bus-container
...
sd-bus: pass container bus errors up to calling process
2015-09-08 12:59:03 +02:00
Torstein Husebø
dc61b7e45d
treewide: fix typos
2015-09-08 12:55:50 +02:00
Lennart Poettering
d60f96798d
Merge pull request #1196 from evverx/systemctl-add-consists-of
...
systemctl: add ConsistsOf as the inverse of PartOf
2015-09-08 11:16:53 +02:00
Lennart Poettering
98d51e6a55
Merge pull request #1198 from martinpitt/master
...
cgroup-util: fix devices controller
2015-09-08 11:09:37 +02:00
Martin Pitt
5bf8002a3a
cgroup-util: fix devices controller
...
Commit efdb0237
accidentally changed the name of the "devices" cgroup
controller to "device".
2015-09-08 10:42:22 +02:00
Daniel Mack
62043f3c18
Merge pull request #1195 from poettering/nspawn-fixes
...
Various nspawn fixes
2015-09-08 10:40:39 +02:00
Evgeny Vereshchagin
fb30c438f3
systemctl: add ConsistsOf as the inverse of PartOf
2015-09-08 03:02:49 +03:00
Lennart Poettering
e2bf1764fd
update TODO
2015-09-08 01:37:04 +02:00
Lennart Poettering
2f77decc5b
NEWS: update contributors list
2015-09-08 01:36:59 +02:00
Lennart Poettering
82116c4329
nspawn: also close uid shift socket in the parent
...
We should really close all parent sides of our child/parent socket
pairs.
2015-09-08 01:22:46 +02:00
Lennart Poettering
76d448820e
nspawn: short reads do not set errno, hence don't try to print it
2015-09-08 01:22:26 +02:00
Lennart Poettering
4610de5022
inspawn: switch from SOCK_DGRAM to SOCK_SEQPACKET for internal socketpairs
...
SOCK_DGRAM and SOCK_SEQPACKET have very similar semantics when used with
socketpair(). However, SOCK_SEQPACKET has the advantage of knowing a
hangup concept, since it is inherently connection-oriented.
Since we use socket pairs to communicate between the nspawn main process
and the nspawn child process, where the child might die abnormally it's
interesting to us to learn about this via hangups if the child side of
the pair is closed. Hence, let's switch to SOCK_SEQPACKET for these
internal communication sockets.
Fixes #956 .
2015-09-08 01:17:47 +02:00
Lennart Poettering
07fa00f9d9
nspawn: properly propagate errors when we fail to set soemthing up
2015-09-08 01:17:15 +02:00
Daniel Mack
4df0514d29
Merge pull request #1193 from phomes/typos
...
man: typo fixes
2015-09-07 23:16:14 +02:00
Thomas Hindoe Paaboel Andersen
4f76ef0423
man: typo fixes
2015-09-07 20:06:58 +02:00
Lennart Poettering
385080c09e
machined: improve error message when trying to get a bus in bus-less containers
...
Now that we get useful error messages from sd-bus for container
connections, let's make use of this and report better errors back to
machined clients.
Fixes #685 .
2015-09-07 19:53:34 +02:00
Lennart Poettering
2b7d6d33dc
sd-bus: when connecting to a container AF_UNIX bus, return error
...
When forking of a child process for connecting to a container, pass
the preicse connection error to the calling process.
We already did this correctly for kdbus busses, let's do so for dbus1
busses, too.
2015-09-07 19:52:11 +02:00
Daniel Mack
d6d056a19f
Merge pull request #1191 from poettering/nspawn-split
...
nspawn: split up nspawn.c into multiple smaller .c files
2015-09-07 19:08:39 +02:00
Lennart Poettering
8fe0087ede
nspawn: sort and clean up included header list
...
Let's remove unnecessary inclusions, and order the list alphabetically
as suggested in CODING_STYLE now.
2015-09-07 18:56:54 +02:00
Lennart Poettering
2b5c04d59c
nspawn: remove nspawn.h, it's empty now
2015-09-07 18:47:34 +02:00
Lennart Poettering
ee64508006
nspawn: split out --uid= logic into nspawn-setuid.[ch]
2015-09-07 18:44:31 +02:00
Lennart Poettering
b7103bc5f4
nspawn: split out machined registration code to nspawn-register.[ch]
2015-09-07 18:44:31 +02:00
Lennart Poettering
34829a324b
nspawn: split out cgroup related calls into nspawn-cgroup.[ch]
2015-09-07 18:44:30 +02:00
Lennart Poettering
9a2a5625bf
nspawn: split out network related code to nspawn-network.[ch]
2015-09-07 18:44:30 +02:00
Lennart Poettering
7a8f63251d
nspawn: split all port exposure code into nspawn-expose-port.[ch]
2015-09-07 18:44:30 +02:00
Lennart Poettering
e83bebeff7
nspawn: split out mount related functions into a new nspawn-mount.c file
2015-09-07 18:44:30 +02:00
Daniel Mack
1dc0b4e4b0
Merge pull request #1189 from poettering/unit-start
...
unit: move "not supported" check after condition check in unit_start()
2015-09-07 14:27:13 +02:00
Lennart Poettering
d11a76451f
unit: move "not supported" check after condition check in unit_start()
...
Make sure we always check conditions before checking whether the unit
type is supported in unit_start(), since condition checks are "clean
errors", while "not supported" errors are fatal.
This cleans up the boot output of systemd in containers, where a lot of
NOTSUPP lines were shown befor this fix.
This partially reverts 8ff4d2ab0d
which
reorder the checks.
2015-09-07 14:10:53 +02:00
Lennart Poettering
75f86906c5
basic: rework virtualization detection API
...
Introduce a proper enum, and don't pass around string ids anymore. This
simplifies things quite a bit, and makes virtualization detection more
similar to architecture detection.
2015-09-07 13:42:47 +02:00
Daniel Mack
c626bf1d30
NEWS: fix typos
2015-09-07 13:06:53 +02:00
Lennart Poettering
47f5a38cdf
update NEWS
2015-09-07 12:43:25 +02:00
Daniel Mack
fcf554fd7a
Merge pull request #1178 from poettering/gpt-auto-fixes
...
handle LUKS root partitions better in gpt-auto, plus other fixes
2015-09-07 12:28:34 +02:00
Lennart Poettering
f9a25b6ad5
Merge pull request #1183 from dvdhrm/cpename
...
man: clarify wording of os-release.CPE_NAME
2015-09-07 11:12:27 +02:00
David Herrmann
06fc9df273
Merge pull request #1182 from martinpitt/master
...
tests: Skip test-cgroup-util test_mask_supported() when not running under systemd
2015-09-07 11:02:40 +02:00
David Herrmann
74c1d3e74e
man: clarify wording of os-release.CPE_NAME
...
We expect the CPE_NAME to be formatted in URI binding syntax. Make that
clear in the documentation. Furthermore, the CPE-spec has been taken over
by NIST, so adjust the links as well.
Reported by: Ben Harris <bjh21@cam.ac.uk>
2015-09-07 10:57:50 +02:00
Martin Pitt
b3a7ba8968
tests: Skip test-cgroup-util test_mask_supported() when not running under systemd
...
Commit 5f4c5fef6
introduced this new test case, but this does not work in
build chroots where cgroupfs is not mounted. So skip the test if systemd is not
running.
2015-09-07 08:09:13 +02:00
Daniel Mack
9ec0fc9a39
Merge pull request #1181 from evverx/update-systemd-analyze-completion
...
shell-completion: update systemd-analyze bash-completion
2015-09-07 05:53:19 +02:00
Evgeny Vereshchagin
20ba8107a5
shell-completion: update systemd-analyze bash-completion
...
* Change --no-man to --man (see dad29df
)
* --{from,to}-pattern require arg
2015-09-07 04:51:21 +03:00
Tom Gundersen
5bac59d920
Merge pull request #1179 from poettering/sd-event-sigchld-fix
...
sd-event: make sure to create a signal queue for the right signal
2015-09-07 03:02:08 +02:00
Tom Gundersen
6167a91c74
Merge pull request #1165 from poettering/nspawn-files
...
various fixes to the core, logind, machined, nspawn
2015-09-07 02:59:08 +02:00
Lennart Poettering
10edebf6cd
sd-event: make sure to create a signal queue for the right signal
...
We should never access the "signal" part of the event source unless the
event source is actually for a signal. In this case it's a child pid
handler however, hence make sure to use the right signal.
This is a fix for PR #1177 , which in turn was a fix for
9da4cb2be2
.
2015-09-07 00:31:24 +02:00
Lennart Poettering
4c3e8e39ea
systemctl: a number of cleanups regarding error handling in systemctl
2015-09-07 00:12:05 +02:00