6c8a51ed78
travis: run ASan job in parallel with the standard one
2018-11-08 13:49:46 +01:00
6dfe7f43d0
travis: UBSan should be every C programmer's friend so let's build systemd with it too
2018-11-08 13:49:45 +01:00
86f4edef54
test: initialize hwdb so that the test won't try to free memory it has never allocated
...
See https://github.com/systemd/systemd/pull/10678#issuecomment-436790906 .
2018-11-08 13:49:45 +01:00
79f6178ee1
travis: move the ASan part into a separate stage
2018-11-08 13:49:45 +01:00
1667d63acc
travis: also rebuild everything with ASan
...
It should help to catch issues like https://github.com/systemd/systemd/issues/10677 .
2018-11-08 13:49:45 +01:00
e4f8f99c6f
travis: install dependencies necessary for running parse-hwdb.py
2018-11-08 13:49:45 +01:00
abdcb688a8
Merge pull request #10676 from poettering/rdrand-everywhere
...
prefer RDRAND over getrandom() and /dev/urandom when we don't need the very best randomness
2018-11-08 13:33:02 +01:00
010c9a247d
Merge pull request #10651 from yuwata/fix-10598
...
conf-parser: ignore trailing back-slash in comment
2018-11-08 12:36:06 +01:00
2cf6db4fb5
Merge pull request #10687 from mrc0mmand/fix-test-capabilities
...
Fix test-capability
2018-11-08 12:35:39 +01:00
731555601c
travis: drop the workaround for test-capability
2018-11-08 11:07:27 +01:00
c446b8486d
tests: drop the precondition check for inherited flag
...
Docker's default capability set has the inherited flag already
set - that breaks tests which expect otherwise. Let's just
drop the check and run the test anyway.
Fixes #10663
2018-11-08 11:07:21 +01:00
64af816228
core/device: use LIST_FOREACH_AFTER() or friend
2018-11-08 10:58:25 +01:00
bbf1120623
unit: make UNIT() cast function deal with NULL pointers
...
Fixes : #10681
2018-11-08 10:47:08 +01:00
2ca4d779e0
man: document the details of continuations and comments
2018-11-08 18:09:04 +09:00
9adbfeb38a
conf-parser: ignore trailing back-slash in comment
...
Fixes #10598 .
2018-11-08 18:09:04 +09:00
cc83d5197c
random-util: optionally allow randomness to be generated via RDRAND
...
We only use this when we don't require the best randomness. The primary
usecase for this is UUID generation, as this means we don't drain
randomness from the kernel pool for them. Since UUIDs are usually not
secrets RDRAND should be goot enough for them to avoid real-life
collisions.
2018-11-08 09:44:27 +01:00
6fb6f13896
random-util: introduce RANDOM_DONT_DRAIN
...
Originally, the high_quality_required boolean argument controlled two
things: whether to extend any random data we successfully read with
pseudo-random data, and whether to return -ENODATA if we couldn't read
any data at all.
The boolean got replaced by RANDOM_EXTEND_WITH_PSEUDO, but this name
doesn't really cover the second part nicely. Moreover hiding both
changes of behaviour under a single flag is confusing. Hence, let's
split this part off under a new flag, and use it from random_bytes().
2018-11-08 09:44:27 +01:00
776cf7461f
random-util: if zero random bytes are requested we can always fulfill the request
2018-11-08 09:44:27 +01:00
68534345b8
random-util: optionally enable blocking getrandom() behaviour
...
When generating the salt for the firstboot password logic, let's use
getrandom() blocking mode, and insist in the very best entropy.
2018-11-08 09:44:27 +01:00
94d457e8d9
random-util: change high_quality_required bool parameter into a flags parameter
...
No change in behaviour, just some refactoring.
2018-11-08 09:44:27 +01:00
afff8f16ae
random-util: fix indentation
2018-11-08 09:44:27 +01:00
d68ccc0841
random-util: handle if getrandom() returns 0
...
This should normally not happen, but given that the man page suggests
something about this in the context of interruption, let's handle this
and propagate an I/O error.
2018-11-08 09:44:27 +01:00
3335dc2d75
random-util: rename acquire_random_bytes() → genuine_random_bytes()
...
It's more descriptive, since we also have a function random_bytes()
which sounds very similar.
Also rename pseudorandom_bytes() to pseudo_random_bytes(). This way the
two functions are nicely systematic, one returning genuine random bytes
and the other pseudo random ones.
2018-11-08 09:44:27 +01:00
8d2411f693
Merge pull request #10682 from yuwata/fix-oss-fuzz-network-issues
...
network: fix memleak
2018-11-08 09:37:35 +01:00
b9c04eafb8
core: introduce exec_params_clear()
...
Follow-up for 1ad6e8b302Fixes #10677 .
2018-11-08 09:36:37 +01:00
0ccc48b5b8
man: Fix implicit dep info for timer units ( #10679 )
...
This reorganizes the systemd.timer man page so that it doesn't claim
there are no implicit dependencies right after specifying the implicit
dependencies, and so that it matches the other man pages for units. This
fixes a mistake introduced by commit aed5cb03db
2018-11-08 12:41:06 +09:00
d571998498
fuzz: add a testcase for oss-fuzz#11285
2018-11-08 12:31:02 +09:00
28c3428df0
network: adds missing strv_free()
...
Fixes oss-fuzz#11285.
2018-11-08 12:30:03 +09:00
7a99f98b50
network: make config_parse_radv_search_domains() log error in dns_name_apply_idna()
2018-11-08 12:29:38 +09:00
9f7d3db3ed
fuzz: add more testcases of already fixed issue about multiple netdev kind
...
This adds testcases of oss-fuzz#11286, oss-fuzz#11287, oss-fuzz#11296,
oss-fuzz#11297, and oss-fuzz#11299.
The issue was fixed by 62facba19a
2018-11-08 12:16:13 +09:00
e1b2d44366
Merge pull request #10670 from yuwata/oss-fuzz-netdev-fixes
...
network: ignore multiple assignment of netdev kind
2018-11-07 19:31:31 +01:00
86cf4554ef
logind: fix compilation without utmp ( #10674 )
2018-11-07 17:29:21 +01:00
1432d2dbdf
ask-password: improve log message when inotify limit is reached
...
When inotify_add_watch() fails because of the inotify limit, errno is
set to ENOSPC and then gets shown to users as "No space left on device".
That is very confusing and requires in-depth knowledge of the C library.
Therefore, show user-friendly message when inotify limit is reached.
Fixes #6030 .
2018-11-07 15:48:43 +01:00
e44c5a3ba6
Merge pull request #10594 from poettering/env-reload-fix
...
change handling of environment block of PID1's manager object
2018-11-07 12:49:13 +01:00
e67813dde0
Merge pull request #10610 from yuwata/udev-rules-cleanups
...
udev-rules: replace udev_device by sd_device
2018-11-07 11:34:33 +01:00
1909e9f11d
network: drop unused members in Wireguard object
2018-11-07 18:14:11 +09:00
348784e62a
fuzz: add testcases for oss-fuzz#11279 and #11280
2018-11-07 17:24:41 +09:00
62facba19a
network: ignore multiple assignment of netdev kind
...
Fixes oss-fuzz#11279 and oss-fuzz#11280.
2018-11-07 17:23:50 +09:00
11d93952ea
test: missing "die"
...
Follow-up for a41ff38b09
2018-11-07 08:57:28 +01:00
44f7190c2d
Merge pull request #10668 from evverx/travis-tweaks
...
travis: build and run fuzzers against crash reproducers
2018-11-07 10:13:21 +03:00
eeec5f2a69
travis: show all commands when building systemd
...
This should prevent Travis CI from terminating build jobs
that don't print anything for more than 10 minutes.
See https://travis-ci.org/systemd/systemd/builds/451737177 .
2018-11-07 07:49:50 +01:00
b9abc93558
travis: build and run fuzzers against crash reproducers
2018-11-07 07:47:22 +01:00
c6d8bbb66e
in-addr-util: make in_addr_default_prefix_from_string() or friend set 0 to prefixlen when family == AF_INET6 ( #10665 )
...
Follow-up for a4798d4e6dFixes #10662 .
2018-11-07 15:31:26 +09:00
b74a0b6ae7
test: replace udev_device by sd_device in test-udev
2018-11-07 13:35:03 +09:00
77ad202c72
udevadm-test: replace udev_device by sd_device
2018-11-07 13:35:03 +09:00
cf28ad4689
udev-event: make udev_event_new() take sd_device instead of udev_device
2018-11-07 13:35:03 +09:00
cf697ec00e
udev-rules: replace udev_device by sd_device in udev_rules_apply_to_event()
2018-11-07 13:35:03 +09:00
dbea7f24d2
udev-rules: replace two udev_list_entry_foreach() by corresponding FOREACH_DEVICE_*() macros
2018-11-07 13:35:03 +09:00
1017d66bf5
udev-rules: use structured initializer
2018-11-07 13:35:03 +09:00
92b80c6baa
udev-rules: drop unused member file_list in struct udev_rules
2018-11-07 13:35:03 +09:00
Frantisek Sumsal