eea984028f
docs: Update links to updated docs
2018-10-30 23:01:20 +05:30
5a8a9dee1a
docs: Convert HACKING to Markdown
...
Also fix minor grammatical errors
2018-10-30 15:58:58 +05:30
82143987b3
docs: Convert CODING_STYLE to Markdown
...
Also fix minor grammatical errors
2018-10-30 15:58:44 +05:30
b9e7ea4841
Merge pull request #10564 from evverx/lldp-fuzzer
...
tests: add an lldp fuzzer
2018-10-30 07:54:20 +09:00
bb01aab6ef
doc: spell initramfs properly ( #10566 )
2018-10-30 02:28:11 +09:00
28ffcec2cb
tests: add an lldp fuzzer
...
I went through my antique collection of fuzzers the other day
to see which ones I hadn't sent upstream yet. This one
seems to be nice to have and ready to be merged. As far as I can
tell, it hasn't managed to find anything useful yet,
but it's better to be safe than sorry especially when it comes to networking
code :-)
2018-10-29 15:24:16 +00:00
e0f768c356
journal: drop an unused variable clang is complaining about
...
../../src/systemd/src/journal/journal-file.c:3592:30: warning: unused variable 'p' [-Wunused-variable]
_cleanup_free_ char *p = NULL;
^
1 warning generated.
This is a follow-up to 6812765891
2018-10-29 15:21:58 +00:00
d1a7b5dd07
hwdb: Add Asus T300CHI accelerator matrix
2018-10-29 13:52:53 +01:00
7b32820444
Merge pull request #10551 from keszybz/two-trivial-cleanups
...
Two trivial cleanups
2018-10-29 12:03:27 +09:00
898ce5e8b8
util: do not assign return value if it is not used ( #10552 )
2018-10-28 18:41:35 -07:00
2b68626089
test-chown-rec: use logging helper here too
2018-10-28 23:28:34 +01:00
910fd5317f
test-network-tables: remove duplicate line
2018-10-28 18:27:48 +01:00
815628cdd4
Merge pull request #10512 from yuwata/udev-event-cleanup
...
udev-event: replace udev_device by sd_device
2018-10-28 13:00:14 +01:00
7b36621677
po: update Polish translation
2018-10-28 12:52:46 +01:00
e6b538d066
curl-util: fix error code check from curl_multi_socket_action
...
After curl 7.20.0, this function never returns negative error codes.
Make this consistent with the other call to this function and only
compare against CURLM_OK.
2018-10-27 12:04:45 +02:00
72e3507a60
po: update Japanese translation
2018-10-27 12:03:57 +02:00
9c3c438514
Merge pull request #10537 from poettering/sentinelimania
...
add some missing _sentinel_ decorators
2018-10-27 07:49:28 +09:00
4cade7a15b
udev-event: replace udev_device in subst_format_var() by sd_device
2018-10-27 07:25:27 +09:00
a315999de6
udev-event: drop prototype of nonexistent function
2018-10-27 07:25:27 +09:00
9204d8023f
udev-event: move definition of struct subst_map
2018-10-27 07:25:27 +09:00
eb1f9e30ec
udev-event: replace udev_device in udev_event_execute_rules() by sd_device
...
Also, this adds many logs.
2018-10-27 07:25:27 +09:00
e52eaf5649
udev-event: move devnode handling logic to a new function
...
Also, replace udev_device by sd_device.
2018-10-27 07:25:27 +09:00
2740750d40
udev-event: move conditions to rename network interface into rename_netif()
...
Also, replace udev_device by sd_device.
2018-10-27 07:24:03 +09:00
c1118ceba4
udev-event: rename udev_event_unref() to udev_event_free()
...
As struct udev_event does not have a reference counter.
2018-10-27 07:03:39 +09:00
d737197154
udev-event: fix memleak in udev_event
...
The leak was introduced by 29448498c7
2018-10-27 07:03:39 +09:00
89665d0920
udev-event: use structured initializer at one more place
2018-10-27 07:03:39 +09:00
a368732bc4
udev-event: add more assert()
2018-10-27 07:03:39 +09:00
dc8aec36a6
udev-event: check command is not empty before executing
2018-10-27 07:03:39 +09:00
e9343893f7
udev-event: include device name in error message one more place
2018-10-27 07:03:39 +09:00
7606377e2c
network,udev: drop unnecessary check whether ifindex is positive
...
As sd_device_get_ifindex() now returns positive ifindex when it
succeeds.
2018-10-27 07:03:39 +09:00
5d062b4ef0
test: check sd_device_get_ifindex() returns positive ifindex when it succeeds
2018-10-27 07:03:39 +09:00
1dfa960786
sd-device: return positive ifindex when sd_device_get_ifindex() succeeds
...
As valid ifindex is positive value, not non-negative value.
Follow-up for dcfbde3a43
2018-10-27 07:03:38 +09:00
9bf7dba739
Merge pull request #10506 from poettering/cgroup-mini-fixes
...
various cgroups mini fixes
2018-10-26 20:16:50 +02:00
6897dfe85a
core: add free_and_replace() at one more place
2018-10-26 19:49:15 +02:00
7593c3ecbf
tree-wide: add a few missing _sentinel_ decorators
2018-10-26 19:49:15 +02:00
46f84f955f
cgroup-util: make definition of CGROUP_CONTROLLER_TO_MASK() unsigned
...
Otherwise doing comparing a CGroupMask (which is unsigned in effect)
with the result of CGROUP_CONTROLLER_TO_MASK() will result in warnings
about signedness differences.
2018-10-26 18:43:34 +02:00
f99850a0d4
cgroup-util: FLAGS_SET()ify all things
2018-10-26 18:43:34 +02:00
03afd78029
cgroup: when discovering which controllers the kernel supports mask with what we support
...
Let's use our new CGROUP_MASK_V1 and CGROUP_MASK_V2 definitions for
this.
2018-10-26 18:43:34 +02:00
ab275f2386
cgroup-util: before operating on a mounted cgroup controller check if it actually can be mounted
...
We now have the "BPF" pseudo-controllers. These should never be assumed
to be accessible as /sys/fs/cgroup/<controller> and not through
"cgroup.subtree_control" either, hence always check explicitly before we
go to the file system. We do this through our new CGROUP_MASK_V1 and
CGROUP_MASK_V2 definitions.
2018-10-26 18:43:34 +02:00
4edd65e4cf
cgroup-util: add mask definitions for sets of controllers supported by cgroupsv1 vs. cgroupsv2
2018-10-26 18:43:34 +02:00
604028de60
cgroup-util: disable buffering for cg_enable_everywhere() when writing to cgroup attributes
...
Let's better be safe than sorry.
2018-10-26 18:43:34 +02:00
38a90d45ad
cgroup-util: don't expect cg_mask_from_string()'s return value to be initialized
...
Also, when we fail, don't clobber the return value.
This brings the call more in-line with our usual coding style, and
removes surprises.
None of the callers seemed to care about this behaviour.
2018-10-26 18:43:34 +02:00
0887fa711c
cgroup-util: debug log if /proc/self/ns/cgroup is not available for unexpected reasons
2018-10-26 18:43:34 +02:00
0d76d772d1
Merge pull request #10536 from keszybz/serialize-fixes
...
Tests for the new serialization functions
2018-10-26 17:56:43 +02:00
dc81f52c4d
Merge pull request #10517 from poettering/chown-rec-fixes
...
recursive chowning fixes
2018-10-26 16:26:20 +02:00
cb9e44db36
test: add test case for recursive chown()ing
2018-10-26 15:13:26 +02:00
cd6b7d50c3
chown-recursive: TAKE_FD() is your friend
2018-10-26 15:13:26 +02:00
f89bc84f32
chown-recursive: also drop ACLs when recursively chown()ing
...
Let's better be safe than sorry and also drop ACLs.
2018-10-26 15:13:26 +02:00
5de6cce58b
chown-recursive: let's rework the recursive logic to use O_PATH
...
That way we can pin a specific inode and analyze it and manipulate it
without it being swapped out beneath our hands.
Fixes a vulnerability originally found by Jann Horn from Google.
CVE-2018-15687
LP: #1796692
https://bugzilla.redhat.com/show_bug.cgi?id=1639076
2018-10-26 15:13:26 +02:00
845702c638
lgtm: drop redundant newlines
2018-10-26 14:52:17 +02:00
Faheel Ahmad