picnoir/Systemd
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

tree-wide: avoid some loaded terms

Browse source 
https://tools.ietf.org/html/draft-knodel-terminology-02
https://lwn.net/Articles/823224/

This gets rid of most but not occasions of these loaded terms:

1. scsi_id and friends are something that is supposed to be removed from
   our tree (see #7594)

2. The test suite defines an API used by the ubuntu CI. We can remove
   this too later, but this needs to be done in sync with the ubuntu CI.

3. In some cases the terms are part of APIs we call or where we expose
   concepts the kernel names the way it names them. (In particular all
   remaining uses of the word "slave" in our codebase are like this,
   it's used by the POSIX PTY layer, by the network subsystem, the mount
   API and the block device subsystem). Getting rid of the term in these
   contexts would mean doing some major fixes of the kernel ABI first.

Regarding the replacements: when whitelist/blacklist is used as noun we
replace with with allow list/deny list, and when used as verb with
allow-list/deny-list.
This commit is contained in:
Lennart Poettering 2020-06-23 08:31:16 +02:00 committed by Zbigniew Jędrzejewski-Szmek
parent b18573e16f
commit 6b000af4f2
51 changed files with 365 additions and 354 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

43
NEWS
View file

@ -373,6 +373,10 @@ CHANGES WITH 246 in spe:
its pending removal 2 years ago (also see NEWS file below). It's its pending removal 2 years ago (also see NEWS file below). It's
finally gone now. finally gone now.
* The BlackList= settings in .network files' [DHCPv4] and
[IPv6AcceptRA] sections have been renamed DenyList=. The old names
are still understood to provide compatibility.
CHANGES WITH 245: CHANGES WITH 245:
* A new tool "systemd-repart" has been added, that operates as an * A new tool "systemd-repart" has been added, that operates as an
@ -744,7 +748,7 @@ CHANGES WITH 244:
of the PAM session, for example for time-limited logins. of the PAM session, for example for time-limited logins.
* A new @pkey system call group is now defined to make it easier to * A new @pkey system call group is now defined to make it easier to
whitelist memory protection syscalls for containers and services allow-list memory protection syscalls for containers and services
which need to use them. which need to use them.
* systemd-udevd: removed the 30s timeout for killing stale workers on * systemd-udevd: removed the 30s timeout for killing stale workers on
@ -761,10 +765,10 @@ CHANGES WITH 244:
* udev now provides a program (fido_id) that identifies FIDO CTAP1 * udev now provides a program (fido_id) that identifies FIDO CTAP1
("U2F")/CTAP2 security tokens based on the usage declared in their ("U2F")/CTAP2 security tokens based on the usage declared in their
report and descriptor and outputs suitable environment variables. report and descriptor and outputs suitable environment variables.
This replaces the externally maintained whitelists of all known This replaces the externally maintained allow lists of all known
security tokens that were used previously. security tokens that were used previously.
* Automatically generated autosuspend udev rules for whitelisted * Automatically generated autosuspend udev rules for allow-listed
devices have been imported from the Chromium OS project. This should devices have been imported from the Chromium OS project. This should
improve power saving with many more devices. improve power saving with many more devices.
@ -1131,7 +1135,7 @@ CHANGES WITH 243:
* systemd-networkd's DHCPv4 support now understands a new MaxAttempts= * systemd-networkd's DHCPv4 support now understands a new MaxAttempts=
option for configuring the maximum number of DHCP lease requests. It option for configuring the maximum number of DHCP lease requests. It
also learnt a new BlackList= option for blacklisting DHCP servers (a also learnt a new BlackList= option for deny-listing DHCP servers (a
similar setting has also been added to the IPv6 RA client), as well similar setting has also been added to the IPv6 RA client), as well
as a SendRelease= option for configuring whether to send a DHCP as a SendRelease= option for configuring whether to send a DHCP
RELEASE message when terminating. RELEASE message when terminating.
@ -2363,12 +2367,12 @@ CHANGES WITH 239:
any relevant symlinks both in /run and /etc. any relevant symlinks both in /run and /etc.
* Note that all long-running system services shipped with systemd will * Note that all long-running system services shipped with systemd will
now default to a system call whitelist (rather than a blacklist, as now default to a system call allow list (rather than a deny list, as
before). In particular, systemd-udevd will now enforce one too. For before). In particular, systemd-udevd will now enforce one too. For
most cases this should be safe, however downstream distributions most cases this should be safe, however downstream distributions
which disabled sandboxing of systemd-udevd (specifically the which disabled sandboxing of systemd-udevd (specifically the
MountFlags= setting), might want to disable this security feature MountFlags= setting), might want to disable this security feature
too, as the default whitelisting will prohibit all mount, swap, too, as the default allow-listing will prohibit all mount, swap,
reboot and clock changing operations from udev rules. reboot and clock changing operations from udev rules.
* sd-boot acquired new loader configuration settings to optionally turn * sd-boot acquired new loader configuration settings to optionally turn
@ -3396,7 +3400,7 @@ CHANGES WITH 235:
* systemd-nspawn gained support for a new --system-call-filter= command * systemd-nspawn gained support for a new --system-call-filter= command
line option for adding and removing entries in the default system line option for adding and removing entries in the default system
call filter it applies. Moreover systemd-nspawn has been changed to call filter it applies. Moreover systemd-nspawn has been changed to
implement a system call whitelist instead of a blacklist. implement a system call allow list instead of a deny list.
* systemd-run gained support for a new --pipe command line option. If * systemd-run gained support for a new --pipe command line option. If
used the STDIN/STDOUT/STDERR file descriptors passed to systemd-run used the STDIN/STDOUT/STDERR file descriptors passed to systemd-run
@ -6109,11 +6113,10 @@ CHANGES WITH 220:
fsck's progress report to an AF_UNIX socket in the file fsck's progress report to an AF_UNIX socket in the file
system. system.
* udev will no longer create device symlinks for all block * udev will no longer create device symlinks for all block devices by
devices by default. A blacklist for excluding special block default. A deny list for excluding special block devices from this
devices from this logic has been turned into a whitelist logic has been turned into a allow list that requires picking block
that requires picking block devices explicitly that require devices explicitly that require device symlinks.
device symlinks.
* A new (currently still internal) API sd-device.h has been * A new (currently still internal) API sd-device.h has been
added to libsystemd. This modernized API is supposed to added to libsystemd. This modernized API is supposed to
@ -8002,11 +8005,11 @@ CHANGES WITH 210:
Wikipedia. We explicitly document which base applies for Wikipedia. We explicitly document which base applies for
each configuration option. each configuration option.
* The DeviceAllow= setting in unit files now supports a syntax * The DeviceAllow= setting in unit files now supports a syntax to
to whitelist an entire group of devices node majors at once, allow-list an entire group of devices node majors at once, based on
based on the /proc/devices listing. For example, with the the /proc/devices listing. For example, with the string "char-pts",
string "char-pts", it is now possible to whitelist all it is now possible to allow-list all current and future pseudo-TTYs
current and future pseudo-TTYs at once. at once.
* sd-event learned a new "post" event source. Event sources of * sd-event learned a new "post" event source. Event sources of
this type are triggered by the dispatching of any event this type are triggered by the dispatching of any event
@ -10249,9 +10252,9 @@ CHANGES WITH 187:
* journalctl gained the new "--header" switch to introspect * journalctl gained the new "--header" switch to introspect
header data of journal files. header data of journal files.
* A new setting SystemCallFilters= has been added to services * A new setting SystemCallFilters= has been added to services which may
which may be used to apply blacklists or whitelists to be used to apply deny lists or allow lists to system calls. This is
system calls. This is based on SECCOMP Mode 2 of Linux 3.5. based on SECCOMP Mode 2 of Linux 3.5.
* nspawn gained a new --link-journal= switch (and quicker: -j) * nspawn gained a new --link-journal= switch (and quicker: -j)
to link the container journal with the host. This makes it to link the container journal with the host. This makes it

6
docs/USER_NAMES.md
View file

@ -68,9 +68,9 @@ Distilled from the above, below are the rules systemd enforces on user/group
names. An additional, common rule between both modes listed below is that empty names. An additional, common rule between both modes listed below is that empty
strings are not valid user/group names. strings are not valid user/group names.
Philosophically, the strict mode described below enforces a white-list of what's Philosophically, the strict mode described below enforces an allow list of
allowed and prohibits everything else, while the relaxed mode described below what's allowed and prohibits everything else, while the relaxed mode described
implements a blacklist of what's not allowed and permits everything else. below implements a deny list of what's not allowed and permits everything else.
### Strict mode ### Strict mode

37
man/systemd-nspawn.xml
View file

@ -1000,29 +1000,28 @@
<varlistentry> <varlistentry>
<term><option>--no-new-privileges=</option></term> <term><option>--no-new-privileges=</option></term>
<listitem><para>Takes a boolean argument. Specifies the value of the <constant>PR_SET_NO_NEW_PRIVS</constant> <listitem><para>Takes a boolean argument. Specifies the value of the
flag for the container payload. Defaults to off. When turned on the payload code of the container cannot <constant>PR_SET_NO_NEW_PRIVS</constant> flag for the container payload. Defaults to off. When turned
acquire new privileges, i.e. the "setuid" file bit as well as file system capabilities will not have an effect on the payload code of the container cannot acquire new privileges, i.e. the "setuid" file bit as
anymore. See <citerefentry well as file system capabilities will not have an effect anymore. See <citerefentry
project='man-pages'><refentrytitle>prctl</refentrytitle><manvolnum>2</manvolnum></citerefentry> for details project='man-pages'><refentrytitle>prctl</refentrytitle><manvolnum>2</manvolnum></citerefentry> for
about this flag. </para></listitem> details about this flag. </para></listitem>
</varlistentry> </varlistentry>
<varlistentry> <varlistentry>
<term><option>--system-call-filter=</option></term> <term><option>--system-call-filter=</option></term> <listitem><para>Alter the system call filter
applied to containers. Takes a space-separated list of system call names or group names (the latter
<listitem><para>Alter the system call filter applied to containers. Takes a space-separated list of system call prefixed with <literal>@</literal>, as listed by the <command>syscall-filter</command> command of
names or group names (the latter prefixed with <literal>@</literal>, as listed by the
<command>syscall-filter</command> command of
<citerefentry><refentrytitle>systemd-analyze</refentrytitle><manvolnum>1</manvolnum></citerefentry>). Passed <citerefentry><refentrytitle>systemd-analyze</refentrytitle><manvolnum>1</manvolnum></citerefentry>). Passed
system calls will be permitted. The list may optionally be prefixed by <literal>~</literal>, in which case all system calls will be permitted. The list may optionally be prefixed by <literal>~</literal>, in which
listed system calls are prohibited. If this command line option is used multiple times the configured lists are case all listed system calls are prohibited. If this command line option is used multiple times the
combined. If both a positive and a negative list (that is one system call list without and one with the configured lists are combined. If both a positive and a negative list (that is one system call list
<literal>~</literal> prefix) are configured, the negative list takes precedence over the positive list. Note without and one with the <literal>~</literal> prefix) are configured, the negative list takes
that <command>systemd-nspawn</command> always implements a system call whitelist (as opposed to a blacklist), precedence over the positive list. Note that <command>systemd-nspawn</command> always implements a
and this command line option hence adds or removes entries from the default whitelist, depending on the system call allow list (as opposed to a deny list!), and this command line option hence adds or
<literal>~</literal> prefix. Note that the applied system call filter is also altered implicitly if additional removes entries from the default allow list, depending on the <literal>~</literal> prefix. Note that
capabilities are passed using the <command>--capabilities=</command>.</para></listitem> the applied system call filter is also altered implicitly if additional capabilities are passed using
the <command>--capabilities=</command>.</para></listitem>
</varlistentry> </varlistentry>
<varlistentry> <varlistentry>

97
man/systemd.exec.xml
View file

@ -318,7 +318,7 @@
files or directories. Moreover <varname>ProtectSystem=strict</varname> and files or directories. Moreover <varname>ProtectSystem=strict</varname> and
<varname>ProtectHome=read-only</varname> are implied, thus prohibiting the service to write to <varname>ProtectHome=read-only</varname> are implied, thus prohibiting the service to write to
arbitrary file system locations. In order to allow the service to write to certain directories, they arbitrary file system locations. In order to allow the service to write to certain directories, they
have to be whitelisted using <varname>ReadWritePaths=</varname>, but care must be taken so that have to be allow-listed using <varname>ReadWritePaths=</varname>, but care must be taken so that
UID/GID recycling doesn't create security issues involving files created by the service. Use UID/GID recycling doesn't create security issues involving files created by the service. Use
<varname>RuntimeDirectory=</varname> (see below) in order to assign a writable runtime directory to a <varname>RuntimeDirectory=</varname> (see below) in order to assign a writable runtime directory to a
service, owned by the dynamic user/group and removed automatically when the unit is terminated. Use service, owned by the dynamic user/group and removed automatically when the unit is terminated. Use
@ -1150,12 +1150,13 @@ StateDirectory=aaa/bbb ccc</programlisting>
contain symlinks, they are resolved relative to the root directory set with contain symlinks, they are resolved relative to the root directory set with
<varname>RootDirectory=</varname>/<varname>RootImage=</varname>.</para> <varname>RootDirectory=</varname>/<varname>RootImage=</varname>.</para>
<para>Paths listed in <varname>ReadWritePaths=</varname> are accessible from within the namespace with the same <para>Paths listed in <varname>ReadWritePaths=</varname> are accessible from within the namespace
access modes as from outside of it. Paths listed in <varname>ReadOnlyPaths=</varname> are accessible for with the same access modes as from outside of it. Paths listed in <varname>ReadOnlyPaths=</varname>
reading only, writing will be refused even if the usual file access controls would permit this. Nest are accessible for reading only, writing will be refused even if the usual file access controls would
<varname>ReadWritePaths=</varname> inside of <varname>ReadOnlyPaths=</varname> in order to provide writable permit this. Nest <varname>ReadWritePaths=</varname> inside of <varname>ReadOnlyPaths=</varname> in
subdirectories within read-only directories. Use <varname>ReadWritePaths=</varname> in order to whitelist order to provide writable subdirectories within read-only directories. Use
specific paths for write access if <varname>ProtectSystem=strict</varname> is used.</para> <varname>ReadWritePaths=</varname> in order to allow-list specific paths for write access if
<varname>ProtectSystem=strict</varname> is used.</para>
<para>Paths listed in <varname>InaccessiblePaths=</varname> will be made inaccessible for processes inside <para>Paths listed in <varname>InaccessiblePaths=</varname> will be made inaccessible for processes inside
the namespace along with everything below them in the file system hierarchy. This may be more restrictive than the namespace along with everything below them in the file system hierarchy. This may be more restrictive than
@ -1469,29 +1470,31 @@ BindReadOnlyPaths=/var/lib/systemd</programlisting>
<varlistentry> <varlistentry>
<term><varname>RestrictAddressFamilies=</varname></term> <term><varname>RestrictAddressFamilies=</varname></term>
<listitem><para>Restricts the set of socket address families accessible to the processes of this unit. Takes a <listitem><para>Restricts the set of socket address families accessible to the processes of this
space-separated list of address family names to whitelist, such as <constant>AF_UNIX</constant>, unit. Takes a space-separated list of address family names to allow-list, such as
<constant>AF_INET</constant> or <constant>AF_INET6</constant>. When prefixed with <constant>~</constant> the <constant>AF_UNIX</constant>, <constant>AF_INET</constant> or <constant>AF_INET6</constant>. When
listed address families will be applied as blacklist, otherwise as whitelist. Note that this restricts access prefixed with <constant>~</constant> the listed address families will be applied as deny list,
to the <citerefentry otherwise as allow list. Note that this restricts access to the <citerefentry
project='man-pages'><refentrytitle>socket</refentrytitle><manvolnum>2</manvolnum></citerefentry> system call project='man-pages'><refentrytitle>socket</refentrytitle><manvolnum>2</manvolnum></citerefentry>
only. Sockets passed into the process by other means (for example, by using socket activation with socket system call only. Sockets passed into the process by other means (for example, by using socket
units, see <citerefentry><refentrytitle>systemd.socket</refentrytitle><manvolnum>5</manvolnum></citerefentry>) activation with socket units, see
are unaffected. Also, sockets created with <function>socketpair()</function> (which creates connected AF_UNIX <citerefentry><refentrytitle>systemd.socket</refentrytitle><manvolnum>5</manvolnum></citerefentry>)
sockets only) are unaffected. Note that this option has no effect on 32-bit x86, s390, s390x, mips, mips-le, are unaffected. Also, sockets created with <function>socketpair()</function> (which creates connected
ppc, ppc-le, pcc64, ppc64-le and is ignored (but works correctly on other ABIs, including x86-64). Note that on AF_UNIX sockets only) are unaffected. Note that this option has no effect on 32-bit x86, s390, s390x,
systems supporting multiple ABIs (such as x86/x86-64) it is recommended to turn off alternative ABIs for mips, mips-le, ppc, ppc-le, pcc64, ppc64-le and is ignored (but works correctly on other ABIs,
services, so that they cannot be used to circumvent the restrictions of this option. Specifically, it is including x86-64). Note that on systems supporting multiple ABIs (such as x86/x86-64) it is
recommended to combine this option with <varname>SystemCallArchitectures=native</varname> or similar. If recommended to turn off alternative ABIs for services, so that they cannot be used to circumvent the
running in user mode, or in system mode, but without the <constant>CAP_SYS_ADMIN</constant> capability restrictions of this option. Specifically, it is recommended to combine this option with
(e.g. setting <varname>User=nobody</varname>), <varname>NoNewPrivileges=yes</varname> is implied. By default, <varname>SystemCallArchitectures=native</varname> or similar. If running in user mode, or in system
no restrictions apply, all address families are accessible to processes. If assigned the empty string, any mode, but without the <constant>CAP_SYS_ADMIN</constant> capability (e.g. setting
previous address family restriction changes are undone. This setting does not affect commands prefixed with <varname>User=nobody</varname>), <varname>NoNewPrivileges=yes</varname> is implied. By default, no
<literal>+</literal>.</para> restrictions apply, all address families are accessible to processes. If assigned the empty string,
any previous address family restriction changes are undone. This setting does not affect commands
prefixed with <literal>+</literal>.</para>
<para>Use this option to limit exposure of processes to remote access, in particular via exotic and sensitive <para>Use this option to limit exposure of processes to remote access, in particular via exotic and sensitive
network protocols, such as <constant>AF_PACKET</constant>. Note that in most cases, the local network protocols, such as <constant>AF_PACKET</constant>. Note that in most cases, the local
<constant>AF_UNIX</constant> address family should be included in the configured whitelist as it is frequently <constant>AF_UNIX</constant> address family should be included in the configured allow list as it is frequently
used for local communication, including for used for local communication, including for
<citerefentry><refentrytitle>syslog</refentrytitle><manvolnum>2</manvolnum></citerefentry> <citerefentry><refentrytitle>syslog</refentrytitle><manvolnum>2</manvolnum></citerefentry>
logging.</para></listitem> logging.</para></listitem>
@ -1509,9 +1512,9 @@ BindReadOnlyPaths=/var/lib/systemd</programlisting>
any combination of: <constant>cgroup</constant>, <constant>ipc</constant>, <constant>net</constant>, any combination of: <constant>cgroup</constant>, <constant>ipc</constant>, <constant>net</constant>,
<constant>mnt</constant>, <constant>pid</constant>, <constant>user</constant> and <constant>uts</constant>. Any <constant>mnt</constant>, <constant>pid</constant>, <constant>user</constant> and <constant>uts</constant>. Any
namespace type listed is made accessible to the unit's processes, access to namespace types not listed is namespace type listed is made accessible to the unit's processes, access to namespace types not listed is
prohibited (whitelisting). By prepending the list with a single tilde character (<literal>~</literal>) the prohibited (allow-listing). By prepending the list with a single tilde character (<literal>~</literal>) the
effect may be inverted: only the listed namespace types will be made inaccessible, all unlisted ones are effect may be inverted: only the listed namespace types will be made inaccessible, all unlisted ones are
permitted (blacklisting). If the empty string is assigned, the default namespace restrictions are applied, permitted (deny-listing). If the empty string is assigned, the default namespace restrictions are applied,
which is equivalent to false. This option may appear more than once, in which case the namespace types are which is equivalent to false. This option may appear more than once, in which case the namespace types are
merged by <constant>OR</constant>, or by <constant>AND</constant> if the lines are prefixed with merged by <constant>OR</constant>, or by <constant>AND</constant> if the lines are prefixed with
<literal>~</literal> (see examples below). Internally, this setting limits access to the <literal>~</literal> (see examples below). Internally, this setting limits access to the
@ -1701,15 +1704,15 @@ RestrictNamespaces=~cgroup net</programlisting>
<listitem><para>Takes a space-separated list of system call names. If this setting is used, all <listitem><para>Takes a space-separated list of system call names. If this setting is used, all
system calls executed by the unit processes except for the listed ones will result in immediate system calls executed by the unit processes except for the listed ones will result in immediate
process termination with the <constant>SIGSYS</constant> signal (whitelisting). (See process termination with the <constant>SIGSYS</constant> signal (allow-listing). (See
<varname>SystemCallErrorNumber=</varname> below for changing the default action). If the first <varname>SystemCallErrorNumber=</varname> below for changing the default action). If the first
character of the list is <literal>~</literal>, the effect is inverted: only the listed system calls character of the list is <literal>~</literal>, the effect is inverted: only the listed system calls
will result in immediate process termination (blacklisting). Blacklisted system calls and system call will result in immediate process termination (deny-listing). Deny-listed system calls and system call
groups may optionally be suffixed with a colon (<literal>:</literal>) and <literal>errno</literal> groups may optionally be suffixed with a colon (<literal>:</literal>) and <literal>errno</literal>
error number (between 0 and 4095) or errno name such as <constant>EPERM</constant>, error number (between 0 and 4095) or errno name such as <constant>EPERM</constant>,
<constant>EACCES</constant> or <constant>EUCLEAN</constant> (see <citerefentry <constant>EACCES</constant> or <constant>EUCLEAN</constant> (see <citerefentry
project='man-pages'><refentrytitle>errno</refentrytitle><manvolnum>3</manvolnum></citerefentry> for a project='man-pages'><refentrytitle>errno</refentrytitle><manvolnum>3</manvolnum></citerefentry> for a
full list). This value will be returned when a blacklisted system call is triggered, instead of full list). This value will be returned when a deny-listed system call is triggered, instead of
terminating the processes immediately. This value takes precedence over the one given in terminating the processes immediately. This value takes precedence over the one given in
<varname>SystemCallErrorNumber=</varname>, see below. If running in user mode, or in system mode, <varname>SystemCallErrorNumber=</varname>, see below. If running in user mode, or in system mode,
but without the <constant>CAP_SYS_ADMIN</constant> capability (e.g. setting but without the <constant>CAP_SYS_ADMIN</constant> capability (e.g. setting
@ -1718,7 +1721,7 @@ RestrictNamespaces=~cgroup net</programlisting>
for enforcing a minimal sandboxing environment. Note that the <function>execve</function>, for enforcing a minimal sandboxing environment. Note that the <function>execve</function>,
<function>exit</function>, <function>exit_group</function>, <function>getrlimit</function>, <function>exit</function>, <function>exit_group</function>, <function>getrlimit</function>,
<function>rt_sigreturn</function>, <function>sigreturn</function> system calls and the system calls <function>rt_sigreturn</function>, <function>sigreturn</function> system calls and the system calls
for querying time and sleeping are implicitly whitelisted and do not need to be listed for querying time and sleeping are implicitly allow-listed and do not need to be listed
explicitly. This option may be specified more than once, in which case the filter masks are explicitly. This option may be specified more than once, in which case the filter masks are
merged. If the empty string is assigned, the filter is reset, all prior assignments will have no merged. If the empty string is assigned, the filter is reset, all prior assignments will have no
effect. This does not affect commands prefixed with <literal>+</literal>.</para> effect. This does not affect commands prefixed with <literal>+</literal>.</para>
@ -1736,12 +1739,13 @@ RestrictNamespaces=~cgroup net</programlisting>
might be necessary to temporarily disable system call filters in order to simplify debugging of such might be necessary to temporarily disable system call filters in order to simplify debugging of such
failures.</para> failures.</para>
<para>If you specify both types of this option (i.e. whitelisting and blacklisting), the first encountered <para>If you specify both types of this option (i.e. allow-listing and deny-listing), the first
will take precedence and will dictate the default action (termination or approval of a system call). Then the encountered will take precedence and will dictate the default action (termination or approval of a
next occurrences of this option will add or delete the listed system calls from the set of the filtered system system call). Then the next occurrences of this option will add or delete the listed system calls
calls, depending of its type and the default action. (For example, if you have started with a whitelisting of from the set of the filtered system calls, depending of its type and the default action. (For
<function>read</function> and <function>write</function>, and right after it add a blacklisting of example, if you have started with an allow list rule for <function>read</function> and
<function>write</function>, then <function>write</function> will be removed from the set.)</para> <function>write</function>, and right after it add a deny list rule for <function>write</function>,
then <function>write</function> will be removed from the set.)</para>
<para>As the number of possible system calls is large, predefined sets of system calls are provided. A set <para>As the number of possible system calls is large, predefined sets of system calls are provided. A set
starts with <literal>@</literal> character, followed by name of the set. starts with <literal>@</literal> character, followed by name of the set.
@ -1857,7 +1861,7 @@ RestrictNamespaces=~cgroup net</programlisting>
</row> </row>
<row> <row>
<entry>@system-service</entry> <entry>@system-service</entry>
<entry>A reasonable set of system calls used by common system services, excluding any special purpose calls. This is the recommended starting point for whitelisting system calls for system services, as it contains what is typically needed by system services, but excludes overly specific interfaces. For example, the following APIs are excluded: <literal>@clock</literal>, <literal>@mount</literal>, <literal>@swap</literal>, <literal>@reboot</literal>.</entry> <entry>A reasonable set of system calls used by common system services, excluding any special purpose calls. This is the recommended starting point for allow-listing system calls for system services, as it contains what is typically needed by system services, but excludes overly specific interfaces. For example, the following APIs are excluded: <literal>@clock</literal>, <literal>@mount</literal>, <literal>@swap</literal>, <literal>@reboot</literal>.</entry>
</row> </row>
<row> <row>
<entry>@timer</entry> <entry>@timer</entry>
@ -1873,9 +1877,10 @@ RestrictNamespaces=~cgroup net</programlisting>
<command>systemd-analyze syscall-filter</command> to list the actual list of system calls in each <command>systemd-analyze syscall-filter</command> to list the actual list of system calls in each
filter.</para> filter.</para>
<para>Generally, whitelisting system calls (rather than blacklisting) is the safer mode of operation. It is <para>Generally, allow-listing system calls (rather than deny-listing) is the safer mode of
recommended to enforce system call whitelists for all long-running system services. Specifically, the operation. It is recommended to enforce system call allow lists for all long-running system
following lines are a relatively safe basic choice for the majority of system services:</para> services. Specifically, the following lines are a relatively safe basic choice for the majority of
system services:</para>
<programlisting>[Service] <programlisting>[Service]
SystemCallFilter=@system-service SystemCallFilter=@system-service
@ -1886,9 +1891,9 @@ SystemCallErrorNumber=EPERM</programlisting>
call may be used to execute operations similar to what can be done with the older call may be used to execute operations similar to what can be done with the older
<function>kill()</function> system call, hence blocking the latter without the former only provides <function>kill()</function> system call, hence blocking the latter without the former only provides
weak protection. Since new system calls are added regularly to the kernel as development progresses, weak protection. Since new system calls are added regularly to the kernel as development progresses,
keeping system call blacklists comprehensive requires constant work. It is thus recommended to use keeping system call deny lists comprehensive requires constant work. It is thus recommended to use
whitelisting instead, which offers the benefit that new system calls are by default implicitly allow-listing instead, which offers the benefit that new system calls are by default implicitly
blocked until the whitelist is updated.</para> blocked until the allow list is updated.</para>
<para>Also note that a number of system calls are required to be accessible for the dynamic linker to <para>Also note that a number of system calls are required to be accessible for the dynamic linker to
work. The dynamic linker is required for running most regular programs (specifically: all dynamic ELF work. The dynamic linker is required for running most regular programs (specifically: all dynamic ELF

4
man/systemd.network.xml
View file

@ -1679,7 +1679,7 @@
</varlistentry> </varlistentry>
<varlistentry> <varlistentry>
<term><varname>BlackList=</varname></term> <term><varname>DenyList=</varname></term>
<listitem> <listitem>
<para>A whitespace-separated list of IPv4 addresses. DHCP offers from servers in the list are rejected.</para> <para>A whitespace-separated list of IPv4 addresses. DHCP offers from servers in the list are rejected.</para>
</listitem> </listitem>
@ -1945,7 +1945,7 @@
</varlistentry> </varlistentry>
<varlistentry> <varlistentry>
<term><varname>BlackList=</varname></term> <term><varname>DenyList=</varname></term>
<listitem> <listitem>
<para>A whitespace-separated list of IPv6 prefixes. IPv6 prefixes supplied via router advertisements in the list are ignored.</para> <para>A whitespace-separated list of IPv6 prefixes. IPv6 prefixes supplied via router advertisements in the list are ignored.</para>
</listitem> </listitem>

18
man/systemd.resource-control.xml
View file

@ -596,13 +596,13 @@
<listitem><para>Otherwise, access is granted.</para></listitem> <listitem><para>Otherwise, access is granted.</para></listitem>
</itemizedlist> </itemizedlist>
<para>In order to implement a whitelisting IP firewall, it is recommended to use a <para>In order to implement an allow-listing IP firewall, it is recommended to use a
<varname>IPAddressDeny=</varname><constant>any</constant> setting on an upper-level slice unit (such as the <varname>IPAddressDeny=</varname><constant>any</constant> setting on an upper-level slice unit
root slice <filename>-.slice</filename> or the slice containing all system services (such as the root slice <filename>-.slice</filename> or the slice containing all system services
<filename>system.slice</filename> – see <filename>system.slice</filename> – see
<citerefentry><refentrytitle>systemd.special</refentrytitle><manvolnum>7</manvolnum></citerefentry> for <citerefentry><refentrytitle>systemd.special</refentrytitle><manvolnum>7</manvolnum></citerefentry>
details on these slice units), plus individual per-service <varname>IPAddressAllow=</varname> lines for details on these slice units), plus individual per-service <varname>IPAddressAllow=</varname>
permitting network access to relevant services, and only them.</para> lines permitting network access to relevant services, and only them.</para>
<para>Note that for socket-activated services, the IP access list configured on the socket unit <para>Note that for socket-activated services, the IP access list configured on the socket unit
applies to all sockets associated with it directly, but not to any sockets created by the applies to all sockets associated with it directly, but not to any sockets created by the
@ -719,7 +719,7 @@
<para>The device node specifier is either a path to a device node in the file system, starting with <para>The device node specifier is either a path to a device node in the file system, starting with
<filename>/dev/</filename>, or a string starting with either <literal>char-</literal> or <filename>/dev/</filename>, or a string starting with either <literal>char-</literal> or
<literal>block-</literal> followed by a device group name, as listed in <literal>block-</literal> followed by a device group name, as listed in
<filename>/proc/devices</filename>. The latter is useful to whitelist all current and future <filename>/proc/devices</filename>. The latter is useful to allow-list all current and future
devices belonging to a specific device group at once. The device group is matched according to devices belonging to a specific device group at once. The device group is matched according to
filename globbing rules, you may hence use the <literal>*</literal> and <literal>?</literal> filename globbing rules, you may hence use the <literal>*</literal> and <literal>?</literal>
wildcards. (Note that such globbing wildcards are not available for device node path wildcards. (Note that such globbing wildcards are not available for device node path
@ -733,9 +733,9 @@
all pseudo TTYs and all ALSA sound devices, respectively. <literal>char-cpu/*</literal> is a all pseudo TTYs and all ALSA sound devices, respectively. <literal>char-cpu/*</literal> is a
specifier matching all CPU related device groups.</para> specifier matching all CPU related device groups.</para>
<para>Note that whitelists defined this way should only reference device groups which are <para>Note that allow lists defined this way should only reference device groups which are
resolvable at the time the unit is started. Any device groups not resolvable then are not added to resolvable at the time the unit is started. Any device groups not resolvable then are not added to
the device whitelist. In order to work around this limitation, consider extending service units the device allow list. In order to work around this limitation, consider extending service units
with a pair of <command>After=modprobe@xyz.service</command> and with a pair of <command>After=modprobe@xyz.service</command> and
<command>Wants=modprobe@xyz.service</command> lines that load the necessary kernel module <command>Wants=modprobe@xyz.service</command> lines that load the necessary kernel module
implementing the device group if missing. implementing the device group if missing.

50
src/analyze/analyze-security.c
View file

@ -91,7 +91,7 @@ struct security_info {
char **system_call_architectures; char **system_call_architectures;
bool system_call_filter_whitelist; bool system_call_filter_allow_list;
Set *system_call_filter; Set *system_call_filter;
uint32_t _umask; uint32_t _umask;
@ -492,7 +492,7 @@ static int assess_system_call_architectures(
#if HAVE_SECCOMP #if HAVE_SECCOMP
static bool syscall_names_in_filter(Set *s, bool whitelist, const SyscallFilterSet *f) { static bool syscall_names_in_filter(Set *s, bool allow_list, const SyscallFilterSet *f) {
const char *syscall; const char *syscall;
NULSTR_FOREACH(syscall, f->value) { NULSTR_FOREACH(syscall, f->value) {
@ -502,7 +502,7 @@ static bool syscall_names_in_filter(Set *s, bool whitelist, const SyscallFilterS
const SyscallFilterSet *g; const SyscallFilterSet *g;
assert_se(g = syscall_filter_set_find(syscall)); assert_se(g = syscall_filter_set_find(syscall));
if (syscall_names_in_filter(s, whitelist, g)) if (syscall_names_in_filter(s, allow_list, g))
return true; /* bad! */ return true; /* bad! */
continue; continue;
@ -513,7 +513,7 @@ static bool syscall_names_in_filter(Set *s, bool whitelist, const SyscallFilterS
if (id < 0) if (id < 0)
continue; continue;
if (set_contains(s, syscall) == whitelist) { if (set_contains(s, syscall) == allow_list) {
log_debug("Offending syscall filter item: %s", syscall); log_debug("Offending syscall filter item: %s", syscall);
return true; /* bad! */ return true; /* bad! */
} }
@ -541,30 +541,30 @@ static int assess_system_call_filter(
assert(a->parameter < _SYSCALL_FILTER_SET_MAX); assert(a->parameter < _SYSCALL_FILTER_SET_MAX);
f = syscall_filter_sets + a->parameter; f = syscall_filter_sets + a->parameter;
if (!info->system_call_filter_whitelist && set_isempty(info->system_call_filter)) { if (!info->system_call_filter_allow_list && set_isempty(info->system_call_filter)) {
d = strdup("Service does not filter system calls"); d = strdup("Service does not filter system calls");
b = 10; b = 10;
} else { } else {
bool bad; bool bad;
log_debug("Analyzing system call filter, checking against: %s", f->name); log_debug("Analyzing system call filter, checking against: %s", f->name);
bad = syscall_names_in_filter(info->system_call_filter, info->system_call_filter_whitelist, f); bad = syscall_names_in_filter(info->system_call_filter, info->system_call_filter_allow_list, f);
log_debug("Result: %s", bad ? "bad" : "good"); log_debug("Result: %s", bad ? "bad" : "good");
if (info->system_call_filter_whitelist) { if (info->system_call_filter_allow_list) {
if (bad) { if (bad) {
(void) asprintf(&d, "System call whitelist defined for service, and %s is included", f->name); (void) asprintf(&d, "System call allow list defined for service, and %s is included", f->name);
b = 9; b = 9;
} else { } else {
(void) asprintf(&d, "System call whitelist defined for service, and %s is not included", f->name); (void) asprintf(&d, "System call allow list defined for service, and %s is not included", f->name);
b = 0; b = 0;
} }
} else { } else {
if (bad) { if (bad) {
(void) asprintf(&d, "System call blacklist defined for service, and %s is not included", f->name); (void) asprintf(&d, "System call deny list defined for service, and %s is not included", f->name);
b = 10; b = 10;
} else { } else {
(void) asprintf(&d, "System call blacklist defined for service, and %s is included", f->name); (void) asprintf(&d, "System call deny list defined for service, and %s is included", f->name);
b = 5; b = 5;
} }
} }
@ -599,13 +599,13 @@ static int assess_ip_address_allow(
d = strdup("Service defines custom ingress/egress IP filters with BPF programs"); d = strdup("Service defines custom ingress/egress IP filters with BPF programs");
b = 0; b = 0;
} else if (!info->ip_address_deny_all) { } else if (!info->ip_address_deny_all) {
d = strdup("Service does not define an IP address whitelist"); d = strdup("Service does not define an IP address allow list");
b = 10; b = 10;
} else if (info->ip_address_allow_other) { } else if (info->ip_address_allow_other) {
d = strdup("Service defines IP address whitelist with non-localhost entries"); d = strdup("Service defines IP address allow list with non-localhost entries");
b = 5; b = 5;
} else if (info->ip_address_allow_localhost) { } else if (info->ip_address_allow_localhost) {
d = strdup("Service defines IP address whitelist with only localhost entries"); d = strdup("Service defines IP address allow list with only localhost entries");
b = 2; b = 2;
} else { } else {
d = strdup("Service blocks all IP address ranges"); d = strdup("Service blocks all IP address ranges");
@ -1639,7 +1639,7 @@ static int property_read_restrict_address_families(
void *userdata) { void *userdata) {
struct security_info *info = userdata; struct security_info *info = userdata;
int whitelist, r; int allow_list, r;
assert(bus); assert(bus);
assert(member); assert(member);
@ -1649,7 +1649,7 @@ static int property_read_restrict_address_families(
if (r < 0) if (r < 0)
return r; return r;
r = sd_bus_message_read(m, "b", &whitelist); r = sd_bus_message_read(m, "b", &allow_list);
if (r < 0) if (r < 0)
return r; return r;
@ -1657,7 +1657,7 @@ static int property_read_restrict_address_families(
info->restrict_address_family_unix = info->restrict_address_family_unix =
info->restrict_address_family_netlink = info->restrict_address_family_netlink =
info->restrict_address_family_packet = info->restrict_address_family_packet =
info->restrict_address_family_other = whitelist; info->restrict_address_family_other = allow_list;
r = sd_bus_message_enter_container(m, 'a', "s"); r = sd_bus_message_enter_container(m, 'a', "s");
if (r < 0) if (r < 0)
@ -1673,15 +1673,15 @@ static int property_read_restrict_address_families(
break; break;
if (STR_IN_SET(name, "AF_INET", "AF_INET6")) if (STR_IN_SET(name, "AF_INET", "AF_INET6"))
info->restrict_address_family_inet = !whitelist; info->restrict_address_family_inet = !allow_list;
else if (streq(name, "AF_UNIX")) else if (streq(name, "AF_UNIX"))
info->restrict_address_family_unix = !whitelist; info->restrict_address_family_unix = !allow_list;
else if (streq(name, "AF_NETLINK")) else if (streq(name, "AF_NETLINK"))
info->restrict_address_family_netlink = !whitelist; info->restrict_address_family_netlink = !allow_list;
else if (streq(name, "AF_PACKET")) else if (streq(name, "AF_PACKET"))
info->restrict_address_family_packet = !whitelist; info->restrict_address_family_packet = !allow_list;
else else
info->restrict_address_family_other = !whitelist; info->restrict_address_family_other = !allow_list;
} }
r = sd_bus_message_exit_container(m); r = sd_bus_message_exit_container(m);
@ -1699,7 +1699,7 @@ static int property_read_system_call_filter(
void *userdata) { void *userdata) {
struct security_info *info = userdata; struct security_info *info = userdata;
int whitelist, r; int allow_list, r;
assert(bus); assert(bus);
assert(member); assert(member);
@ -1709,11 +1709,11 @@ static int property_read_system_call_filter(
if (r < 0) if (r < 0)
return r; return r;
r = sd_bus_message_read(m, "b", &whitelist); r = sd_bus_message_read(m, "b", &allow_list);
if (r < 0) if (r < 0)
return r; return r;
info->system_call_filter_whitelist = whitelist; info->system_call_filter_allow_list = allow_list;
r = sd_bus_message_enter_container(m, 'a', "s"); r = sd_bus_message_enter_container(m, 'a', "s");
if (r < 0) if (r < 0)

4
src/basic/device-nodes.c
View file

@ -7,7 +7,7 @@
#include "device-nodes.h" #include "device-nodes.h"
#include "utf8.h" #include "utf8.h"
int whitelisted_char_for_devnode(char c, const char *white) { int allow_listed_char_for_devnode(char c, const char *white) {
if ((c >= '0' && c <= '9') || if ((c >= '0' && c <= '9') ||
(c >= 'A' && c <= 'Z') || (c >= 'A' && c <= 'Z') ||
@ -38,7 +38,7 @@ int encode_devnode_name(const char *str, char *str_enc, size_t len) {
j += seqlen; j += seqlen;
i += (seqlen-1); i += (seqlen-1);
} else if (str[i] == '\\' || !whitelisted_char_for_devnode(str[i], NULL)) { } else if (str[i] == '\\' || !allow_listed_char_for_devnode(str[i], NULL)) {
if (len-j < 4) if (len-j < 4)
return -EINVAL; return -EINVAL;

2
src/basic/device-nodes.h
View file

@ -8,7 +8,7 @@
#include "stdio-util.h" #include "stdio-util.h"
int encode_devnode_name(const char *str, char *str_enc, size_t len); int encode_devnode_name(const char *str, char *str_enc, size_t len);
int whitelisted_char_for_devnode(char c, const char *additional); int allow_listed_char_for_devnode(char c, const char *additional);
#define DEV_NUM_PATH_MAX \ #define DEV_NUM_PATH_MAX \
(STRLEN("/dev/block/") + DECIMAL_STR_MAX(dev_t) + 1 + DECIMAL_STR_MAX(dev_t)) (STRLEN("/dev/block/") + DECIMAL_STR_MAX(dev_t) + 1 + DECIMAL_STR_MAX(dev_t))

6
src/basic/efivars.c
View file

@ -210,9 +210,9 @@ int efi_set_variable(
if (!p) if (!p)
return -ENOMEM; return -ENOMEM;
/* Newer efivarfs protects variables that are not in a whitelist with FS_IMMUTABLE_FL by default, to protect /* Newer efivarfs protects variables that are not in an allow list with FS_IMMUTABLE_FL by default,
* them for accidental removal and modification. We are not changing these variables accidentally however, * to protect them for accidental removal and modification. We are not changing these variables
* hence let's unset the bit first. */ * accidentally however, hence let's unset the bit first. */
r = chattr_path(p, 0, FS_IMMUTABLE_FL, &saved_flags); r = chattr_path(p, 0, FS_IMMUTABLE_FL, &saved_flags);
if (r < 0 && r != -ENOENT) if (r < 0 && r != -ENOENT)

4
src/basic/fs-util.c
View file

@ -1576,7 +1576,7 @@ static int blockdev_is_encrypted(const char *sysfs_path, unsigned depth_left) {
d = opendir(p); d = opendir(p);
if (!d) { if (!d) {
if (errno == ENOENT) /* Doesn't have slaves */ if (errno == ENOENT) /* Doesn't have underlying devices */
return false; return false;
return -errno; return -errno;
@ -1592,7 +1592,7 @@ static int blockdev_is_encrypted(const char *sysfs_path, unsigned depth_left) {
if (errno != 0) if (errno != 0)
return -errno; return -errno;
break; /* No more slaves */ break; /* No more underlying devices */
} }
q = path_join(p, de->d_name); q = path_join(p, de->d_name);

44
src/core/bpf-devices.c
View file

@ -38,7 +38,7 @@ static int bpf_access_type(const char *acc) {
return r; return r;
} }
static int bpf_prog_whitelist_device( static int bpf_prog_allow_list_device(
BPFProgram *prog, BPFProgram *prog,
char type, char type,
int major, int major,
@ -80,7 +80,7 @@ static int bpf_prog_whitelist_device(
return r; return r;
} }
static int bpf_prog_whitelist_major( static int bpf_prog_allow_list_major(
BPFProgram *prog, BPFProgram *prog,
char type, char type,
int major, int major,
@ -120,7 +120,7 @@ static int bpf_prog_whitelist_major(
return r; return r;
} }
static int bpf_prog_whitelist_class( static int bpf_prog_allow_list_class(
BPFProgram *prog, BPFProgram *prog,
char type, char type,
const char *acc) { const char *acc) {
@ -161,7 +161,7 @@ static int bpf_prog_whitelist_class(
int bpf_devices_cgroup_init( int bpf_devices_cgroup_init(
BPFProgram **ret, BPFProgram **ret,
CGroupDevicePolicy policy, CGroupDevicePolicy policy,
bool whitelist) { bool allow_list) {
const struct bpf_insn pre_insn[] = { const struct bpf_insn pre_insn[] = {
/* load device type to r2 */ /* load device type to r2 */
@ -188,14 +188,14 @@ int bpf_devices_cgroup_init(
assert(ret); assert(ret);
if (policy == CGROUP_DEVICE_POLICY_AUTO && !whitelist) if (policy == CGROUP_DEVICE_POLICY_AUTO && !allow_list)
return 0; return 0;
r = bpf_program_new(BPF_PROG_TYPE_CGROUP_DEVICE, &prog); r = bpf_program_new(BPF_PROG_TYPE_CGROUP_DEVICE, &prog);
if (r < 0) if (r < 0)
return log_error_errno(r, "Loading device control BPF program failed: %m"); return log_error_errno(r, "Loading device control BPF program failed: %m");
if (policy == CGROUP_DEVICE_POLICY_CLOSED || whitelist) { if (policy == CGROUP_DEVICE_POLICY_CLOSED || allow_list) {
r = bpf_program_add_instructions(prog, pre_insn, ELEMENTSOF(pre_insn)); r = bpf_program_add_instructions(prog, pre_insn, ELEMENTSOF(pre_insn));
if (r < 0) if (r < 0)
return log_error_errno(r, "Extending device control BPF program failed: %m"); return log_error_errno(r, "Extending device control BPF program failed: %m");
@ -209,7 +209,7 @@ int bpf_devices_cgroup_init(
int bpf_devices_apply_policy( int bpf_devices_apply_policy(
BPFProgram *prog, BPFProgram *prog,
CGroupDevicePolicy policy, CGroupDevicePolicy policy,
bool whitelist, bool allow_list,
const char *cgroup_path, const char *cgroup_path,
BPFProgram **prog_installed) { BPFProgram **prog_installed) {
@ -221,7 +221,7 @@ int bpf_devices_apply_policy(
if (!prog) if (!prog)
goto finish; goto finish;
const bool deny_everything = policy == CGROUP_DEVICE_POLICY_STRICT && !whitelist; const bool deny_everything = policy == CGROUP_DEVICE_POLICY_STRICT && !allow_list;
const struct bpf_insn post_insn[] = { const struct bpf_insn post_insn[] = {
/* return DENY */ /* return DENY */
@ -325,7 +325,7 @@ int bpf_devices_supported(void) {
return supported = 1; return supported = 1;
} }
static int whitelist_device_pattern( static int allow_list_device_pattern(
BPFProgram *prog, BPFProgram *prog,
const char *path, const char *path,
char type, char type,
@ -340,11 +340,11 @@ static int whitelist_device_pattern(
return 0; return 0;
if (maj && min) if (maj && min)
return bpf_prog_whitelist_device(prog, type, *maj, *min, acc); return bpf_prog_allow_list_device(prog, type, *maj, *min, acc);
else if (maj) else if (maj)
return bpf_prog_whitelist_major(prog, type, *maj, acc); return bpf_prog_allow_list_major(prog, type, *maj, acc);
else else
return bpf_prog_whitelist_class(prog, type, acc); return bpf_prog_allow_list_class(prog, type, acc);
} else { } else {
char buf[2+DECIMAL_STR_MAX(unsigned)*2+2+4]; char buf[2+DECIMAL_STR_MAX(unsigned)*2+2+4];
@ -369,7 +369,7 @@ static int whitelist_device_pattern(
} }
} }
int bpf_devices_whitelist_device( int bpf_devices_allow_list_device(
BPFProgram *prog, BPFProgram *prog,
const char *path, const char *path,
const char *node, const char *node,
@ -405,10 +405,10 @@ int bpf_devices_whitelist_device(
} }
unsigned maj = major(rdev), min = minor(rdev); unsigned maj = major(rdev), min = minor(rdev);
return whitelist_device_pattern(prog, path, S_ISCHR(mode) ? 'c' : 'b', &maj, &min, acc); return allow_list_device_pattern(prog, path, S_ISCHR(mode) ? 'c' : 'b', &maj, &min, acc);
} }
int bpf_devices_whitelist_major( int bpf_devices_allow_list_major(
BPFProgram *prog, BPFProgram *prog,
const char *path, const char *path,
const char *name, const char *name,
@ -424,12 +424,12 @@ int bpf_devices_whitelist_major(
if (streq(name, "*")) if (streq(name, "*"))
/* If the name is a wildcard, then apply this list to all devices of this type */ /* If the name is a wildcard, then apply this list to all devices of this type */
return whitelist_device_pattern(prog, path, type, NULL, NULL, acc); return allow_list_device_pattern(prog, path, type, NULL, NULL, acc);
if (safe_atou(name, &maj) >= 0 && DEVICE_MAJOR_VALID(maj)) if (safe_atou(name, &maj) >= 0 && DEVICE_MAJOR_VALID(maj))
/* The name is numeric and suitable as major. In that case, let's take its major, and create /* The name is numeric and suitable as major. In that case, let's take its major, and create
* the entry directly. */ * the entry directly. */
return whitelist_device_pattern(prog, path, type, &maj, NULL, acc); return allow_list_device_pattern(prog, path, type, &maj, NULL, acc);
_cleanup_fclose_ FILE *f = NULL; _cleanup_fclose_ FILE *f = NULL;
bool good = false, any = false; bool good = false, any = false;
@ -486,17 +486,17 @@ int bpf_devices_whitelist_major(
continue; continue;
any = true; any = true;
(void) whitelist_device_pattern(prog, path, type, &maj, NULL, acc); (void) allow_list_device_pattern(prog, path, type, &maj, NULL, acc);
} }
if (!any) if (!any)
return log_debug_errno(SYNTHETIC_ERRNO(ENOENT), return log_debug_errno(SYNTHETIC_ERRNO(ENOENT),
"Device whitelist pattern \"%s\" did not match anything.", name); "Device allow list pattern \"%s\" did not match anything.", name);
return 0; return 0;
} }
int bpf_devices_whitelist_static( int bpf_devices_allow_list_static(
BPFProgram *prog, BPFProgram *prog,
const char *path) { const char *path) {
@ -515,13 +515,13 @@ int bpf_devices_whitelist_static(
const char *node, *acc; const char *node, *acc;
NULSTR_FOREACH_PAIR(node, acc, auto_devices) { NULSTR_FOREACH_PAIR(node, acc, auto_devices) {
k = bpf_devices_whitelist_device(prog, path, node, acc); k = bpf_devices_allow_list_device(prog, path, node, acc);
if (r >= 0 && k < 0) if (r >= 0 && k < 0)
r = k; r = k;
} }
/* PTS (/dev/pts) devices may not be duplicated, but accessed */ /* PTS (/dev/pts) devices may not be duplicated, but accessed */
k = bpf_devices_whitelist_major(prog, path, "pts", 'c', "rw"); k = bpf_devices_allow_list_major(prog, path, "pts", 'c', "rw");
if (r >= 0 && k < 0) if (r >= 0 && k < 0)
r = k; r = k;

10
src/core/bpf-devices.h
View file

@ -7,15 +7,15 @@
typedef struct BPFProgram BPFProgram; typedef struct BPFProgram BPFProgram;
int bpf_devices_cgroup_init(BPFProgram **ret, CGroupDevicePolicy policy, bool whitelist); int bpf_devices_cgroup_init(BPFProgram **ret, CGroupDevicePolicy policy, bool allow_list);
int bpf_devices_apply_policy( int bpf_devices_apply_policy(
BPFProgram *prog, BPFProgram *prog,
CGroupDevicePolicy policy, CGroupDevicePolicy policy,
bool whitelist, bool allow_list,
const char *cgroup_path, const char *cgroup_path,
BPFProgram **prog_installed); BPFProgram **prog_installed);
int bpf_devices_supported(void); int bpf_devices_supported(void);
int bpf_devices_whitelist_device(BPFProgram *prog, const char *path, const char *node, const char *acc); int bpf_devices_allow_list_device(BPFProgram *prog, const char *path, const char *node, const char *acc);
int bpf_devices_whitelist_major(BPFProgram *prog, const char *path, const char *name, char type, const char *acc); int bpf_devices_allow_list_major(BPFProgram *prog, const char *path, const char *name, char type, const char *acc);
int bpf_devices_whitelist_static(BPFProgram *prog, const char *path); int bpf_devices_allow_list_static(BPFProgram *prog, const char *path);

16
src/core/cgroup.c
View file

@ -990,12 +990,12 @@ static int cgroup_apply_devices(Unit *u) {
"Failed to reset devices.allow/devices.deny: %m"); "Failed to reset devices.allow/devices.deny: %m");
} }
bool whitelist_static = policy == CGROUP_DEVICE_POLICY_CLOSED || bool allow_list_static = policy == CGROUP_DEVICE_POLICY_CLOSED ||
(policy == CGROUP_DEVICE_POLICY_AUTO && c->device_allow); (policy == CGROUP_DEVICE_POLICY_AUTO && c->device_allow);
if (whitelist_static) if (allow_list_static)
(void) bpf_devices_whitelist_static(prog, path); (void) bpf_devices_allow_list_static(prog, path);
bool any = whitelist_static; bool any = allow_list_static;
LIST_FOREACH(device_allow, a, c->device_allow) { LIST_FOREACH(device_allow, a, c->device_allow) {
char acc[4], *val; char acc[4], *val;
unsigned k = 0; unsigned k = 0;
@ -1011,11 +1011,11 @@ static int cgroup_apply_devices(Unit *u) {
acc[k++] = 0; acc[k++] = 0;
if (path_startswith(a->path, "/dev/")) if (path_startswith(a->path, "/dev/"))
r = bpf_devices_whitelist_device(prog, path, a->path, acc); r = bpf_devices_allow_list_device(prog, path, a->path, acc);
else if ((val = startswith(a->path, "block-"))) else if ((val = startswith(a->path, "block-")))
r = bpf_devices_whitelist_major(prog, path, val, 'b', acc); r = bpf_devices_allow_list_major(prog, path, val, 'b', acc);
else if ((val = startswith(a->path, "char-"))) else if ((val = startswith(a->path, "char-")))
r = bpf_devices_whitelist_major(prog, path, val, 'c', acc); r = bpf_devices_allow_list_major(prog, path, val, 'c', acc);
else { else {
log_unit_debug(u, "Ignoring device '%s' while writing cgroup attribute.", a->path); log_unit_debug(u, "Ignoring device '%s' while writing cgroup attribute.", a->path);
continue; continue;
@ -1029,7 +1029,7 @@ static int cgroup_apply_devices(Unit *u) {
log_unit_warning_errno(u, SYNTHETIC_ERRNO(ENODEV), "No devices matched by device filter."); log_unit_warning_errno(u, SYNTHETIC_ERRNO(ENODEV), "No devices matched by device filter.");
/* The kernel verifier would reject a program we would build with the normal intro and outro /* The kernel verifier would reject a program we would build with the normal intro and outro
but no whitelisting rules (outro would contain an unreachable instruction for successful but no allow-listing rules (outro would contain an unreachable instruction for successful
return). */ return). */
policy = CGROUP_DEVICE_POLICY_STRICT; policy = CGROUP_DEVICE_POLICY_STRICT;
} }

34
src/core/dbus-execute.c
View file

@ -370,7 +370,7 @@ static int property_get_syscall_filter(
if (r < 0) if (r < 0)
return r; return r;
r = sd_bus_message_append(reply, "b", c->syscall_whitelist); r = sd_bus_message_append(reply, "b", c->syscall_allow_list);
if (r < 0) if (r < 0)
return r; return r;
@ -536,7 +536,7 @@ static int property_get_address_families(
if (r < 0) if (r < 0)
return r; return r;
r = sd_bus_message_append(reply, "b", c->address_families_whitelist); r = sd_bus_message_append(reply, "b", c->address_families_allow_list);
if (r < 0) if (r < 0)
return r; return r;
@ -1672,14 +1672,14 @@ int bus_exec_context_set_transient_property(
return bus_set_transient_errno(u, name, &c->syscall_errno, message, flags, error); return bus_set_transient_errno(u, name, &c->syscall_errno, message, flags, error);
if (streq(name, "SystemCallFilter")) { if (streq(name, "SystemCallFilter")) {
int whitelist; int allow_list;
_cleanup_strv_free_ char **l = NULL; _cleanup_strv_free_ char **l = NULL;
r = sd_bus_message_enter_container(message, 'r', "bas"); r = sd_bus_message_enter_container(message, 'r', "bas");
if (r < 0) if (r < 0)
return r; return r;
r = sd_bus_message_read(message, "b", &whitelist); r = sd_bus_message_read(message, "b", &allow_list);
if (r < 0) if (r < 0)
return r; return r;
@ -1693,11 +1693,11 @@ int bus_exec_context_set_transient_property(
if (!UNIT_WRITE_FLAGS_NOOP(flags)) { if (!UNIT_WRITE_FLAGS_NOOP(flags)) {
_cleanup_free_ char *joined = NULL; _cleanup_free_ char *joined = NULL;
SeccompParseFlags invert_flag = whitelist ? 0 : SECCOMP_PARSE_INVERT; SeccompParseFlags invert_flag = allow_list ? 0 : SECCOMP_PARSE_INVERT;
char **s; char **s;
if (strv_isempty(l)) { if (strv_isempty(l)) {
c->syscall_whitelist = false; c->syscall_allow_list = false;
c->syscall_filter = hashmap_free(c->syscall_filter); c->syscall_filter = hashmap_free(c->syscall_filter);
unit_write_settingf(u, flags, name, "SystemCallFilter="); unit_write_settingf(u, flags, name, "SystemCallFilter=");
@ -1709,14 +1709,14 @@ int bus_exec_context_set_transient_property(
if (!c->syscall_filter) if (!c->syscall_filter)
return log_oom(); return log_oom();
c->syscall_whitelist = whitelist; c->syscall_allow_list = allow_list;
if (c->syscall_whitelist) { if (c->syscall_allow_list) {
r = seccomp_parse_syscall_filter("@default", r = seccomp_parse_syscall_filter("@default",
-1, -1,
c->syscall_filter, c->syscall_filter,
SECCOMP_PARSE_PERMISSIVE | SECCOMP_PARSE_PERMISSIVE |
SECCOMP_PARSE_WHITELIST | invert_flag, SECCOMP_PARSE_ALLOW_LIST | invert_flag,
u->id, u->id,
NULL, 0); NULL, 0);
if (r < 0) if (r < 0)
@ -1737,7 +1737,7 @@ int bus_exec_context_set_transient_property(
c->syscall_filter, c->syscall_filter,
SECCOMP_PARSE_LOG | SECCOMP_PARSE_PERMISSIVE | SECCOMP_PARSE_LOG | SECCOMP_PARSE_PERMISSIVE |
invert_flag | invert_flag |
(c->syscall_whitelist ? SECCOMP_PARSE_WHITELIST : 0), (c->syscall_allow_list ? SECCOMP_PARSE_ALLOW_LIST : 0),
u->id, u->id,
NULL, 0); NULL, 0);
if (r < 0) if (r < 0)
@ -1748,7 +1748,7 @@ int bus_exec_context_set_transient_property(
if (!joined) if (!joined)
return -ENOMEM; return -ENOMEM;
unit_write_settingf(u, flags, name, "SystemCallFilter=%s%s", whitelist ? "" : "~", joined); unit_write_settingf(u, flags, name, "SystemCallFilter=%s%s", allow_list ? "" : "~", joined);
} }
return 1; return 1;
@ -1792,14 +1792,14 @@ int bus_exec_context_set_transient_property(
return 1; return 1;
} else if (streq(name, "RestrictAddressFamilies")) { } else if (streq(name, "RestrictAddressFamilies")) {
int whitelist; int allow_list;
_cleanup_strv_free_ char **l = NULL; _cleanup_strv_free_ char **l = NULL;
r = sd_bus_message_enter_container(message, 'r', "bas"); r = sd_bus_message_enter_container(message, 'r', "bas");
if (r < 0) if (r < 0)
return r; return r;
r = sd_bus_message_read(message, "b", &whitelist); r = sd_bus_message_read(message, "b", &allow_list);
if (r < 0) if (r < 0)
return r; return r;
@ -1816,7 +1816,7 @@ int bus_exec_context_set_transient_property(
char **s; char **s;
if (strv_isempty(l)) { if (strv_isempty(l)) {
c->address_families_whitelist = false; c->address_families_allow_list = false;
c->address_families = set_free(c->address_families); c->address_families = set_free(c->address_families);
unit_write_settingf(u, flags, name, "RestrictAddressFamilies="); unit_write_settingf(u, flags, name, "RestrictAddressFamilies=");
@ -1828,7 +1828,7 @@ int bus_exec_context_set_transient_property(
if (!c->address_families) if (!c->address_families)
return log_oom(); return log_oom();
c->address_families_whitelist = whitelist; c->address_families_allow_list = allow_list;
} }
STRV_FOREACH(s, l) { STRV_FOREACH(s, l) {
@ -1838,7 +1838,7 @@ int bus_exec_context_set_transient_property(
if (af < 0) if (af < 0)
return af; return af;
if (whitelist == c->address_families_whitelist) { if (allow_list == c->address_families_allow_list) {
r = set_put(c->address_families, INT_TO_PTR(af)); r = set_put(c->address_families, INT_TO_PTR(af));
if (r < 0) if (r < 0)
return r; return r;
@ -1850,7 +1850,7 @@ int bus_exec_context_set_transient_property(
if (!joined) if (!joined)
return -ENOMEM; return -ENOMEM;
unit_write_settingf(u, flags, name, "RestrictAddressFamilies=%s%s", whitelist ? "" : "~", joined); unit_write_settingf(u, flags, name, "RestrictAddressFamilies=%s%s", allow_list ? "" : "~", joined);
} }
return 1; return 1;

12
src/core/execute.c
View file

@ -1380,14 +1380,14 @@ static void rename_process_from_path(const char *path) {
static bool context_has_address_families(const ExecContext *c) { static bool context_has_address_families(const ExecContext *c) {
assert(c); assert(c);
return c->address_families_whitelist || return c->address_families_allow_list ||
!set_isempty(c->address_families); !set_isempty(c->address_families);
} }
static bool context_has_syscall_filters(const ExecContext *c) { static bool context_has_syscall_filters(const ExecContext *c) {
assert(c); assert(c);
return c->syscall_whitelist || return c->syscall_allow_list ||
!hashmap_isempty(c->syscall_filter); !hashmap_isempty(c->syscall_filter);
} }
@ -1443,7 +1443,7 @@ static int apply_syscall_filter(const Unit* u, const ExecContext *c, bool needs_
negative_action = c->syscall_errno == 0 ? scmp_act_kill_process() : SCMP_ACT_ERRNO(c->syscall_errno); negative_action = c->syscall_errno == 0 ? scmp_act_kill_process() : SCMP_ACT_ERRNO(c->syscall_errno);
if (c->syscall_whitelist) { if (c->syscall_allow_list) {
default_action = negative_action; default_action = negative_action;
action = SCMP_ACT_ALLOW; action = SCMP_ACT_ALLOW;
} else { } else {
@ -1452,7 +1452,7 @@ static int apply_syscall_filter(const Unit* u, const ExecContext *c, bool needs_
} }
if (needs_ambient_hack) { if (needs_ambient_hack) {
r = seccomp_filter_set_add(c->syscall_filter, c->syscall_whitelist, syscall_filter_sets + SYSCALL_FILTER_SET_SETUID); r = seccomp_filter_set_add(c->syscall_filter, c->syscall_allow_list, syscall_filter_sets + SYSCALL_FILTER_SET_SETUID);
if (r < 0) if (r < 0)
return r; return r;
} }
@ -1483,7 +1483,7 @@ static int apply_address_families(const Unit* u, const ExecContext *c) {
if (skip_seccomp_unavailable(u, "RestrictAddressFamilies=")) if (skip_seccomp_unavailable(u, "RestrictAddressFamilies="))
return 0; return 0;
return seccomp_restrict_address_families(c->address_families, c->address_families_whitelist); return seccomp_restrict_address_families(c->address_families, c->address_families_allow_list);
} }
static int apply_memory_deny_write_execute(const Unit* u, const ExecContext *c) { static int apply_memory_deny_write_execute(const Unit* u, const ExecContext *c) {
@ -4918,7 +4918,7 @@ void exec_context_dump(const ExecContext *c, FILE* f, const char *prefix) {
"%sSystemCallFilter: ", "%sSystemCallFilter: ",
prefix); prefix);
if (!c->syscall_whitelist) if (!c->syscall_allow_list)
fputc('~', f); fputc('~', f);
#if HAVE_SECCOMP #if HAVE_SECCOMP

4
src/core/execute.h
View file

@ -287,9 +287,9 @@ struct ExecContext {
Hashmap *syscall_filter; Hashmap *syscall_filter;
Set *syscall_archs; Set *syscall_archs;
int syscall_errno; int syscall_errno;
bool syscall_whitelist:1; bool syscall_allow_list:1;
bool address_families_whitelist:1; bool address_families_allow_list:1;
Set *address_families; Set *address_families;
char *network_namespace_path; char *network_namespace_path;

18
src/core/load-fragment.c
View file

@ -3017,7 +3017,7 @@ int config_parse_syscall_filter(
if (isempty(rvalue)) { if (isempty(rvalue)) {
/* Empty assignment resets the list */ /* Empty assignment resets the list */
c->syscall_filter = hashmap_free(c->syscall_filter); c->syscall_filter = hashmap_free(c->syscall_filter);
c->syscall_whitelist = false; c->syscall_allow_list = false;
return 0; return 0;
} }
@ -3033,15 +3033,15 @@ int config_parse_syscall_filter(
if (invert) if (invert)
/* Allow everything but the ones listed */ /* Allow everything but the ones listed */
c->syscall_whitelist = false; c->syscall_allow_list = false;
else { else {
/* Allow nothing but the ones listed */ /* Allow nothing but the ones listed */
c->syscall_whitelist = true; c->syscall_allow_list = true;
/* Accept default syscalls if we are on a whitelist */ /* Accept default syscalls if we are on a allow_list */
r = seccomp_parse_syscall_filter( r = seccomp_parse_syscall_filter(
"@default", -1, c->syscall_filter, "@default", -1, c->syscall_filter,
SECCOMP_PARSE_PERMISSIVE|SECCOMP_PARSE_WHITELIST, SECCOMP_PARSE_PERMISSIVE|SECCOMP_PARSE_ALLOW_LIST,
unit, unit,
NULL, 0); NULL, 0);
if (r < 0) if (r < 0)
@ -3074,7 +3074,7 @@ int config_parse_syscall_filter(
name, num, c->syscall_filter, name, num, c->syscall_filter,
SECCOMP_PARSE_LOG|SECCOMP_PARSE_PERMISSIVE| SECCOMP_PARSE_LOG|SECCOMP_PARSE_PERMISSIVE|
(invert ? SECCOMP_PARSE_INVERT : 0)| (invert ? SECCOMP_PARSE_INVERT : 0)|
(c->syscall_whitelist ? SECCOMP_PARSE_WHITELIST : 0), (c->syscall_allow_list ? SECCOMP_PARSE_ALLOW_LIST : 0),
unit, filename, line); unit, filename, line);
if (r < 0) if (r < 0)
return r; return r;
@ -3189,7 +3189,7 @@ int config_parse_address_families(
if (isempty(rvalue)) { if (isempty(rvalue)) {
/* Empty assignment resets the list */ /* Empty assignment resets the list */
c->address_families = set_free(c->address_families); c->address_families = set_free(c->address_families);
c->address_families_whitelist = false; c->address_families_allow_list = false;
return 0; return 0;
} }
@ -3203,7 +3203,7 @@ int config_parse_address_families(
if (!c->address_families) if (!c->address_families)
return log_oom(); return log_oom();
c->address_families_whitelist = !invert; c->address_families_allow_list = !invert;
} }
for (p = rvalue;;) { for (p = rvalue;;) {
@ -3231,7 +3231,7 @@ int config_parse_address_families(
/* If we previously wanted to forbid an address family and now /* If we previously wanted to forbid an address family and now
* we want to allow it, then just remove it from the list. * we want to allow it, then just remove it from the list.
*/ */
if (!invert == c->address_families_whitelist) { if (!invert == c->address_families_allow_list) {
r = set_put(c->address_families, INT_TO_PTR(af)); r = set_put(c->address_families, INT_TO_PTR(af));
if (r < 0) if (r < 0)
return log_oom(); return log_oom();

18
src/core/namespace.c
View file

@ -1067,7 +1067,7 @@ static int apply_mount(
return 0; return 0;
} }
static int make_read_only(const MountEntry *m, char **blacklist, FILE *proc_self_mountinfo) { static int make_read_only(const MountEntry *m, char **deny_list, FILE *proc_self_mountinfo) {
unsigned long new_flags = 0, flags_mask = 0; unsigned long new_flags = 0, flags_mask = 0;
bool submounts = false; bool submounts = false;
int r = 0; int r = 0;
@ -1096,7 +1096,7 @@ static int make_read_only(const MountEntry *m, char **blacklist, FILE *proc_self
mount_entry_read_only(m) && mount_entry_read_only(m) &&
!IN_SET(m->mode, EMPTY_DIR, TMPFS); !IN_SET(m->mode, EMPTY_DIR, TMPFS);
if (submounts) if (submounts)
r = bind_remount_recursive_with_mountinfo(mount_entry_path(m), new_flags, flags_mask, blacklist, proc_self_mountinfo); r = bind_remount_recursive_with_mountinfo(mount_entry_path(m), new_flags, flags_mask, deny_list, proc_self_mountinfo);
else else
r = bind_remount_one_with_mountinfo(mount_entry_path(m), new_flags, flags_mask, proc_self_mountinfo); r = bind_remount_one_with_mountinfo(mount_entry_path(m), new_flags, flags_mask, proc_self_mountinfo);
@ -1538,7 +1538,7 @@ int setup_namespace(
if (n_mounts > 0) { if (n_mounts > 0) {
_cleanup_fclose_ FILE *proc_self_mountinfo = NULL; _cleanup_fclose_ FILE *proc_self_mountinfo = NULL;
_cleanup_free_ char **blacklist = NULL; _cleanup_free_ char **deny_list = NULL;
size_t j; size_t j;
/* Open /proc/self/mountinfo now as it may become unavailable if we mount anything on top of /proc. /* Open /proc/self/mountinfo now as it may become unavailable if we mount anything on top of /proc.
@ -1591,19 +1591,19 @@ int setup_namespace(
normalize_mounts(root, mounts, &n_mounts); normalize_mounts(root, mounts, &n_mounts);
} }
/* Create a blacklist we can pass to bind_mount_recursive() */ /* Create a deny list we can pass to bind_mount_recursive() */
blacklist = new(char*, n_mounts+1); deny_list = new(char*, n_mounts+1);
if (!blacklist) { if (!deny_list) {
r = -ENOMEM; r = -ENOMEM;
goto finish; goto finish;
} }
for (j = 0; j < n_mounts; j++) for (j = 0; j < n_mounts; j++)
blacklist[j] = (char*) mount_entry_path(mounts+j); deny_list[j] = (char*) mount_entry_path(mounts+j);
blacklist[j] = NULL; deny_list[j] = NULL;
/* Second round, flip the ro bits if necessary. */ /* Second round, flip the ro bits if necessary. */
for (m = mounts; m < mounts + n_mounts; ++m) { for (m = mounts; m < mounts + n_mounts; ++m) {
r = make_read_only(m, blacklist, proc_self_mountinfo); r = make_read_only(m, deny_list, proc_self_mountinfo);
if (r < 0) { if (r < 0) {
if (error_path && mount_entry_path(m)) if (error_path && mount_entry_path(m))
*error_path = strdup(mount_entry_path(m)); *error_path = strdup(mount_entry_path(m));

8
src/cryptsetup/cryptsetup-generator.c
View file

@ -39,7 +39,7 @@ static bool arg_enabled = true;
static bool arg_read_crypttab = true; static bool arg_read_crypttab = true;
static const char *arg_crypttab = NULL; static const char *arg_crypttab = NULL;
static const char *arg_runtime_directory = NULL; static const char *arg_runtime_directory = NULL;
static bool arg_whitelist = false; static bool arg_allow_list = false;
static Hashmap *arg_disks = NULL; static Hashmap *arg_disks = NULL;
static char *arg_default_options = NULL; static char *arg_default_options = NULL;
static char *arg_default_keyfile = NULL; static char *arg_default_keyfile = NULL;
@ -495,7 +495,7 @@ static int parse_proc_cmdline_item(const char *key, const char *value, void *dat
if (!d) if (!d)
return log_oom(); return log_oom();
d->create = arg_whitelist = true; d->create = arg_allow_list = true;
} else if (streq(key, "luks.options")) { } else if (streq(key, "luks.options")) {
@ -559,7 +559,7 @@ static int parse_proc_cmdline_item(const char *key, const char *value, void *dat
if (!d) if (!d)
return log_oom(); return log_oom();
d->create = arg_whitelist = true; d->create = arg_allow_list = true;
free_and_replace(d->name, uuid_value); free_and_replace(d->name, uuid_value);
} else } else
@ -622,7 +622,7 @@ static int add_crypttab_devices(void) {
if (uuid) if (uuid)
d = hashmap_get(arg_disks, uuid); d = hashmap_get(arg_disks, uuid);
if (arg_whitelist && !d) { if (arg_allow_list && !d) {
log_info("Not creating device '%s' because it was not specified on the kernel command line.", name); log_info("Not creating device '%s' because it was not specified on the kernel command line.", name);
continue; continue;
} }

8
src/libudev/libudev-util.c
View file

@ -154,8 +154,8 @@ size_t util_replace_whitespace(const char *str, char *to, size_t len) {
return j; return j;
} }
/* allow chars in whitelist, plain ascii, hex-escaping and valid utf8 */ /* allow chars in allow list, plain ascii, hex-escaping and valid utf8 */
size_t util_replace_chars(char *str, const char *white) { size_t util_replace_chars(char *str, const char *allow) {
size_t i = 0, replaced = 0; size_t i = 0, replaced = 0;
assert(str); assert(str);
@ -163,7 +163,7 @@ size_t util_replace_chars(char *str, const char *white) {
while (str[i] != '\0') { while (str[i] != '\0') {
int len; int len;
if (whitelisted_char_for_devnode(str[i], white)) { if (allow_listed_char_for_devnode(str[i], allow)) {
i++; i++;
continue; continue;
} }
@ -182,7 +182,7 @@ size_t util_replace_chars(char *str, const char *white) {
} }
/* if space is allowed, replace whitespace with ordinary space */ /* if space is allowed, replace whitespace with ordinary space */
if (isspace(str[i]) && white && strchr(white, ' ')) { if (isspace(str[i]) && allow && strchr(allow, ' ')) {
str[i] = ' '; str[i] = ' ';
i++; i++;
replaced++; replaced++;

8
src/login/logind-core.c
View file

@ -601,10 +601,10 @@ static int manager_count_external_displays(Manager *m) {
if (sd_device_get_sysname(d, &nn) < 0) if (sd_device_get_sysname(d, &nn) < 0)
continue; continue;
/* Ignore internal displays: the type is encoded in the sysfs name, as the second dash separated item /* Ignore internal displays: the type is encoded in the sysfs name, as the second dash
* (the first is the card name, the last the connector number). We implement a blacklist of external * separated item (the first is the card name, the last the connector number). We implement a
* displays here, rather than a whitelist of internal ones, to ensure we don't block suspends too * deny list of external displays here, rather than an allow list of internal ones, to ensure
* eagerly. */ * we don't block suspends too eagerly. */
dash = strchr(nn, '-'); dash = strchr(nn, '-');
if (!dash) if (!dash)
continue; continue;

20
src/network/networkd-dhcp4.c
View file

@ -1051,7 +1051,7 @@ static int dhcp_lease_ip_change(sd_dhcp_client *client, Link *link) {
return 0; return 0;
} }
static int dhcp_server_is_black_listed(Link *link, sd_dhcp_client *client) { static int dhcp_server_is_deny_listed(Link *link, sd_dhcp_client *client) {
sd_dhcp_lease *lease; sd_dhcp_lease *lease;
struct in_addr addr; struct in_addr addr;
int r; int r;
@ -1068,10 +1068,10 @@ static int dhcp_server_is_black_listed(Link *link, sd_dhcp_client *client) {
if (r < 0) if (r < 0)
return log_link_debug_errno(link, r, "Failed to get DHCP server ip address: %m"); return log_link_debug_errno(link, r, "Failed to get DHCP server ip address: %m");
if (set_contains(link->network->dhcp_black_listed_ip, UINT32_TO_PTR(addr.s_addr))) { if (set_contains(link->network->dhcp_deny_listed_ip, UINT32_TO_PTR(addr.s_addr))) {
log_struct(LOG_DEBUG, log_struct(LOG_DEBUG,
LOG_LINK_INTERFACE(link), LOG_LINK_INTERFACE(link),
LOG_LINK_MESSAGE(link, "DHCPv4 ip '%u.%u.%u.%u' found in black listed ip addresses, ignoring offer", LOG_LINK_MESSAGE(link, "DHCPv4 ip '%u.%u.%u.%u' found in deny-listed ip addresses, ignoring offer",
ADDRESS_FMT_VAL(addr))); ADDRESS_FMT_VAL(addr)));
return true; return true;
} }
@ -1163,7 +1163,7 @@ static int dhcp4_handler(sd_dhcp_client *client, int event, void *userdata) {
} }
break; break;
case SD_DHCP_CLIENT_EVENT_SELECTING: case SD_DHCP_CLIENT_EVENT_SELECTING:
r = dhcp_server_is_black_listed(link, client); r = dhcp_server_is_deny_listed(link, client);
if (r < 0) if (r < 0)
return r; return r;
if (r != 0) if (r != 0)
@ -1551,7 +1551,7 @@ int config_parse_dhcp_max_attempts(
return 0; return 0;
} }
int config_parse_dhcp_black_listed_ip_address( int config_parse_dhcp_deny_listed_ip_address(
const char *unit, const char *unit,
const char *filename, const char *filename,
unsigned line, unsigned line,
@ -1572,7 +1572,7 @@ int config_parse_dhcp_black_listed_ip_address(
assert(data); assert(data);
if (isempty(rvalue)) { if (isempty(rvalue)) {
network->dhcp_black_listed_ip = set_free(network->dhcp_black_listed_ip); network->dhcp_deny_listed_ip = set_free(network->dhcp_deny_listed_ip);
return 0; return 0;
} }
@ -1583,7 +1583,7 @@ int config_parse_dhcp_black_listed_ip_address(
r = extract_first_word(&p, &n, NULL, 0); r = extract_first_word(&p, &n, NULL, 0);
if (r < 0) { if (r < 0) {
log_syntax(unit, LOG_ERR, filename, line, r, log_syntax(unit, LOG_ERR, filename, line, r,
"Failed to parse DHCP black listed ip address, ignoring assignment: %s", "Failed to parse DHCP deny-listed IP address, ignoring assignment: %s",
rvalue); rvalue);
return 0; return 0;
} }
@ -1593,14 +1593,14 @@ int config_parse_dhcp_black_listed_ip_address(
r = in_addr_from_string(AF_INET, n, &ip); r = in_addr_from_string(AF_INET, n, &ip);
if (r < 0) { if (r < 0) {
log_syntax(unit, LOG_ERR, filename, line, r, log_syntax(unit, LOG_ERR, filename, line, r,
"DHCP black listed ip address is invalid, ignoring assignment: %s", n); "DHCP deny-listed IP address is invalid, ignoring assignment: %s", n);
continue; continue;
} }
r = set_ensure_put(&network->dhcp_black_listed_ip, NULL, UINT32_TO_PTR(ip.in.s_addr)); r = set_ensure_put(&network->dhcp_deny_listed_ip, NULL, UINT32_TO_PTR(ip.in.s_addr));
if (r < 0) if (r < 0)
log_syntax(unit, LOG_ERR, filename, line, r, log_syntax(unit, LOG_ERR, filename, line, r,
"Failed to store DHCP black listed ip address '%s', ignoring assignment: %m", n); "Failed to store DHCP deny-listed IP address '%s', ignoring assignment: %m", n);
} }
return 0; return 0;

2
src/network/networkd-dhcp4.h
View file

@ -23,7 +23,7 @@ int dhcp4_set_client_identifier(Link *link);
int dhcp4_set_promote_secondaries(Link *link); int dhcp4_set_promote_secondaries(Link *link);
CONFIG_PARSER_PROTOTYPE(config_parse_dhcp_client_identifier); CONFIG_PARSER_PROTOTYPE(config_parse_dhcp_client_identifier);
CONFIG_PARSER_PROTOTYPE(config_parse_dhcp_black_listed_ip_address); CONFIG_PARSER_PROTOTYPE(config_parse_dhcp_deny_listed_ip_address);
CONFIG_PARSER_PROTOTYPE(config_parse_dhcp_max_attempts); CONFIG_PARSER_PROTOTYPE(config_parse_dhcp_max_attempts);
CONFIG_PARSER_PROTOTYPE(config_parse_dhcp_ip_service_type); CONFIG_PARSER_PROTOTYPE(config_parse_dhcp_ip_service_type);
CONFIG_PARSER_PROTOTYPE(config_parse_dhcp_mud_url); CONFIG_PARSER_PROTOTYPE(config_parse_dhcp_mud_url);

16
src/network/networkd-ndisc.c
View file

@ -723,12 +723,12 @@ static int ndisc_router_process_options(Link *link, sd_ndisc_router *rt) {
if (r < 0) if (r < 0)
return log_link_error_errno(link, r, "Failed to get prefix address: %m"); return log_link_error_errno(link, r, "Failed to get prefix address: %m");
if (set_contains(link->network->ndisc_black_listed_prefix, &a.in6)) { if (set_contains(link->network->ndisc_deny_listed_prefix, &a.in6)) {
if (DEBUG_LOGGING) { if (DEBUG_LOGGING) {
_cleanup_free_ char *b = NULL; _cleanup_free_ char *b = NULL;
(void) in_addr_to_string(AF_INET6, &a, &b); (void) in_addr_to_string(AF_INET6, &a, &b);
log_link_debug(link, "Prefix '%s' is black listed, ignoring", strna(b)); log_link_debug(link, "Prefix '%s' is deny-listed, ignoring", strna(b));
} }
break; break;
@ -915,7 +915,7 @@ DEFINE_HASH_OPS_WITH_VALUE_DESTRUCTOR(
IPv6Token, IPv6Token,
free); free);
int config_parse_ndisc_black_listed_prefix( int config_parse_ndisc_deny_listed_prefix(
const char *unit, const char *unit,
const char *filename, const char *filename,
unsigned line, unsigned line,
@ -937,7 +937,7 @@ int config_parse_ndisc_black_listed_prefix(
assert(data); assert(data);
if (isempty(rvalue)) { if (isempty(rvalue)) {
network->ndisc_black_listed_prefix = set_free_free(network->ndisc_black_listed_prefix); network->ndisc_deny_listed_prefix = set_free_free(network->ndisc_deny_listed_prefix);
return 0; return 0;
} }
@ -949,7 +949,7 @@ int config_parse_ndisc_black_listed_prefix(
r = extract_first_word(&p, &n, NULL, 0); r = extract_first_word(&p, &n, NULL, 0);
if (r < 0) { if (r < 0) {
log_syntax(unit, LOG_ERR, filename, line, r, log_syntax(unit, LOG_ERR, filename, line, r,
"Failed to parse NDISC black listed prefix, ignoring assignment: %s", "Failed to parse NDISC deny-listed prefix, ignoring assignment: %s",
rvalue); rvalue);
return 0; return 0;
} }
@ -959,18 +959,18 @@ int config_parse_ndisc_black_listed_prefix(
r = in_addr_from_string(AF_INET6, n, &ip); r = in_addr_from_string(AF_INET6, n, &ip);
if (r < 0) { if (r < 0) {
log_syntax(unit, LOG_ERR, filename, line, r, log_syntax(unit, LOG_ERR, filename, line, r,
"NDISC black listed prefix is invalid, ignoring assignment: %s", n); "NDISC deny-listed prefix is invalid, ignoring assignment: %s", n);
continue; continue;
} }
if (set_contains(network->ndisc_black_listed_prefix, &ip.in6)) if (set_contains(network->ndisc_deny_listed_prefix, &ip.in6))
continue; continue;
a = newdup(struct in6_addr, &ip.in6, 1); a = newdup(struct in6_addr, &ip.in6, 1);
if (!a) if (!a)
return log_oom(); return log_oom();
r = set_ensure_consume(&network->ndisc_black_listed_prefix, &in6_addr_hash_ops, TAKE_PTR(a)); r = set_ensure_consume(&network->ndisc_deny_listed_prefix, &in6_addr_hash_ops, TAKE_PTR(a));
if (r < 0) if (r < 0)
return log_oom(); return log_oom();
} }

2
src/network/networkd-ndisc.h
View file

@ -51,7 +51,7 @@ int ndisc_configure(Link *link);
void ndisc_vacuum(Link *link); void ndisc_vacuum(Link *link);
void ndisc_flush(Link *link); void ndisc_flush(Link *link);
CONFIG_PARSER_PROTOTYPE(config_parse_ndisc_black_listed_prefix); CONFIG_PARSER_PROTOTYPE(config_parse_ndisc_deny_listed_prefix);
CONFIG_PARSER_PROTOTYPE(config_parse_address_generation_type); CONFIG_PARSER_PROTOTYPE(config_parse_address_generation_type);
CONFIG_PARSER_PROTOTYPE(config_parse_ipv6_accept_ra_start_dhcp6_client); CONFIG_PARSER_PROTOTYPE(config_parse_ipv6_accept_ra_start_dhcp6_client);

6
src/network/networkd-network-gperf.gperf
View file

@ -187,7 +187,8 @@ DHCPv4.IAID, config_parse_iaid,
DHCPv4.ListenPort, config_parse_uint16, 0, offsetof(Network, dhcp_client_port) DHCPv4.ListenPort, config_parse_uint16, 0, offsetof(Network, dhcp_client_port)
DHCPv4.SendRelease, config_parse_bool, 0, offsetof(Network, dhcp_send_release) DHCPv4.SendRelease, config_parse_bool, 0, offsetof(Network, dhcp_send_release)
DHCPv4.SendDecline, config_parse_bool, 0, offsetof(Network, dhcp_send_decline) DHCPv4.SendDecline, config_parse_bool, 0, offsetof(Network, dhcp_send_decline)
DHCPv4.BlackList, config_parse_dhcp_black_listed_ip_address, 0, 0 DHCPv4.DenyList, config_parse_dhcp_deny_listed_ip_address, 0, 0
DHCPv4.BlackList, config_parse_dhcp_deny_listed_ip_address, 0, 0
DHCPv4.IPServiceType, config_parse_dhcp_ip_service_type, 0, offsetof(Network, ip_service_type) DHCPv4.IPServiceType, config_parse_dhcp_ip_service_type, 0, offsetof(Network, ip_service_type)
DHCPv4.SendOption, config_parse_dhcp_send_option, AF_INET, offsetof(Network, dhcp_client_send_options) DHCPv4.SendOption, config_parse_dhcp_send_option, AF_INET, offsetof(Network, dhcp_client_send_options)
DHCPv4.SendVendorOption, config_parse_dhcp_send_option, 0, offsetof(Network, dhcp_client_send_vendor_options) DHCPv4.SendVendorOption, config_parse_dhcp_send_option, 0, offsetof(Network, dhcp_client_send_vendor_options)
@ -214,7 +215,8 @@ IPv6AcceptRA.UseDNS, config_parse_bool,
IPv6AcceptRA.UseDomains, config_parse_dhcp_use_domains, 0, offsetof(Network, ipv6_accept_ra_use_domains) IPv6AcceptRA.UseDomains, config_parse_dhcp_use_domains, 0, offsetof(Network, ipv6_accept_ra_use_domains)
IPv6AcceptRA.DHCPv6Client, config_parse_ipv6_accept_ra_start_dhcp6_client, 0, offsetof(Network, ipv6_accept_ra_start_dhcp6_client) IPv6AcceptRA.DHCPv6Client, config_parse_ipv6_accept_ra_start_dhcp6_client, 0, offsetof(Network, ipv6_accept_ra_start_dhcp6_client)
IPv6AcceptRA.RouteTable, config_parse_section_route_table, 0, 0 IPv6AcceptRA.RouteTable, config_parse_section_route_table, 0, 0
IPv6AcceptRA.BlackList, config_parse_ndisc_black_listed_prefix, 0, 0 IPv6AcceptRA.DenyList, config_parse_ndisc_deny_listed_prefix, 0, 0
IPv6AcceptRA.BlackList, config_parse_ndisc_deny_listed_prefix, 0, 0
DHCPServer.MaxLeaseTimeSec, config_parse_sec, 0, offsetof(Network, dhcp_server_max_lease_time_usec) DHCPServer.MaxLeaseTimeSec, config_parse_sec, 0, offsetof(Network, dhcp_server_max_lease_time_usec)
DHCPServer.DefaultLeaseTimeSec, config_parse_sec, 0, offsetof(Network, dhcp_server_default_lease_time_usec) DHCPServer.DefaultLeaseTimeSec, config_parse_sec, 0, offsetof(Network, dhcp_server_default_lease_time_usec)
DHCPServer.EmitDNS, config_parse_bool, 0, offsetof(Network, dhcp_server_emit[SD_DHCP_LEASE_DNS].emit) DHCPServer.EmitDNS, config_parse_bool, 0, offsetof(Network, dhcp_server_emit[SD_DHCP_LEASE_DNS].emit)

4
src/network/networkd-network.c
View file

@ -662,7 +662,7 @@ static Network *network_free(Network *network) {
free(network->dhcp_mudurl); free(network->dhcp_mudurl);
strv_free(network->dhcp_user_class); strv_free(network->dhcp_user_class);
free(network->dhcp_hostname); free(network->dhcp_hostname);
set_free(network->dhcp_black_listed_ip); set_free(network->dhcp_deny_listed_ip);
set_free(network->dhcp_request_options); set_free(network->dhcp_request_options);
set_free(network->dhcp6_request_options); set_free(network->dhcp6_request_options);
free(network->mac); free(network->mac);
@ -681,7 +681,7 @@ static Network *network_free(Network *network) {
ordered_set_free_free(network->router_search_domains); ordered_set_free_free(network->router_search_domains);
free(network->router_dns); free(network->router_dns);
set_free_free(network->ndisc_black_listed_prefix); set_free_free(network->ndisc_deny_listed_prefix);
free(network->bridge_name); free(network->bridge_name);
free(network->bond_name); free(network->bond_name);

4
src/network/networkd-network.h
View file

@ -129,7 +129,7 @@ struct Network {
bool dhcp_send_decline; bool dhcp_send_decline;
DHCPUseDomains dhcp_use_domains; DHCPUseDomains dhcp_use_domains;
sd_ipv4acd *dhcp_acd; sd_ipv4acd *dhcp_acd;
Set *dhcp_black_listed_ip; Set *dhcp_deny_listed_ip;
Set *dhcp_request_options; Set *dhcp_request_options;
OrderedHashmap *dhcp_client_send_options; OrderedHashmap *dhcp_client_send_options;
OrderedHashmap *dhcp_client_send_vendor_options; OrderedHashmap *dhcp_client_send_vendor_options;
@ -241,7 +241,7 @@ struct Network {
DHCPUseDomains ipv6_accept_ra_use_domains; DHCPUseDomains ipv6_accept_ra_use_domains;
IPv6AcceptRAStartDHCP6Client ipv6_accept_ra_start_dhcp6_client; IPv6AcceptRAStartDHCP6Client ipv6_accept_ra_start_dhcp6_client;
uint32_t ipv6_accept_ra_route_table; uint32_t ipv6_accept_ra_route_table;
Set *ndisc_black_listed_prefix; Set *ndisc_deny_listed_prefix;
OrderedHashmap *ipv6_tokens; OrderedHashmap *ipv6_tokens;
IPv6PrivacyExtensions ipv6_privacy_extensions; IPv6PrivacyExtensions ipv6_privacy_extensions;

27
src/nspawn/nspawn-oci.c
View file

@ -57,7 +57,7 @@
* spec should say what to do with unknown props * spec should say what to do with unknown props
* /bin/mount regarding NFS and FUSE required? * /bin/mount regarding NFS and FUSE required?
* what does terminal=false mean? * what does terminal=false mean?
* sysctl inside or outside? whitelisting? * sysctl inside or outside? allow-listing?
* swapiness typo -> swappiness * swapiness typo -> swappiness
* *
* Unsupported: * Unsupported:
@ -1029,39 +1029,40 @@ static int oci_cgroup_devices(const char *name, JsonVariant *v, JsonDispatchFlag
return r; return r;
if (!data.allow) { if (!data.allow) {
/* The fact that OCI allows 'deny' entries makes really no sense, as 'allow' vs. 'deny' for the /* The fact that OCI allows 'deny' entries makes really no sense, as 'allow'
* devices cgroup controller is really not about whitelisting and blacklisting but about adding * vs. 'deny' for the devices cgroup controller is really not about allow-listing and
* and removing entries from the whitelist. Since we always start out with an empty whitelist * deny-listing but about adding and removing entries from the allow list. Since we
* we hence ignore the whole thing, as removing entries which don't exist make no sense. We'll * always start out with an empty allow list we hence ignore the whole thing, as
* log about this, since this is really borked in the spec, with one exception: the entry * removing entries which don't exist make no sense. We'll log about this, since this
* that's supposed to drop the kernel's default we ignore silently */ * is really borked in the spec, with one exception: the entry that's supposed to
* drop the kernel's default we ignore silently */
if (!data.r || !data.w || !data.m || data.type != 0 || data.major != (unsigned) -1 || data.minor != (unsigned) -1) if (!data.r || !data.w || !data.m || data.type != 0 || data.major != (unsigned) -1 || data.minor != (unsigned) -1)
json_log(v, flags|JSON_WARNING, 0, "Devices cgroup whitelist with arbitrary 'allow' entries not supported, ignoring."); json_log(v, flags|JSON_WARNING, 0, "Devices cgroup allow list with arbitrary 'allow' entries not supported, ignoring.");
/* We ignore the 'deny' entry as for us that's implied */ /* We ignore the 'deny' entry as for us that's implied */
continue; continue;
} }
if (!data.r && !data.w && !data.m) { if (!data.r && !data.w && !data.m) {
json_log(v, flags|LOG_WARNING, 0, "Device cgroup whitelist entry with no effect found, ignoring."); json_log(v, flags|LOG_WARNING, 0, "Device cgroup allow list entry with no effect found, ignoring.");
continue; continue;
} }
if (data.minor != (unsigned) -1 && data.major == (unsigned) -1) if (data.minor != (unsigned) -1 && data.major == (unsigned) -1)
return json_log(v, flags, SYNTHETIC_ERRNO(EOPNOTSUPP), return json_log(v, flags, SYNTHETIC_ERRNO(EOPNOTSUPP),
"Device cgroup whitelist entries with minors but no majors not supported."); "Device cgroup allow list entries with minors but no majors not supported.");
if (data.major != (unsigned) -1 && data.type == 0) if (data.major != (unsigned) -1 && data.type == 0)
return json_log(v, flags, SYNTHETIC_ERRNO(EOPNOTSUPP), return json_log(v, flags, SYNTHETIC_ERRNO(EOPNOTSUPP),
"Device cgroup whitelist entries with majors but no device node type not supported."); "Device cgroup allow list entries with majors but no device node type not supported.");
if (data.type == 0) { if (data.type == 0) {
if (data.r && data.w && data.m) /* a catchall whitelist entry means we are looking at a noop */ if (data.r && data.w && data.m) /* a catchall allow list entry means we are looking at a noop */
noop = true; noop = true;
else else
return json_log(v, flags, SYNTHETIC_ERRNO(EOPNOTSUPP), return json_log(v, flags, SYNTHETIC_ERRNO(EOPNOTSUPP),
"Device cgroup whitelist entries with no type not supported."); "Device cgroup allow list entries with no type not supported.");
} }
a = reallocarray(list, n_list + 1, sizeof(struct device_data)); a = reallocarray(list, n_list + 1, sizeof(struct device_data));

26
src/nspawn/nspawn-seccomp.c
View file

@ -25,13 +25,13 @@ static int seccomp_add_default_syscall_filter(
scmp_filter_ctx ctx, scmp_filter_ctx ctx,
uint32_t arch, uint32_t arch,
uint64_t cap_list_retain, uint64_t cap_list_retain,
char **syscall_whitelist, char **syscall_allow_list,
char **syscall_blacklist) { char **syscall_deny_list) {
static const struct { static const struct {
uint64_t capability; uint64_t capability;
const char* name; const char* name;
} whitelist[] = { } allow_list[] = {
/* Let's use set names where we can */ /* Let's use set names where we can */
{ 0, "@aio" }, { 0, "@aio" },
{ 0, "@basic-io" }, { 0, "@basic-io" },
@ -142,17 +142,17 @@ static int seccomp_add_default_syscall_filter(
char **p; char **p;
int r; int r;
for (size_t i = 0; i < ELEMENTSOF(whitelist); i++) { for (size_t i = 0; i < ELEMENTSOF(allow_list); i++) {
if (whitelist[i].capability != 0 && (cap_list_retain & (1ULL << whitelist[i].capability)) == 0) if (allow_list[i].capability != 0 && (cap_list_retain & (1ULL << allow_list[i].capability)) == 0)
continue; continue;
r = seccomp_add_syscall_filter_item(ctx, whitelist[i].name, SCMP_ACT_ALLOW, syscall_blacklist, false); r = seccomp_add_syscall_filter_item(ctx, allow_list[i].name, SCMP_ACT_ALLOW, syscall_deny_list, false);
if (r < 0) if (r < 0)
return log_error_errno(r, "Failed to add syscall filter item %s: %m", whitelist[i].name); return log_error_errno(r, "Failed to add syscall filter item %s: %m", allow_list[i].name);
} }
STRV_FOREACH(p, syscall_whitelist) { STRV_FOREACH(p, syscall_allow_list) {
r = seccomp_add_syscall_filter_item(ctx, *p, SCMP_ACT_ALLOW, syscall_blacklist, true); r = seccomp_add_syscall_filter_item(ctx, *p, SCMP_ACT_ALLOW, syscall_deny_list, true);
if (r < 0) if (r < 0)
log_warning_errno(r, "Failed to add rule for system call %s on %s, ignoring: %m", log_warning_errno(r, "Failed to add rule for system call %s on %s, ignoring: %m",
*p, seccomp_arch_to_string(arch)); *p, seccomp_arch_to_string(arch));
@ -161,7 +161,7 @@ static int seccomp_add_default_syscall_filter(
return 0; return 0;
} }
int setup_seccomp(uint64_t cap_list_retain, char **syscall_whitelist, char **syscall_blacklist) { int setup_seccomp(uint64_t cap_list_retain, char **syscall_allow_list, char **syscall_deny_list) {
uint32_t arch; uint32_t arch;
int r; int r;
@ -173,13 +173,13 @@ int setup_seccomp(uint64_t cap_list_retain, char **syscall_whitelist, char **sys
SECCOMP_FOREACH_LOCAL_ARCH(arch) { SECCOMP_FOREACH_LOCAL_ARCH(arch) {
_cleanup_(seccomp_releasep) scmp_filter_ctx seccomp = NULL; _cleanup_(seccomp_releasep) scmp_filter_ctx seccomp = NULL;
log_debug("Applying whitelist on architecture: %s", seccomp_arch_to_string(arch)); log_debug("Applying allow list on architecture: %s", seccomp_arch_to_string(arch));
r = seccomp_init_for_arch(&seccomp, arch, SCMP_ACT_ERRNO(EPERM)); r = seccomp_init_for_arch(&seccomp, arch, SCMP_ACT_ERRNO(EPERM));
if (r < 0) if (r < 0)
return log_error_errno(r, "Failed to allocate seccomp object: %m"); return log_error_errno(r, "Failed to allocate seccomp object: %m");
r = seccomp_add_default_syscall_filter(seccomp, arch, cap_list_retain, syscall_whitelist, syscall_blacklist); r = seccomp_add_default_syscall_filter(seccomp, arch, cap_list_retain, syscall_allow_list, syscall_deny_list);
if (r < 0) if (r < 0)
return r; return r;
@ -231,7 +231,7 @@ int setup_seccomp(uint64_t cap_list_retain, char **syscall_whitelist, char **sys
#else #else
int setup_seccomp(uint64_t cap_list_retain, char **syscall_whitelist, char **syscall_blacklist) { int setup_seccomp(uint64_t cap_list_retain, char **syscall_allow_list, char **syscall_deny_list) {
return 0; return 0;
} }

2
src/nspawn/nspawn-seccomp.h
View file

@ -3,4 +3,4 @@
#include <sys/types.h> #include <sys/types.h>
int setup_seccomp(uint64_t cap_list_retain, char **syscall_whitelist, char **syscall_blacklist); int setup_seccomp(uint64_t cap_list_retain, char **syscall_allow_ist, char **syscall_deny_list);

8
src/nspawn/nspawn-settings.c
View file

@ -129,8 +129,8 @@ Settings* settings_free(Settings *s) {
free(s->pivot_root_new); free(s->pivot_root_new);
free(s->pivot_root_old); free(s->pivot_root_old);
free(s->working_directory); free(s->working_directory);
strv_free(s->syscall_whitelist); strv_free(s->syscall_allow_list);
strv_free(s->syscall_blacklist); strv_free(s->syscall_deny_list);
rlimit_free_all(s->rlimit); rlimit_free_all(s->rlimit);
free(s->hostname); free(s->hostname);
cpu_set_reset(&s->cpu_set); cpu_set_reset(&s->cpu_set);
@ -689,9 +689,9 @@ int config_parse_syscall_filter(
} }
if (negative) if (negative)
r = strv_extend(&settings->syscall_blacklist, word); r = strv_extend(&settings->syscall_deny_list, word);
else else
r = strv_extend(&settings->syscall_whitelist, word); r = strv_extend(&settings->syscall_allow_list, word);
if (r < 0) if (r < 0)
return log_oom(); return log_oom();
} }

4
src/nspawn/nspawn-settings.h
View file

@ -165,8 +165,8 @@ typedef struct Settings {
UserNamespaceMode userns_mode; UserNamespaceMode userns_mode;
uid_t uid_shift, uid_range; uid_t uid_shift, uid_range;
bool notify_ready; bool notify_ready;
char **syscall_whitelist; char **syscall_allow_list;
char **syscall_blacklist; char **syscall_deny_list;
struct rlimit *rlimit[_RLIMIT_MAX]; struct rlimit *rlimit[_RLIMIT_MAX];
char *hostname; char *hostname;
int no_new_privileges; int no_new_privileges;

29
src/nspawn/nspawn.c
View file

@ -201,8 +201,8 @@ static MountSettingsMask arg_mount_settings = MOUNT_APPLY_APIVFS_RO|MOUNT_APPLY_
static void *arg_root_hash = NULL; static void *arg_root_hash = NULL;
static char *arg_verity_data = NULL; static char *arg_verity_data = NULL;
static size_t arg_root_hash_size = 0; static size_t arg_root_hash_size = 0;
static char **arg_syscall_whitelist = NULL; static char **arg_syscall_allow_list = NULL;
static char **arg_syscall_blacklist = NULL; static char **arg_syscall_deny_list = NULL;
#if HAVE_SECCOMP #if HAVE_SECCOMP
static scmp_filter_ctx arg_seccomp = NULL; static scmp_filter_ctx arg_seccomp = NULL;
#endif #endif
@ -244,8 +244,8 @@ STATIC_DESTRUCTOR_REGISTER(arg_property_message, sd_bus_message_unrefp);
STATIC_DESTRUCTOR_REGISTER(arg_parameters, strv_freep); STATIC_DESTRUCTOR_REGISTER(arg_parameters, strv_freep);
STATIC_DESTRUCTOR_REGISTER(arg_root_hash, freep); STATIC_DESTRUCTOR_REGISTER(arg_root_hash, freep);
STATIC_DESTRUCTOR_REGISTER(arg_verity_data, freep); STATIC_DESTRUCTOR_REGISTER(arg_verity_data, freep);
STATIC_DESTRUCTOR_REGISTER(arg_syscall_whitelist, strv_freep); STATIC_DESTRUCTOR_REGISTER(arg_syscall_allow_list, strv_freep);
STATIC_DESTRUCTOR_REGISTER(arg_syscall_blacklist, strv_freep); STATIC_DESTRUCTOR_REGISTER(arg_syscall_deny_list, strv_freep);
#if HAVE_SECCOMP #if HAVE_SECCOMP
STATIC_DESTRUCTOR_REGISTER(arg_seccomp, seccomp_releasep); STATIC_DESTRUCTOR_REGISTER(arg_seccomp, seccomp_releasep);
#endif #endif
@ -1346,9 +1346,9 @@ static int parse_argv(int argc, char *argv[]) {
return log_error_errno(r, "Failed to parse system call filter: %m"); return log_error_errno(r, "Failed to parse system call filter: %m");
if (negative) if (negative)
r = strv_extend(&arg_syscall_blacklist, word); r = strv_extend(&arg_syscall_deny_list, word);
else else
r = strv_extend(&arg_syscall_whitelist, word); r = strv_extend(&arg_syscall_allow_list, word);
if (r < 0) if (r < 0)
return log_oom(); return log_oom();
} }
@ -2175,10 +2175,11 @@ static int setup_dev_console(const char *console) {
static int setup_keyring(void) { static int setup_keyring(void) {
key_serial_t keyring; key_serial_t keyring;
/* Allocate a new session keyring for the container. This makes sure the keyring of the session systemd-nspawn /* Allocate a new session keyring for the container. This makes sure the keyring of the session
* was invoked from doesn't leak into the container. Note that by default we block keyctl() and request_key() * systemd-nspawn was invoked from doesn't leak into the container. Note that by default we block
* anyway via seccomp so doing this operation isn't strictly necessary, but in case people explicitly whitelist * keyctl() and request_key() anyway via seccomp so doing this operation isn't strictly necessary,
* these system calls let's make sure we don't leak anything into the container. */ * but in case people explicitly allow-list these system calls let's make sure we don't leak anything
* into the container. */
keyring = keyctl(KEYCTL_JOIN_SESSION_KEYRING, 0, 0, 0, 0); keyring = keyctl(KEYCTL_JOIN_SESSION_KEYRING, 0, 0, 0, 0);
if (keyring == -1) { if (keyring == -1) {
@ -3089,7 +3090,7 @@ static int inner_child(
} else } else
#endif #endif
{ {
r = setup_seccomp(arg_caps_retain, arg_syscall_whitelist, arg_syscall_blacklist); r = setup_seccomp(arg_caps_retain, arg_syscall_allow_list, arg_syscall_deny_list);
if (r < 0) if (r < 0)
return r; return r;
} }
@ -3954,11 +3955,11 @@ static int merge_settings(Settings *settings, const char *path) {
if ((arg_settings_mask & SETTING_SYSCALL_FILTER) == 0) { if ((arg_settings_mask & SETTING_SYSCALL_FILTER) == 0) {
if (!arg_settings_trusted && !strv_isempty(settings->syscall_whitelist)) if (!arg_settings_trusted && !strv_isempty(settings->syscall_allow_list))
log_warning("Ignoring SystemCallFilter= settings, file %s is not trusted.", path); log_warning("Ignoring SystemCallFilter= settings, file %s is not trusted.", path);
else { else {
strv_free_and_replace(arg_syscall_whitelist, settings->syscall_whitelist); strv_free_and_replace(arg_syscall_allow_list, settings->syscall_allow_list);
strv_free_and_replace(arg_syscall_blacklist, settings->syscall_blacklist); strv_free_and_replace(arg_syscall_deny_list, settings->syscall_deny_list);
} }
#if HAVE_SECCOMP #if HAVE_SECCOMP

4
src/partition/growfs.c
View file

@ -79,7 +79,7 @@ static int resize_crypt_luks_device(dev_t devno, const char *fstype, dev_t main_
} }
#endif #endif
static int maybe_resize_slave_device(const char *mountpath, dev_t main_devno) { static int maybe_resize_underlying_device(const char *mountpath, dev_t main_devno) {
_cleanup_free_ char *fstype = NULL, *devpath = NULL; _cleanup_free_ char *fstype = NULL, *devpath = NULL;
dev_t devno; dev_t devno;
int r; int r;
@ -213,7 +213,7 @@ static int run(int argc, char *argv[]) {
if (r < 0) if (r < 0)
return log_error_errno(r, "Failed to determine block device of \"%s\": %m", arg_target); return log_error_errno(r, "Failed to determine block device of \"%s\": %m", arg_target);
r = maybe_resize_slave_device(arg_target, devno); r = maybe_resize_underlying_device(arg_target, devno);
if (r < 0) if (r < 0)
return r; return r;

4
src/resolve/test-resolved-etc-hosts.c
View file

@ -65,7 +65,7 @@ static void test_parse_etc_hosts(void) {
"1::2::3 multi.colon\n" "1::2::3 multi.colon\n"
"::0 some.where some.other\n" "::0 some.where some.other\n"
"0.0.0.0 black.listed\n" "0.0.0.0 deny.listed\n"
"::5\t\t\t \tsome.where\tsome.other foobar.foo.foo\t\t\t\n" "::5\t\t\t \tsome.where\tsome.other foobar.foo.foo\t\t\t\n"
" \n", f); " \n", f);
assert_se(fflush_and_check(f) >= 0); assert_se(fflush_and_check(f) >= 0);
@ -123,7 +123,7 @@ static void test_parse_etc_hosts(void) {
assert_se( set_contains(hosts.no_address, "some.where")); assert_se( set_contains(hosts.no_address, "some.where"));
assert_se( set_contains(hosts.no_address, "some.other")); assert_se( set_contains(hosts.no_address, "some.other"));
assert_se( set_contains(hosts.no_address, "black.listed")); assert_se( set_contains(hosts.no_address, "deny.listed"));
assert_se(!set_contains(hosts.no_address, "foobar.foo.foo")); assert_se(!set_contains(hosts.no_address, "foobar.foo.foo"));
} }

6
src/shared/bus-unit-util.c
View file

@ -1173,11 +1173,11 @@ static int bus_append_execute_property(sd_bus_message *m, const char *field, con
if (STR_IN_SET(field, "RestrictAddressFamilies", if (STR_IN_SET(field, "RestrictAddressFamilies",
"SystemCallFilter")) { "SystemCallFilter")) {
int whitelist = 1; int allow_list = 1;
const char *p = eq; const char *p = eq;
if (*p == '~') { if (*p == '~') {
whitelist = 0; allow_list = 0;
p++; p++;
} }
@ -1197,7 +1197,7 @@ static int bus_append_execute_property(sd_bus_message *m, const char *field, con
if (r < 0) if (r < 0)
return bus_log_create_error(r); return bus_log_create_error(r);
r = sd_bus_message_append_basic(m, 'b', &whitelist); r = sd_bus_message_append_basic(m, 'b', &allow_list);
if (r < 0) if (r < 0)
return bus_log_create_error(r); return bus_log_create_error(r);

2
src/shared/module-util.c
View file

@ -51,7 +51,7 @@ int module_load_and_warn(struct kmod_ctx *ctx, const char *module, bool verbose)
"Inserted module '%s'", kmod_module_get_name(mod)); "Inserted module '%s'", kmod_module_get_name(mod));
else if (err == KMOD_PROBE_APPLY_BLACKLIST) else if (err == KMOD_PROBE_APPLY_BLACKLIST)
log_full(verbose ? LOG_INFO : LOG_DEBUG, log_full(verbose ? LOG_INFO : LOG_DEBUG,
"Module '%s' is blacklisted", kmod_module_get_name(mod)); "Module '%s' is deny-listed", kmod_module_get_name(mod));
else { else {
assert(err < 0); assert(err < 0);

22
src/shared/mount-util.c
View file

@ -136,7 +136,7 @@ int bind_remount_recursive_with_mountinfo(
const char *prefix, const char *prefix,
unsigned long new_flags, unsigned long new_flags,
unsigned long flags_mask, unsigned long flags_mask,
char **blacklist, char **deny_list,
FILE *proc_self_mountinfo) { FILE *proc_self_mountinfo) {
_cleanup_set_free_free_ Set *done = NULL; _cleanup_set_free_free_ Set *done = NULL;
@ -154,8 +154,8 @@ int bind_remount_recursive_with_mountinfo(
* do not have any effect on future submounts that might get propagated, they might be writable. This includes * do not have any effect on future submounts that might get propagated, they might be writable. This includes
* future submounts that have been triggered via autofs. * future submounts that have been triggered via autofs.
* *
* If the "blacklist" parameter is specified it may contain a list of subtrees to exclude from the * If the "deny_list" parameter is specified it may contain a list of subtrees to exclude from the
* remount operation. Note that we'll ignore the blacklist for the top-level path. */ * remount operation. Note that we'll ignore the deny list for the top-level path. */
simplified = strdup(prefix); simplified = strdup(prefix);
if (!simplified) if (!simplified)
@ -203,13 +203,13 @@ int bind_remount_recursive_with_mountinfo(
if (!path_startswith(path, simplified)) if (!path_startswith(path, simplified))
continue; continue;
/* Ignore this mount if it is blacklisted, but only if it isn't the top-level mount /* Ignore this mount if it is deny-listed, but only if it isn't the top-level mount
* we shall operate on. */ * we shall operate on. */
if (!path_equal(path, simplified)) { if (!path_equal(path, simplified)) {
bool blacklisted = false; bool deny_listed = false;
char **i; char **i;
STRV_FOREACH(i, blacklist) { STRV_FOREACH(i, deny_list) {
if (path_equal(*i, simplified)) if (path_equal(*i, simplified))
continue; continue;
@ -217,13 +217,13 @@ int bind_remount_recursive_with_mountinfo(
continue; continue;
if (path_startswith(path, *i)) { if (path_startswith(path, *i)) {
blacklisted = true; deny_listed = true;
log_debug("Not remounting %s blacklisted by %s, called for %s", log_debug("Not remounting %s deny-listed by %s, called for %s",
path, *i, simplified); path, *i, simplified);
break; break;
} }
} }
if (blacklisted) if (deny_listed)
continue; continue;
} }
@ -314,7 +314,7 @@ int bind_remount_recursive(
const char *prefix, const char *prefix,
unsigned long new_flags, unsigned long new_flags,
unsigned long flags_mask, unsigned long flags_mask,
char **blacklist) { char **deny_list) {
_cleanup_fclose_ FILE *proc_self_mountinfo = NULL; _cleanup_fclose_ FILE *proc_self_mountinfo = NULL;
int r; int r;
@ -323,7 +323,7 @@ int bind_remount_recursive(
if (r < 0) if (r < 0)
return r; return r;
return bind_remount_recursive_with_mountinfo(prefix, new_flags, flags_mask, blacklist, proc_self_mountinfo); return bind_remount_recursive_with_mountinfo(prefix, new_flags, flags_mask, deny_list, proc_self_mountinfo);
} }
int bind_remount_one_with_mountinfo( int bind_remount_one_with_mountinfo(

4
src/shared/mount-util.h
View file

@ -28,8 +28,8 @@
int repeat_unmount(const char *path, int flags); int repeat_unmount(const char *path, int flags);
int umount_recursive(const char *target, int flags); int umount_recursive(const char *target, int flags);
int bind_remount_recursive(const char *prefix, unsigned long new_flags, unsigned long flags_mask, char **blacklist); int bind_remount_recursive(const char *prefix, unsigned long new_flags, unsigned long flags_mask, char **deny_list);
int bind_remount_recursive_with_mountinfo(const char *prefix, unsigned long new_flags, unsigned long flags_mask, char **blacklist, FILE *proc_self_mountinfo); int bind_remount_recursive_with_mountinfo(const char *prefix, unsigned long new_flags, unsigned long flags_mask, char **deny_list, FILE *proc_self_mountinfo);
int bind_remount_one_with_mountinfo(const char *path, unsigned long new_flags, unsigned long flags_mask, FILE *proc_self_mountinfo); int bind_remount_one_with_mountinfo(const char *path, unsigned long new_flags, unsigned long flags_mask, FILE *proc_self_mountinfo);
int mount_move_root(const char *path); int mount_move_root(const char *path);

27
src/shared/seccomp-util.c
View file

@ -24,7 +24,7 @@
const uint32_t seccomp_local_archs[] = { const uint32_t seccomp_local_archs[] = {
/* Note: always list the native arch we are compiled as last, so that users can blacklist seccomp(), but our own calls to it still succeed */ /* Note: always list the native arch we are compiled as last, so that users can deny-list seccomp(), but our own calls to it still succeed */
#if defined(__x86_64__) && defined(__ILP32__) #if defined(__x86_64__) && defined(__ILP32__)
SCMP_ARCH_X86, SCMP_ARCH_X86,
@ -1112,7 +1112,7 @@ int seccomp_parse_syscall_filter(
/* If we previously wanted to forbid a syscall and now /* If we previously wanted to forbid a syscall and now
* we want to allow it, then remove it from the list. */ * we want to allow it, then remove it from the list. */
if (!(flags & SECCOMP_PARSE_INVERT) == !!(flags & SECCOMP_PARSE_WHITELIST)) { if (!(flags & SECCOMP_PARSE_INVERT) == !!(flags & SECCOMP_PARSE_ALLOW_LIST)) {
r = hashmap_put(filter, INT_TO_PTR(id + 1), INT_TO_PTR(errno_num)); r = hashmap_put(filter, INT_TO_PTR(id + 1), INT_TO_PTR(errno_num));
if (r < 0) if (r < 0)
switch (r) { switch (r) {
@ -1315,7 +1315,7 @@ int seccomp_protect_syslog(void) {
return 0; return 0;
} }
int seccomp_restrict_address_families(Set *address_families, bool whitelist) { int seccomp_restrict_address_families(Set *address_families, bool allow_list) {
uint32_t arch; uint32_t arch;
int r; int r;
@ -1362,13 +1362,13 @@ int seccomp_restrict_address_families(Set *address_families, bool whitelist) {
if (r < 0) if (r < 0)
return r; return r;
if (whitelist) { if (allow_list) {
int af, first = 0, last = 0; int af, first = 0, last = 0;
void *afp; void *afp;
/* If this is a whitelist, we first block the address families that are out of range and then /* If this is an allow list, we first block the address families that are out of
* everything that is not in the set. First, we find the lowest and highest address family in * range and then everything that is not in the set. First, we find the lowest and
* the set. */ * highest address family in the set. */
SET_FOREACH(afp, address_families, i) { SET_FOREACH(afp, address_families, i) {
af = PTR_TO_INT(afp); af = PTR_TO_INT(afp);
@ -1448,9 +1448,8 @@ int seccomp_restrict_address_families(Set *address_families, bool whitelist) {
} else { } else {
void *af; void *af;
/* If this is a blacklist, then generate one rule for /* If this is a deny list, then generate one rule for each address family that are
* each address family that are then combined in OR * then combined in OR checks. */
* checks. */
SET_FOREACH(af, address_families, i) { SET_FOREACH(af, address_families, i) {
@ -1506,11 +1505,11 @@ int seccomp_restrict_realtime(void) {
return r; return r;
/* Go through all policies with lower values than that, and block them -- unless they appear in the /* Go through all policies with lower values than that, and block them -- unless they appear in the
* whitelist. */ * allow list. */
for (p = 0; p < max_policy; p++) { for (p = 0; p < max_policy; p++) {
bool good = false; bool good = false;
/* Check if this is in the whitelist. */ /* Check if this is in the allow list. */
for (i = 0; i < ELEMENTSOF(permitted_policies); i++) for (i = 0; i < ELEMENTSOF(permitted_policies); i++)
if (permitted_policies[i] == p) { if (permitted_policies[i] == p) {
good = true; good = true;
@ -1533,8 +1532,8 @@ int seccomp_restrict_realtime(void) {
} }
} }
/* Blacklist all other policies, i.e. the ones with higher values. Note that all comparisons are /* Deny-list all other policies, i.e. the ones with higher values. Note that all comparisons
* unsigned here, hence no need no check for < 0 values. */ * are unsigned here, hence no need no check for < 0 values. */
r = seccomp_rule_add_exact( r = seccomp_rule_add_exact(
seccomp, seccomp,
SCMP_ACT_ERRNO(EPERM), SCMP_ACT_ERRNO(EPERM),

4
src/shared/seccomp-util.h
View file

@ -66,7 +66,7 @@ int seccomp_load_syscall_filter_set_raw(uint32_t default_action, Hashmap* set, u
typedef enum SeccompParseFlags { typedef enum SeccompParseFlags {
SECCOMP_PARSE_INVERT = 1 << 0, SECCOMP_PARSE_INVERT = 1 << 0,
SECCOMP_PARSE_WHITELIST = 1 << 1, SECCOMP_PARSE_ALLOW_LIST = 1 << 1,
SECCOMP_PARSE_LOG = 1 << 2, SECCOMP_PARSE_LOG = 1 << 2,
SECCOMP_PARSE_PERMISSIVE = 1 << 3, SECCOMP_PARSE_PERMISSIVE = 1 << 3,
} SeccompParseFlags; } SeccompParseFlags;
@ -83,7 +83,7 @@ int seccomp_restrict_archs(Set *archs);
int seccomp_restrict_namespaces(unsigned long retain); int seccomp_restrict_namespaces(unsigned long retain);
int seccomp_protect_sysctl(void); int seccomp_protect_sysctl(void);
int seccomp_protect_syslog(void); int seccomp_protect_syslog(void);
int seccomp_restrict_address_families(Set *address_families, bool whitelist); int seccomp_restrict_address_families(Set *address_families, bool allow_list);
int seccomp_restrict_realtime(void); int seccomp_restrict_realtime(void);
int seccomp_memory_deny_write_execute(void); int seccomp_memory_deny_write_execute(void);
int seccomp_lock_personality(unsigned long personality); int seccomp_lock_personality(unsigned long personality);

8
src/systemctl/systemctl.c
View file

@ -4819,13 +4819,13 @@ static int print_property(const char *name, const char *expected_value, sd_bus_m
} else if (STR_IN_SET(name, "SystemCallFilter", "RestrictAddressFamilies")) { } else if (STR_IN_SET(name, "SystemCallFilter", "RestrictAddressFamilies")) {
_cleanup_strv_free_ char **l = NULL; _cleanup_strv_free_ char **l = NULL;
int whitelist; int allow_list;
r = sd_bus_message_enter_container(m, 'r', "bas"); r = sd_bus_message_enter_container(m, 'r', "bas");
if (r < 0) if (r < 0)
return bus_log_parse_error(r); return bus_log_parse_error(r);
r = sd_bus_message_read(m, "b", &whitelist); r = sd_bus_message_read(m, "b", &allow_list);
if (r < 0) if (r < 0)
return bus_log_parse_error(r); return bus_log_parse_error(r);
@ -4837,7 +4837,7 @@ static int print_property(const char *name, const char *expected_value, sd_bus_m
if (r < 0) if (r < 0)
return bus_log_parse_error(r); return bus_log_parse_error(r);
if (all || whitelist || !strv_isempty(l)) { if (all || allow_list || !strv_isempty(l)) {
bool first = true; bool first = true;
char **i; char **i;
@ -4846,7 +4846,7 @@ static int print_property(const char *name, const char *expected_value, sd_bus_m
fputc('=', stdout); fputc('=', stdout);
} }
if (!whitelist) if (!allow_list)
fputc('~', stdout); fputc('~', stdout);
STRV_FOREACH(i, l) { STRV_FOREACH(i, l) {

26
src/test/test-bpf-devices.c
View file

@ -24,7 +24,7 @@ static void test_policy_closed(const char *cgroup_path, BPFProgram **installed_p
r = bpf_devices_cgroup_init(&prog, CGROUP_DEVICE_POLICY_CLOSED, true); r = bpf_devices_cgroup_init(&prog, CGROUP_DEVICE_POLICY_CLOSED, true);
assert_se(r >= 0); assert_se(r >= 0);
r = bpf_devices_whitelist_static(prog, cgroup_path); r = bpf_devices_allow_list_static(prog, cgroup_path);
assert_se(r >= 0); assert_se(r >= 0);
r = bpf_devices_apply_policy(prog, CGROUP_DEVICE_POLICY_CLOSED, true, cgroup_path, installed_prog); r = bpf_devices_apply_policy(prog, CGROUP_DEVICE_POLICY_CLOSED, true, cgroup_path, installed_prog);
@ -62,13 +62,13 @@ static void test_policy_strict(const char *cgroup_path, BPFProgram **installed_p
r = bpf_devices_cgroup_init(&prog, CGROUP_DEVICE_POLICY_STRICT, true); r = bpf_devices_cgroup_init(&prog, CGROUP_DEVICE_POLICY_STRICT, true);
assert_se(r >= 0); assert_se(r >= 0);
r = bpf_devices_whitelist_device(prog, cgroup_path, "/dev/null", "rw"); r = bpf_devices_allow_list_device(prog, cgroup_path, "/dev/null", "rw");
assert_se(r >= 0); assert_se(r >= 0);
r = bpf_devices_whitelist_device(prog, cgroup_path, "/dev/random", "r"); r = bpf_devices_allow_list_device(prog, cgroup_path, "/dev/random", "r");
assert_se(r >= 0); assert_se(r >= 0);
r = bpf_devices_whitelist_device(prog, cgroup_path, "/dev/zero", "w"); r = bpf_devices_allow_list_device(prog, cgroup_path, "/dev/zero", "w");
assert_se(r >= 0); assert_se(r >= 0);
r = bpf_devices_apply_policy(prog, CGROUP_DEVICE_POLICY_STRICT, true, cgroup_path, installed_prog); r = bpf_devices_apply_policy(prog, CGROUP_DEVICE_POLICY_STRICT, true, cgroup_path, installed_prog);
@ -129,7 +129,7 @@ static void test_policy_strict(const char *cgroup_path, BPFProgram **installed_p
assert_se(wrong == 0); assert_se(wrong == 0);
} }
static void test_policy_whitelist_major(const char *pattern, const char *cgroup_path, BPFProgram **installed_prog) { static void test_policy_allow_list_major(const char *pattern, const char *cgroup_path, BPFProgram **installed_prog) {
_cleanup_(bpf_program_unrefp) BPFProgram *prog = NULL; _cleanup_(bpf_program_unrefp) BPFProgram *prog = NULL;
unsigned wrong = 0; unsigned wrong = 0;
int r; int r;
@ -139,7 +139,7 @@ static void test_policy_whitelist_major(const char *pattern, const char *cgroup_
r = bpf_devices_cgroup_init(&prog, CGROUP_DEVICE_POLICY_STRICT, true); r = bpf_devices_cgroup_init(&prog, CGROUP_DEVICE_POLICY_STRICT, true);
assert_se(r >= 0); assert_se(r >= 0);
r = bpf_devices_whitelist_major(prog, cgroup_path, pattern, 'c', "rw"); r = bpf_devices_allow_list_major(prog, cgroup_path, pattern, 'c', "rw");
assert_se(r >= 0); assert_se(r >= 0);
r = bpf_devices_apply_policy(prog, CGROUP_DEVICE_POLICY_STRICT, true, cgroup_path, installed_prog); r = bpf_devices_apply_policy(prog, CGROUP_DEVICE_POLICY_STRICT, true, cgroup_path, installed_prog);
@ -188,7 +188,7 @@ static void test_policy_whitelist_major(const char *pattern, const char *cgroup_
assert_se(wrong == 0); assert_se(wrong == 0);
} }
static void test_policy_whitelist_major_star(char type, const char *cgroup_path, BPFProgram **installed_prog) { static void test_policy_allow_list_major_star(char type, const char *cgroup_path, BPFProgram **installed_prog) {
_cleanup_(bpf_program_unrefp) BPFProgram *prog = NULL; _cleanup_(bpf_program_unrefp) BPFProgram *prog = NULL;
unsigned wrong = 0; unsigned wrong = 0;
int r; int r;
@ -198,7 +198,7 @@ static void test_policy_whitelist_major_star(char type, const char *cgroup_path,
r = bpf_devices_cgroup_init(&prog, CGROUP_DEVICE_POLICY_STRICT, true); r = bpf_devices_cgroup_init(&prog, CGROUP_DEVICE_POLICY_STRICT, true);
assert_se(r >= 0); assert_se(r >= 0);
r = bpf_devices_whitelist_major(prog, cgroup_path, "*", type, "rw"); r = bpf_devices_allow_list_major(prog, cgroup_path, "*", type, "rw");
assert_se(r >= 0); assert_se(r >= 0);
r = bpf_devices_apply_policy(prog, CGROUP_DEVICE_POLICY_STRICT, true, cgroup_path, installed_prog); r = bpf_devices_apply_policy(prog, CGROUP_DEVICE_POLICY_STRICT, true, cgroup_path, installed_prog);
@ -230,7 +230,7 @@ static void test_policy_empty(bool add_mismatched, const char *cgroup_path, BPFP
assert_se(r >= 0); assert_se(r >= 0);
if (add_mismatched) { if (add_mismatched) {
r = bpf_devices_whitelist_major(prog, cgroup_path, "foobarxxx", 'c', "rw"); r = bpf_devices_allow_list_major(prog, cgroup_path, "foobarxxx", 'c', "rw");
assert_se(r < 0); assert_se(r < 0);
} }
@ -287,11 +287,11 @@ int main(int argc, char *argv[]) {
test_policy_closed(cgroup, &prog); test_policy_closed(cgroup, &prog);
test_policy_strict(cgroup, &prog); test_policy_strict(cgroup, &prog);
test_policy_whitelist_major("mem", cgroup, &prog); test_policy_allow_list_major("mem", cgroup, &prog);
test_policy_whitelist_major("1", cgroup, &prog); test_policy_allow_list_major("1", cgroup, &prog);
test_policy_whitelist_major_star('c', cgroup, &prog); test_policy_allow_list_major_star('c', cgroup, &prog);
test_policy_whitelist_major_star('b', cgroup, &prog); test_policy_allow_list_major_star('b', cgroup, &prog);
test_policy_empty(false, cgroup, &prog); test_policy_empty(false, cgroup, &prog);
test_policy_empty(true, cgroup, &prog); test_policy_empty(true, cgroup, &prog);

2
src/test/test-execute.c
View file

@ -467,7 +467,7 @@ static void test_exec_restrictnamespaces(Manager *m) {
test(__func__, m, "exec-restrictnamespaces-no.service", can_unshare ? 0 : EXIT_FAILURE, CLD_EXITED); test(__func__, m, "exec-restrictnamespaces-no.service", can_unshare ? 0 : EXIT_FAILURE, CLD_EXITED);
test(__func__, m, "exec-restrictnamespaces-yes.service", 1, CLD_EXITED); test(__func__, m, "exec-restrictnamespaces-yes.service", 1, CLD_EXITED);
test(__func__, m, "exec-restrictnamespaces-mnt.service", can_unshare ? 0 : EXIT_FAILURE, CLD_EXITED); test(__func__, m, "exec-restrictnamespaces-mnt.service", can_unshare ? 0 : EXIT_FAILURE, CLD_EXITED);
test(__func__, m, "exec-restrictnamespaces-mnt-blacklist.service", 1, CLD_EXITED); test(__func__, m, "exec-restrictnamespaces-mnt-deny-list.service", 1, CLD_EXITED);
test(__func__, m, "exec-restrictnamespaces-merge-and.service", can_unshare ? 0 : EXIT_FAILURE, CLD_EXITED); test(__func__, m, "exec-restrictnamespaces-merge-and.service", can_unshare ? 0 : EXIT_FAILURE, CLD_EXITED);
test(__func__, m, "exec-restrictnamespaces-merge-or.service", can_unshare ? 0 : EXIT_FAILURE, CLD_EXITED); test(__func__, m, "exec-restrictnamespaces-merge-or.service", can_unshare ? 0 : EXIT_FAILURE, CLD_EXITED);
test(__func__, m, "exec-restrictnamespaces-merge-all.service", can_unshare ? 0 : EXIT_FAILURE, CLD_EXITED); test(__func__, m, "exec-restrictnamespaces-merge-all.service", can_unshare ? 0 : EXIT_FAILURE, CLD_EXITED);

2
src/test/test-seccomp.c
View file

@ -123,7 +123,7 @@ static void test_filter_sets(void) {
if (pid == 0) { /* Child? */ if (pid == 0) { /* Child? */
int fd; int fd;
/* If we look at the default set (or one that includes it), whitelist instead of blacklist */ /* If we look at the default set (or one that includes it), allow-list instead of deny-list */
if (IN_SET(i, SYSCALL_FILTER_SET_DEFAULT, SYSCALL_FILTER_SET_SYSTEM_SERVICE)) if (IN_SET(i, SYSCALL_FILTER_SET_DEFAULT, SYSCALL_FILTER_SET_SYSTEM_SERVICE))
r = seccomp_load_syscall_filter_set(SCMP_ACT_ERRNO(EUCLEAN), syscall_filter_sets + i, SCMP_ACT_ALLOW, true); r = seccomp_load_syscall_filter_set(SCMP_ACT_ERRNO(EUCLEAN), syscall_filter_sets + i, SCMP_ACT_ALLOW, true);
else else

3
src/tmpfiles/tmpfiles.c
View file

@ -2405,8 +2405,7 @@ static bool should_include_path(const char *path) {
return true; return true;
} }
/* no matches, so we should include this path only if we /* no matches, so we should include this path only if we have no allow list at all */
* have no whitelist at all */
if (strv_isempty(arg_include_prefixes)) if (strv_isempty(arg_include_prefixes))
return true; return true;

2
test/fuzz/fuzz-network-parser/directives.network
View file

@ -96,6 +96,7 @@ ClientIdentifier=
ListenPort= ListenPort=
UseTimezone= UseTimezone=
RouteTable= RouteTable=
DenyList=
BlackList= BlackList=
RequestOptions= RequestOptions=
SendRelease= SendRelease=
@ -279,6 +280,7 @@ UseDNS=
DHCPv6Client= DHCPv6Client=
UseAutonomousPrefix= UseAutonomousPrefix=
UseOnLinkPrefix= UseOnLinkPrefix=
DenyList=
BlackList= BlackList=
[DHCPServer] [DHCPServer]
EmitNTP= EmitNTP=

2
test/fuzz/fuzz-network-parser/oss-fuzz-15678
View file

@ -1,2 +1,2 @@
[IPv6AcceptRA] [IPv6AcceptRA]
BlackList=70:: 70:: DenyList=70:: 70::

0
test/test-execute/exec-restrictnamespaces-mnt-blacklist.service → test/test-execute/exec-restrictnamespaces-mnt-deny-list.service
View file