picnoir
/
glibc
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
glibc/string
History
Noah Goldstein 2c9af8421d x86: Fix page cross case in rawmemchr-avx2 [BZ #29234] 
commit 6dcbb7d95d
Author: Noah Goldstein <goldstein.w.n@gmail.com>
Date:   Mon Jun 6 21:11:33 2022 -0700

    x86: Shrink code size of memchr-avx2.S

Changed how the page cross case aligned string (rdi) in
rawmemchr. This was incompatible with how
`L(cross_page_continue)` expected the pointer to be aligned and
would cause rawmemchr to read data start started before the
beginning of the string. What it would read was in valid memory
but could count CHAR matches resulting in an incorrect return
value.

This commit fixes that issue by essentially reverting the changes to
the L(page_cross) case as they didn't really matter.

Test cases added and all pass with the new code (and where confirmed
to fail with the old code).
Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
 		2022-06-08 17:07:34 -07:00
..
bits string.h: fix __fortified_attr_access macro call [BZ #29162] 2022-05-23 13:56:43 +05:30
Depend
…
Makefile string: Sort headers, routines, tests and tests-translation 2022-02-05 16:42:17 -08:00
Versions String: Add support for __memcmpeq() ABI on all targets 2021-10-26 16:51:29 -05:00
_strerror.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
argz-addsep.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
argz-append.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
argz-count.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
argz-create.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
argz-ctsep.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
argz-delete.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
argz-extract.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
argz-insert.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
argz-next.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
argz-replace.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
argz-stringify.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
argz.h Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
basename.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
bcopy.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
bug-envz1.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
bug-strcoll1.c
…
bug-strcoll2.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
bug-strncat1.c Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
bug-strpbrk1.c Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
bug-strspn1.c Remove "Contributed by" lines 2021-09-03 22:06:44 +05:30
bug-strtok1.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
byteswap.h Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
bzero.c ia64: Remove bzero optimization 2022-02-23 14:18:17 -03:00
endian.h Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
envz.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
envz.h Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
explicit_bzero.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
ffs.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
ffsll.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
inl-tester.c
…
memccpy.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
memchr.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
memcmp.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
memcmpeq.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
memcpy.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
memfrob.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
memmem.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
memmove.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
memory.h Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
mempcpy.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
memrchr.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
memset.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
noinl-tester.c
…
rawmemchr.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
sigabbrev_np.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
sigdescr_np.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
stpcpy.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
stpncpy.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
str-two-way.h Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
stratcliff.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
strcasecmp.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
strcasecmp_l.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
strcasestr.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
strcat.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
strchr.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
strchrnul.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
strcmp.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
strcoll.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
strcoll_l.c Replace {u}int_fast{16|32} with {u}int32_t 2022-04-13 21:23:04 -05:00
strcpy.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
strcspn.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
strdup.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
strerror.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
strerror_l.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
strerrordesc_np.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
strerrorname_np.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
strfry.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
string-inlines.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
string.h string.h: Fix boolean spelling in comments 2022-06-03 10:22:38 -07:00
strings.h Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
strlen.c string: Replace outdated comments in strlen(). 2022-04-09 11:45:31 -05:00
strncase.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
strncase_l.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
strncat.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
strncmp.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
strncpy.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
strndup.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
strnlen.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
strpbrk.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
strrchr.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
strsep.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
strsignal.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
strspn.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
strstr.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
strtok.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
strtok_r.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
strverscmp.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
strxfrm.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
strxfrm_l.c Replace {u}int_fast{16|32} with {u}int32_t 2022-04-13 21:23:04 -05:00
swab.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
test-bcopy.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
test-bzero.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
test-endian-file-scope.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
test-endian-sign-conversion.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
test-endian-types.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
test-explicit_bzero.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
test-ffs.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
test-memccpy.c tests/string: Drop simple/stupid/builtin tests 2022-04-06 20:53:24 +05:30
test-memchr.c tests/string: Drop simple/stupid/builtin tests 2022-04-06 20:53:24 +05:30
test-memcmp.c tests/string: Drop simple/stupid/builtin tests 2022-04-06 20:53:24 +05:30
test-memcmpeq.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
test-memcpy-large.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
test-memcpy-support.h tests/string: Drop simple/stupid/builtin tests 2022-04-06 20:53:24 +05:30
test-memcpy.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
test-memmem.c tests/string: Drop simple/stupid/builtin tests 2022-04-06 20:53:24 +05:30
test-memmove.c tests/string: Drop simple/stupid/builtin tests 2022-04-06 20:53:24 +05:30
test-mempcpy.c tests/string: Drop simple/stupid/builtin tests 2022-04-06 20:53:24 +05:30
test-memrchr.c tests/string: Drop simple/stupid/builtin tests 2022-04-06 20:53:24 +05:30
test-memset.c tests/string: Drop simple/stupid/builtin tests 2022-04-06 20:53:24 +05:30
test-rawmemchr.c x86: Fix page cross case in rawmemchr-avx2 [BZ #29234] 2022-06-08 17:07:34 -07:00
test-sig_np.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
test-stpcpy.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
test-stpncpy.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
test-strcasecmp.c tests/string: Drop simple/stupid/builtin tests 2022-04-06 20:53:24 +05:30
test-strcasestr.c tests/string: Drop simple/stupid/builtin tests 2022-04-06 20:53:24 +05:30
test-strcat.c tests/string: Drop simple/stupid/builtin tests 2022-04-06 20:53:24 +05:30
test-strchr.c tests/string: Drop simple/stupid/builtin tests 2022-04-06 20:53:24 +05:30
test-strchrnul.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
test-strcmp.c tests/string: Drop simple/stupid/builtin tests 2022-04-06 20:53:24 +05:30
test-strcpy.c tests/string: Drop simple/stupid/builtin tests 2022-04-06 20:53:24 +05:30
test-strcspn.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
test-strerror-errno.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
test-string.h Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
test-strlen.c tests/string: Drop simple/stupid/builtin tests 2022-04-06 20:53:24 +05:30
test-strncasecmp.c tests/string: Drop simple/stupid/builtin tests 2022-04-06 20:53:24 +05:30
test-strncat.c tests/string: Drop simple/stupid/builtin tests 2022-04-06 20:53:24 +05:30
test-strncmp.c tests/string: Drop simple/stupid/builtin tests 2022-04-06 20:53:24 +05:30
test-strncpy.c tests/string: Drop simple/stupid/builtin tests 2022-04-06 20:53:24 +05:30
test-strnlen.c String: Improve overflow test coverage for strnlen 2022-05-25 14:23:54 -07:00
test-strpbrk.c tests/string: Drop simple/stupid/builtin tests 2022-04-06 20:53:24 +05:30
test-strrchr.c tests/string: Drop simple/stupid/builtin tests 2022-04-06 20:53:24 +05:30
test-strspn.c tests/string: Drop simple/stupid/builtin tests 2022-04-06 20:53:24 +05:30
test-strstr.c tests/string: Drop simple/stupid/builtin tests 2022-04-06 20:53:24 +05:30
testcopy.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tester.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-bswap.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-cmp.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-endian.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
tst-inlcall.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-memmove-overflow.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-strcoll-overflow.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-strerror.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-strfry.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
tst-strlen.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
tst-strsignal.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-strtok.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
tst-strtok_r.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
tst-strxfrm.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
tst-strxfrm2.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
tst-svc.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
tst-svc.expect * string/strverscmp.c (__strverscmp): Fix last cleanups. 2009-04-07 06:51:59 +00:00
tst-svc.input * string/strverscmp.c (__strverscmp): Fix last cleanups. 2009-04-07 06:51:59 +00:00
tst-svc2.c Update string tests to use the support test driver. 2017-03-23 11:32:29 -03:00
tst-xbzero-opt.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
wordcopy.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00
xpg-strerror.c Update copyright dates with scripts/update-copyrights 2022-01-01 11:40:24 -08:00