picnoir/glibc
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity
glibc/string/test-strncasecmp.c
Siddhesh Poyarekar 67e3b0c63c tests/string: Drop simple/stupid/builtin tests 
In most cases the simple/stupid/builtin functions were in there to
benchmark optimized implementations against.  Only in some cases the
functions are used to check expected results.

Remove these tests from IMPL() and only keep them in wherever they're
used for a specific purpose, e.g. to generate expected results.

This improves timing of `make subdirs=string` by over a minute and a
half (over 15%) on a Whiskey Lake laptop.

Signed-off-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
Reviewed-by: Noah Goldstein <libc-alpha@sourceware.org>
2022-04-06 20:53:24 +05:30

516 lines
15 KiB
C
Raw Blame History

/* Test and measure strncasecmp functions.
Copyright (C) 1999-2022 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
version 2.1 of the License, or (at your option) any later version.
The GNU C Library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Lesser General Public License for more details.
You should have received a copy of the GNU Lesser General Public
License along with the GNU C Library; if not, see
<https://www.gnu.org/licenses/>. */
#include <locale.h>
#include <ctype.h>
#define TEST_LEN (getpagesize () * 3)
#define MIN_PAGE_SIZE (TEST_LEN + 2 * getpagesize ())
#define TEST_MAIN
#define TEST_NAME "strncasecmp"
#define TIMEOUT (5 * 60)
#include "test-string.h"
typedef int (*proto_t) (const char *, const char *, size_t);
static int simple_strncasecmp (const char *, const char *, size_t);
IMPL (strncasecmp, 1)
/* Naive implementation to verify results. */
static int
simple_strncasecmp (const char *s1, const char *s2, size_t n)
{
int ret;
if (n == 0)
return 0;
while ((ret = ((unsigned char) tolower (*s1)
- (unsigned char) tolower (*s2))) == 0
&& *s1++)
{
if (--n == 0)
return 0;
++s2;
}
return ret;
}
static int
check_result (impl_t *impl, const char *s1, const char *s2, size_t n,
int exp_result)
{
int result = CALL (impl, s1, s2, n);
if ((exp_result == 0 && result != 0)
|| (exp_result < 0 && result >= 0)
|| (exp_result > 0 && result <= 0))
{
error (0, 0, "Wrong result in function %s %d %d", impl->name,
result, exp_result);
ret = 1;
return -1;
}
return 0;
}
static void
do_one_test (impl_t *impl, const char *s1, const char *s2, size_t n,
int exp_result)
{
if (check_result (impl, s1, s2, n, exp_result) < 0)
return;
}
static void
do_test (size_t align1, size_t align2, size_t n, size_t len, int max_char,
int exp_result)
{
size_t i;
char *s1, *s2;
if (len == 0)
return;
align1 &= getpagesize () - 1;
if (align1 + (len + 2) >= page_size)
return;
align2 &= getpagesize () - 1;
if (align2 + (len + 2) >= page_size)
return;
s1 = (char *) (buf1 + align1);
s2 = (char *) (buf2 + align2);
for (i = 0; i < len; i++)
{
s1[i] = toupper (1 + 23 * i % max_char);
s2[i] = tolower (s1[i]);
}
s1[len] = s2[len] = 0;
s1[len + 1] = 23;
s2[len + 1] = 24 + exp_result;
if ((s2[len - 1] == 'z' && exp_result == -1)
|| (s2[len - 1] == 'a' && exp_result == 1))
s1[len - 1] += exp_result;
else if ((s1[len - 1] == 'Z' + 1 && exp_result == 1)
|| (s1[len - 1] == 'A' - 1 && exp_result == -1))
s1[len - 1] = tolower (s2[len - 1]) + exp_result;
else
s2[len - 1] -= exp_result;
/* For some locals this is not guranteed yet. */
if (tolower (s1[len - 1]) - tolower (s2[len - 1]) != exp_result)
{
if (exp_result == -1)
{
s1[len - 1] = tolower ('a');
s2[len - 1] = toupper (tolower ('a') - 1);
}
else if (exp_result == 0)
s1[len - 1] = toupper (s2[len - 1]);
else
{
s1[len - 1] = tolower ('a');
s2[len - 1] = toupper (tolower ('a') + 1);
}
}
FOR_EACH_IMPL (impl, 0)
do_one_test (impl, s1, s2, n, exp_result);
}
static void
do_page_tests (void)
{
char *s1, *s2;
int exp_result;
const size_t maxoffset = 64;
s1 = (char *) buf1 + BUF1PAGES * page_size - maxoffset;
memset (s1, 'a', maxoffset - 1);
s1[maxoffset - 1] = '\0';
s2 = (char *) buf2 + page_size - maxoffset;
memset (s2, 'a', maxoffset - 1);
s2[maxoffset - 1] = '\0';
/* At this point s1 and s2 point to distinct memory regions containing
"aa..." with size of 63 plus '\0'. Also, both strings are bounded to a
page with read/write access and the next page is protected with PROT_NONE
(meaning that any access outside of the page regions will trigger an
invalid memory access).
The loop checks for all possible offsets up to maxoffset for both
inputs with a size larger than the string (so memory access outside
the expected memory regions might trigger invalid access). */
for (size_t off1 = 0; off1 < maxoffset; off1++)
{
for (size_t off2 = 0; off2 < maxoffset; off2++)
{
exp_result = (off1 == off2)
? 0
: off1 < off2
? 'a'
: -'a';
FOR_EACH_IMPL (impl, 0)
check_result (impl, s1 + off1, s2 + off2, maxoffset + 1,
exp_result);
}
}
}
static void
do_random_tests (void)
{
size_t i, j, n, align1, align2, pos, len1, len2;
int result;
long r;
unsigned char *p1 = buf1 + page_size - 512;
unsigned char *p2 = buf2 + page_size - 512;
for (n = 0; n < ITERATIONS; n++)
{
align1 = random () & 31;
if (random () & 1)
align2 = random () & 31;
else
align2 = align1 + (random () & 24);
pos = random () & 511;
j = align1 > align2 ? align1 : align2;
if (pos + j >= 511)
pos = 510 - j - (random () & 7);
len1 = random () & 511;
if (pos >= len1 && (random () & 1))
len1 = pos + (random () & 7);
if (len1 + j >= 512)
len1 = 511 - j - (random () & 7);
if (pos >= len1)
len2 = len1;
else
len2 = len1 + (len1 != 511 - j ? random () % (511 - j - len1) : 0);
j = (pos > len2 ? pos : len2) + align1 + 64;
if (j > 512)
j = 512;
for (i = 0; i < j; ++i)
{
p1[i] = tolower (random () & 255);
if (i < len1 + align1 && !p1[i])
{
p1[i] = tolower (random () & 255);
if (!p1[i])
p1[i] = tolower (1 + (random () & 127));
}
}
for (i = 0; i < j; ++i)
{
p2[i] = toupper (random () & 255);
if (i < len2 + align2 && !p2[i])
{
p2[i] = toupper (random () & 255);
if (!p2[i])
toupper (p2[i] = 1 + (random () & 127));
}
}
result = 0;
memcpy (p2 + align2, p1 + align1, pos);
if (pos < len1)
{
if (tolower (p2[align2 + pos]) == p1[align1 + pos])
{
p2[align2 + pos] = toupper (random () & 255);
if (tolower (p2[align2 + pos]) == p1[align1 + pos])
p2[align2 + pos] = toupper (p1[align1 + pos]
+ 3 + (random () & 127));
}
if (p1[align1 + pos] < tolower (p2[align2 + pos]))
result = -1;
else
result = 1;
}
p1[len1 + align1] = 0;
p2[len2 + align2] = 0;
FOR_EACH_IMPL (impl, 1)
{
r = CALL (impl, (char *) (p1 + align1), (char *) (p2 + align2),
pos + 1 + (random () & 255));
/* Test whether on 64-bit architectures where ABI requires
callee to promote has the promotion been done. */
asm ("" : "=g" (r) : "0" (r));
if ((r == 0 && result)
|| (r < 0 && result >= 0)
|| (r > 0 && result <= 0))
{
error (0, 0, "Iteration %zd - wrong result in function %s (%zd, %zd, %zd, %zd, %zd) %ld != %d, p1 %p p2 %p",
n, impl->name, align1, align2, len1, len2, pos, r, result, p1, p2);
ret = 1;
}
}
}
}
/* Regression test for BZ #12205 */
static void
bz12205 (void)
{
static char cp [4096+16] __attribute__ ((aligned(4096)));
static char gotrel[4096] __attribute__ ((aligned(4096)));
char *s1 = cp + 0xffa;
char *s2 = gotrel + 0xcbe;
int exp_result;
size_t n = 6;
strcpy (s1, "gottpoff");
strcpy (s2, "GOTPLT");
exp_result = simple_strncasecmp (s1, s2, n);
FOR_EACH_IMPL (impl, 0)
check_result (impl, s1, s2, n, exp_result);
}
/* Regression test for BZ #14195 */
static void
bz14195 (void)
{
const char *empty_string = "";
FOR_EACH_IMPL (impl, 0)
check_result (impl, empty_string, "", 5, 0);
}
static void
test_locale (const char *locale, int extra_tests)
{
size_t i, j, k;
const size_t test_len = MIN(TEST_LEN, 3 * 4096);
if (setlocale (LC_CTYPE, locale) == NULL)
{
error (0, 0, "cannot set locale \"%s\"", locale);
ret = 1;
}
bz12205 ();
bz14195 ();
printf ("%23s", locale);
FOR_EACH_IMPL (impl, 0)
printf ("\t%s", impl->name);
putchar ('\n');
for (i = 1; i < 16; ++i)
{
do_test (i, i, i - 1, i, 127, 0);
do_test (i, i, i, i, 127, 0);
do_test (i, i, i, i, 127, 1);
do_test (i, i, i, i, 127, -1);
do_test (i, i, i + 1, i, 127, 0);
do_test (i, i, i + 1, i, 127, 1);
do_test (i, i, i + 1, i, 127, -1);
}
for (i = 1; i < 10; ++i)
{
do_test (0, 0, (2 << i) - 1, 2 << i, 127, 0);
do_test (0, 0, 2 << i, 2 << i, 254, 0);
do_test (0, 0, (2 << i) + 1, 2 << i, 127, 0);
do_test (0, 0, (2 << i) + 1, 2 << i, 254, 0);
do_test (0, 0, 2 << i, 2 << i, 127, 1);
do_test (0, 0, (2 << i) + 10, 2 << i, 127, 1);
do_test (0, 0, 2 << i, 2 << i, 254, 1);
do_test (0, 0, (2 << i) + 10, 2 << i, 254, 1);
do_test (0, 0, 2 << i, 2 << i, 127, -1);
do_test (0, 0, (2 << i) + 10, 2 << i, 127, -1);
do_test (0, 0, 2 << i, 2 << i, 254, -1);
do_test (0, 0, (2 << i) + 10, 2 << i, 254, -1);
}
for (i = 1; i < 8; ++i)
{
do_test (i, 2 * i, (8 << i) - 1, 8 << i, 127, 0);
do_test (i, 2 * i, 8 << i, 8 << i, 127, 0);
do_test (i, 2 * i, (8 << i) + 100, 8 << i, 127, 0);
do_test (2 * i, i, (8 << i) - 1, 8 << i, 254, 0);
do_test (2 * i, i, 8 << i, 8 << i, 254, 0);
do_test (2 * i, i, (8 << i) + 100, 8 << i, 254, 0);
do_test (i, 2 * i, 8 << i, 8 << i, 127, 1);
do_test (i, 2 * i, (8 << i) + 100, 8 << i, 127, 1);
do_test (2 * i, i, 8 << i, 8 << i, 254, 1);
do_test (2 * i, i, (8 << i) + 100, 8 << i, 254, 1);
do_test (i, 2 * i, 8 << i, 8 << i, 127, -1);
do_test (i, 2 * i, (8 << i) + 100, 8 << i, 127, -1);
do_test (2 * i, i, 8 << i, 8 << i, 254, -1);
do_test (2 * i, i, (8 << i) + 100, 8 << i, 254, -1);
}
for (j = 0; extra_tests && j < 160; ++j)
{
for (i = 0; i < test_len;)
{
do_test (getpagesize () - j - 1, 0, i + 1, i, 127, 0);
do_test (getpagesize () - j - 1, 0, i + 1, i, 127, 1);
do_test (getpagesize () - j - 1, 0, i + 1, i, 127, -1);
do_test (getpagesize () - j - 1, 0, i, i, 127, 0);
do_test (getpagesize () - j - 1, 0, i - 1, i, 127, 0);
do_test (getpagesize () - j - 1, 0, ULONG_MAX, i, 127, 0);
do_test (getpagesize () - j - 1, 0, ULONG_MAX, i, 127, 1);
do_test (getpagesize () - j - 1, 0, ULONG_MAX, i, 127, -1);
do_test (getpagesize () - j - 1, 0, ULONG_MAX - i, i, 127, 0);
do_test (getpagesize () - j - 1, 0, ULONG_MAX - i, i, 127, 1);
do_test (getpagesize () - j - 1, 0, ULONG_MAX - i, i, 127, -1);
do_test (getpagesize () - j - 1, j, i + 1, i, 127, 0);
do_test (getpagesize () - j - 1, j, i + 1, i, 127, 1);
do_test (getpagesize () - j - 1, j, i + 1, i, 127, -1);
do_test (getpagesize () - j - 1, j, i, i, 127, 0);
do_test (getpagesize () - j - 1, j, i - 1, i, 127, 0);
do_test (getpagesize () - j - 1, j, ULONG_MAX, i, 127, 0);
do_test (getpagesize () - j - 1, j, ULONG_MAX, i, 127, 1);
do_test (getpagesize () - j - 1, j, ULONG_MAX, i, 127, -1);
do_test (getpagesize () - j - 1, j, ULONG_MAX - i, i, 127, 0);
do_test (getpagesize () - j - 1, j, ULONG_MAX - i, i, 127, 1);
do_test (getpagesize () - j - 1, j, ULONG_MAX - i, i, 127, -1);
do_test (0, getpagesize () - j - 1, i + 1, i, 127, 0);
do_test (0, getpagesize () - j - 1, i + 1, i, 127, 1);
do_test (0, getpagesize () - j - 1, i + 1, i, 127, -1);
do_test (0, getpagesize () - j - 1, i, i, 127, 0);
do_test (0, getpagesize () - j - 1, i - 1, i, 127, 0);
do_test (0, getpagesize () - j - 1, ULONG_MAX, i, 127, 0);
do_test (0, getpagesize () - j - 1, ULONG_MAX, i, 127, 1);
do_test (0, getpagesize () - j - 1, ULONG_MAX, i, 127, -1);
do_test (0, getpagesize () - j - 1, ULONG_MAX - i, i, 127, 0);
do_test (0, getpagesize () - j - 1, ULONG_MAX - i, i, 127, 1);
do_test (0, getpagesize () - j - 1, ULONG_MAX - i, i, 127, -1);
do_test (j, getpagesize () - j - 1, i + 1, i, 127, 0);
do_test (j, getpagesize () - j - 1, i + 1, i, 127, 1);
do_test (j, getpagesize () - j - 1, i + 1, i, 127, -1);
do_test (j, getpagesize () - j - 1, i, i, 127, 0);
do_test (j, getpagesize () - j - 1, i - 1, i, 127, 0);
do_test (j, getpagesize () - j - 1, ULONG_MAX, i, 127, 0);
do_test (j, getpagesize () - j - 1, ULONG_MAX, i, 127, 1);
do_test (j, getpagesize () - j - 1, ULONG_MAX, i, 127, -1);
do_test (j, getpagesize () - j - 1, ULONG_MAX - i, i, 127, 0);
do_test (j, getpagesize () - j - 1, ULONG_MAX - i, i, 127, 1);
do_test (j, getpagesize () - j - 1, ULONG_MAX - i, i, 127, -1);
for (k = 2; k <= 128; k += k)
{
do_test (getpagesize () - k, getpagesize () - j - 1, i - 1, i,
127, 0);
do_test (getpagesize () - k - 1, getpagesize () - j - 1, i - 1,
i, 127, 0);
do_test (getpagesize () - k, getpagesize () - j - 1, i + 1, i,
127, 0);
do_test (getpagesize () - k - 1, getpagesize () - j - 1, i + 1,
i, 127, 0);
do_test (getpagesize () - k, getpagesize () - j - 1, i, i, 127,
0);
do_test (getpagesize () - k - 1, getpagesize () - j - 1, i, i,
127, 0);
do_test (getpagesize () - k, getpagesize () - j - 1, i + 1, i,
127, -1);
do_test (getpagesize () - k - 1, getpagesize () - j - 1, i + 1,
i, 127, -1);
do_test (getpagesize () - k, getpagesize () - j - 1, i + 1, i,
127, 1);
do_test (getpagesize () - k - 1, getpagesize () - j - 1, i + 1,
i, 127, 1);
}
if (i < 32)
{
i += 1;
}
else if (i < 161)
{
i += 7;
}
else if (i + 161 < test_len)
{
i += 31;
i *= 17;
i /= 16;
if (i + 161 > test_len)
{
i = test_len - 160;
}
}
else if (i + 32 < test_len)
{
i += 7;
}
else
{
i += 1;
}
}
}
do_random_tests ();
do_page_tests ();
}
int
test_main (void)
{
test_init ();
test_locale ("C", 1);
test_locale ("en_US.ISO-8859-1", 0);
test_locale ("en_US.UTF-8", 0);
test_locale ("tr_TR.ISO-8859-9", 0);
test_locale ("tr_TR.UTF-8", 0);
return ret;
}
#include <support/test-driver.c>
Reference in a new issue View git blame Copy permalink