picnoir/glibc
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity
glibc/libio
History
Zack Weinberg 4e2f43f842 Use PRINTF_FORTIFY instead of _IO_FLAGS2_FORTIFY (bug 11319) 
The _chk variants of all of the printf functions become much simpler.
This is the last thing that we needed _IO_acquire_lock_clear_flags2
for, so it can go as well.  I took the opportunity to make the headers
included and the names of all local variables consistent across all the
affected files.

Since we ultimately want to get rid of __no_long_double as well, it
must be possible to get all of the nontrivial effects of the _chk
functions by calling the _internal functions with appropriate flags.
For most of the __(v)xprintf_chk functions, this is covered by
PRINTF_FORTIFY plus some up-front argument checks that can be
duplicated.  However, __(v)sprintf_chk installs a custom jump table so
that it can crash instead of overflowing the output buffer.  This
functionality is moved to __vsprintf_internal, which now has a
'maxlen' argument like __vsnprintf_internal; to get the unsafe
behavior of ordinary (v)sprintf, pass -1 for that argument.

obstack_printf_chk and obstack_vprintf_chk are no longer in the same
file.

As a side-effect of the unification of both fortified and non-fortified
vdprintf initialization, this patch fixes bug 11319 for __dprintf_chk
and __vdprintf_chk, which was previously fixed only for dprintf and
vdprintf by the commit

commit 7ca890b88e
Author: Ulrich Drepper <drepper@redhat.com>
Date:   Wed Feb 24 16:07:57 2010 -0800

    Fix reporting of I/O errors in *dprintf functions.

This patch adds a test case to avoid regressions.

Tested for powerpc and powerpc64le.
2018-12-05 18:15:43 -02:00
..
bits Remove _IO_file_flags define. 2018-02-21 14:22:50 -05:00
__fbufsize.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
__flbf.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
__fpending.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
__fpurge.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
__freadable.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
__freading.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
__fsetlocking.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
__fwritable.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
__fwriting.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
bug-fopena+.c
bug-fseek.c
bug-ftell.c
bug-memstream1.c Add missing header files throughout the testsuite. 2017-02-16 17:33:18 -05:00
bug-mmap-fflush.c
bug-rewind.c Fix warnings in fwscanf / rewind tests. 2014-11-26 12:54:39 +00:00
bug-rewind2.c Fix warnings in fwscanf / rewind tests. 2014-11-26 12:54:39 +00:00
bug-ungetc.c
bug-ungetc2.c
bug-ungetc3.c
bug-ungetc4.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
bug-ungetwc1.c Fix libio/bug-ungetwc1.c warning. 2014-11-27 16:01:04 +00:00
bug-ungetwc2.c
bug-wfflush.c
bug-wmemstream1.c Add missing header files throughout the testsuite. 2017-02-16 17:33:18 -05:00
bug-wsetpos.c
clearerr.c Remove miscellaneous debris from libio. 2018-02-21 14:39:54 -05:00
clearerr_u.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
Depend
fcloseall.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
feof.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
feof_u.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
ferror.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
ferror_u.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
filedoalloc.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
fileno.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
fileops.c [BZ 1190] Make EOF sticky in stdio. 2018-03-13 08:31:56 -04:00
fmemopen.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
fputc.c Remove miscellaneous debris from libio. 2018-02-21 14:39:54 -05:00
fputc_u.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
fputwc.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
fputwc_u.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
freopen.c libio: Flush stream at freopen (BZ#21037) 2018-10-02 10:01:56 -03:00
freopen64.c libio: Flush stream at freopen (BZ#21037) 2018-10-02 10:01:56 -03:00
fseek.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
fseeko.c libio: Implement internal function __libc_readline_unlocked 2018-07-06 17:52:54 +02:00
fseeko64.c libio: Implement internal function __libc_readline_unlocked 2018-07-06 17:52:54 +02:00
ftello.c libio: Implement internal function __libc_readline_unlocked 2018-07-06 17:52:54 +02:00
ftello64.c libio: Implement internal function __libc_readline_unlocked 2018-07-06 17:52:54 +02:00
fwide.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
fwprintf.c Add __v*printf_internal with flags arguments 2018-12-05 18:15:42 -02:00
fwscanf.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
genops.c Remove miscellaneous debris from libio. 2018-02-21 14:39:54 -05:00
getc.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
getc_u.c Fix -Os getc_unlocked linknamespace, localplt issues (bug 15105, bug 19463). 2018-02-21 18:01:11 +00:00
getchar.c Remove miscellaneous debris from libio. 2018-02-21 14:39:54 -05:00
getchar_u.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
getwc.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
getwc_u.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
getwchar.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
getwchar_u.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
iofclose.c Remove _IO_file_flags define. 2018-02-21 14:22:50 -05:00
iofdopen.c Remove miscellaneous debris from libio. 2018-02-21 14:39:54 -05:00
iofflush.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
iofflush_u.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
iofgetpos.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
iofgetpos64.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
iofgets.c Remove _IO_file_flags define. 2018-02-21 14:22:50 -05:00
iofgets_u.c Remove _IO_file_flags define. 2018-02-21 14:22:50 -05:00
iofgetws.c Remove _IO_file_flags define. 2018-02-21 14:22:50 -05:00
iofgetws_u.c Remove _IO_file_flags define. 2018-02-21 14:22:50 -05:00
iofopen.c Remove legacy configuration knobs from libio. 2018-02-21 14:13:21 -05:00
iofopen64.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
iofopncook.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
iofputs.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
iofputs_u.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
iofputws.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
iofputws_u.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
iofread.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
iofread_u.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
iofsetpos.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
iofsetpos64.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
ioftell.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
iofwide.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
iofwrite.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
iofwrite_u.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
iogetdelim.c Remove miscellaneous debris from libio. 2018-02-21 14:39:54 -05:00
iogetline.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
iogets.c Remove _IO_file_flags define. 2018-02-21 14:22:50 -05:00
iogetwline.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
iolibio.h Add __v*printf_internal with flags arguments 2018-12-05 18:15:42 -02:00
iopadn.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
iopopen.c posix: Use posix_spawn on popen 2018-11-30 18:42:05 -02:00
ioputs.c hurd: Avoid more libc.so local PLTs 2018-04-03 00:36:33 +00:00
ioseekoff.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
ioseekpos.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
iosetbuffer.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
iosetvbuf.c Remove _IO_file_flags define. 2018-02-21 14:22:50 -05:00
ioungetc.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
ioungetwc.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
iovdprintf.c Add __v*printf_internal with flags arguments 2018-12-05 18:15:42 -02:00
iovsprintf.c Use PRINTF_FORTIFY instead of _IO_FLAGS2_FORTIFY (bug 11319) 2018-12-05 18:15:43 -02:00
iovsscanf.c Add __vfscanf_internal and __vfwscanf_internal with flags arguments. 2018-12-05 18:15:42 -02:00
iovswscanf.c Add __vfscanf_internal and __vfwscanf_internal with flags arguments. 2018-12-05 18:15:42 -02:00
iowpadn.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
libc_fatal.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
libio.h Use PRINTF_FORTIFY instead of _IO_FLAGS2_FORTIFY (bug 11319) 2018-12-05 18:15:43 -02:00
libioP.h Use PRINTF_FORTIFY instead of _IO_FLAGS2_FORTIFY (bug 11319) 2018-12-05 18:15:43 -02:00
Makefile libio: Flush stream at freopen (BZ#21037) 2018-10-02 10:01:56 -03:00
memstream.c libio: Avoid _allocate_buffer, _free_buffer function pointers [BZ #23236] 2018-06-01 10:41:03 +02:00
obprintf.c Add __v*printf_internal with flags arguments 2018-12-05 18:15:42 -02:00
oldfileops.c [BZ 1190] Make EOF sticky in stdio. 2018-03-13 08:31:56 -04:00
oldfmemopen.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
oldiofclose.c Remove _IO_file_flags define. 2018-02-21 14:22:50 -05:00
oldiofdopen.c Remove miscellaneous debris from libio. 2018-02-21 14:39:54 -05:00
oldiofgetpos.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
oldiofgetpos64.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
oldiofopen.c Remove legacy configuration knobs from libio. 2018-02-21 14:13:21 -05:00
oldiofsetpos.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
oldiofsetpos64.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
oldiopopen.c Remove legacy configuration knobs from libio. 2018-02-21 14:13:21 -05:00
oldpclose.c Remove miscellaneous debris from libio. 2018-02-21 14:39:54 -05:00
oldstdfiles.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
oldtmpfile.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
pclose.c Remove miscellaneous debris from libio. 2018-02-21 14:39:54 -05:00
peekc.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
putc.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
putc_u.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
putchar.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
putchar_u.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
putwc.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
putwc_u.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
putwchar.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
putwchar_u.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
readline.c Fix copyright years in recent commits 2018-07-10 11:03:08 +02:00
rewind.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
setbuf.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
setlinebuf.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
stdfiles.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
stdio.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
stdio.h Add renameat2 function [BZ #17662] 2018-07-05 19:00:10 +02:00
strfile.h Add __vfscanf_internal and __vfwscanf_internal with flags arguments. 2018-12-05 18:15:42 -02:00
strops.c libio: Avoid _allocate_buffer, _free_buffer function pointers [BZ #23236] 2018-06-01 10:41:03 +02:00
swprintf.c Add __v*printf_internal with flags arguments 2018-12-05 18:15:42 -02:00
swscanf.c Add __vfscanf_internal and __vfwscanf_internal with flags arguments. 2018-12-05 18:15:42 -02:00
test-fmemopen.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
test-freopen.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
test-freopen.sh Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
tst-atime.c Don't reduce test timeout to less than default 2018-10-17 09:34:13 +02:00
tst-bz22415.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
tst-eof.c
tst-ext.c
tst-ext2.c
tst-fgetc-after-eof.c [BZ 1190] Make EOF sticky in stdio. 2018-03-13 08:31:56 -04:00
tst-fgetwc.c
tst-fgetwc.input
tst-fgetws.c
tst-fopenloc.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
tst-fopenloc2.c
tst-fputws.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
tst-freopen.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
tst-fseek.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
tst-ftell-active-handler.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
tst-ftell-append.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
tst-ftell-partial-wide.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
tst-fwrite-error.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
tst-memstream.h libio: Flush stream at freopen (BZ#21037) 2018-10-02 10:01:56 -03:00
tst-memstream1.c Add missing header files throughout the testsuite. 2017-02-16 17:33:18 -05:00
tst-memstream2.c Add missing header files throughout the testsuite. 2017-02-16 17:33:18 -05:00
tst-memstream3.c libio: Rename _FWRITE to FWRITE_FUNC 2018-01-29 23:00:17 +01:00
tst-memstream4.c libio: Flush stream at freopen (BZ#21037) 2018-10-02 10:01:56 -03:00
tst-mmap-eofsync.c Remove miscellaneous debris from libio. 2018-02-21 14:39:54 -05:00
tst-mmap-fflushsync.c
tst-mmap-offend.c
tst-mmap-setvbuf.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
tst-mmap2-eofsync.c 2016-06-11 Paul Pluzhnikov <ppluzhnikov@google.com> 2016-06-11 14:50:16 -07:00
tst-popen1.c
tst-readline.c Increase timeout of libio/tst-readline 2018-10-09 15:56:12 +01:00
tst-setvbuf1.c
tst-sscanf.c Modify several tests to use test-skeleton.c 2014-11-05 15:24:08 +05:30
tst-swscanf.c
tst-ungetwc1.c Modify several tests to use test-skeleton.c 2014-11-05 15:24:08 +05:30
tst-ungetwc2.c Modify several tests to use test-skeleton.c 2014-11-05 15:24:08 +05:30
tst-vtables-common.c support: Add signal support to support_capture_subprocess_check 2018-11-28 20:57:18 +01:00
tst-vtables-interposed.c libio: Add tst-vtables, tst-vtables-interposed 2018-06-26 12:31:08 +02:00
tst-vtables.c libio: Add tst-vtables, tst-vtables-interposed 2018-06-26 12:31:08 +02:00
tst-widetext.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
tst-widetext.input Finish change from “Bengali” to “Bangla” 2017-09-09 12:41:54 +02:00
tst-wmemstream1.c
tst-wmemstream2.c
tst-wmemstream3.c libio: Rename _FWRITE to FWRITE_FUNC 2018-01-29 23:00:17 +01:00
tst-wmemstream4.c libio: Flush stream at freopen (BZ#21037) 2018-10-02 10:01:56 -03:00
tst_getwc.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
tst_getwc.input
tst_putwc.c Update copyright dates with scripts/update-copyrights. 2018-01-01 00:32:25 +00:00
tst_swprintf.c
tst_swscanf.c
tst_wprintf.c
tst_wprintf2.c Add dependencies on needed locales in each subdir tests (bug 18969) 2015-10-12 15:18:08 +02:00
tst_wscanf.c
tst_wscanf.input
vasprintf.c Add __v*printf_internal with flags arguments 2018-12-05 18:15:42 -02:00
Versions libio: Implement internal function __libc_readline_unlocked 2018-07-06 17:52:54 +02:00
vscanf.c Add __vfscanf_internal and __vfwscanf_internal with flags arguments. 2018-12-05 18:15:42 -02:00
vsnprintf.c Add __v*printf_internal with flags arguments 2018-12-05 18:15:42 -02:00
vswprintf.c Add __v*printf_internal with flags arguments 2018-12-05 18:15:42 -02:00
vtables.c libio: Disable vtable validation in case of interposition [BZ #23313] 2018-06-26 10:24:52 +02:00
vwprintf.c Add __v*printf_internal with flags arguments 2018-12-05 18:15:42 -02:00
vwscanf.c Add __vfscanf_internal and __vfwscanf_internal with flags arguments. 2018-12-05 18:15:42 -02:00
wfiledoalloc.c Mechanically remove _IO_ name aliases for types and constants. 2018-02-21 14:11:05 -05:00
wfileops.c [BZ 1190] Make EOF sticky in stdio. 2018-03-13 08:31:56 -04:00
wgenops.c Remove miscellaneous debris from libio. 2018-02-21 14:39:54 -05:00
wmemstream.c libio: Avoid _allocate_buffer, _free_buffer function pointers [BZ #23236] 2018-06-01 10:41:03 +02:00
wprintf.c Add __v*printf_internal with flags arguments 2018-12-05 18:15:42 -02:00
wscanf.c Add __vfscanf_internal and __vfwscanf_internal with flags arguments. 2018-12-05 18:15:42 -02:00
wstrops.c libio: Avoid _allocate_buffer, _free_buffer function pointers [BZ #23236] 2018-06-01 10:41:03 +02:00