picnoir
/
my-repo-pins
mirror of https://github.com/NinjaTrappeur/my-repo-pins.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Errors: use user-error when relevant 

Error can open a edebug instance, which does not make a lot of sense
when the issue clearly comes from the user configuration. Replacing
these occurences with user-error instead.

https://github.com/melpa/melpa/pull/8093#issuecomment-1173207615
This commit is contained in:
Félix Baylac-Jacqué 2022-07-05 10:12:56 +02:00
parent 4f20fc55dc
commit b454f29682
No known key found for this signature in database
GPG Key ID: EFD315F31848DBA4
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
my-repo-pins.el
View File

@ -105,7 +105,7 @@ Errors out if we can't find it."
(let ((git-from-bin-path (locate-file my-repo-pins-git-bin exec-path)))
(if (file-executable-p git-from-bin-path)
git-from-bin-path
(error "Can't find git. Is my-repo-pins-git-bin correctly set?")))))
(user-error "Can't find git. Is my-repo-pins-git-bin correctly set?")))))
(defun my-repo-pins--call-git-in-dir (dir &optional callback &rest args)
"Call the git binary as pointed by ‘my-repo-pins-git-bin’ in DIR with ARGS.
@ -428,7 +428,7 @@ local directory"
"Ensure ‘my-repo-pins-code-root’ is correctly set, then canonalize the path.
Errors out if ‘my-repo-pins-code-root’ has not been set yet."
(progn (when (not my-repo-pins-code-root)
(error "My-Repo-Pins-code-root has not been set. Please point it to your code root"))
(user-error "My-Repo-Pins-code-root has not been set. Please point it to your code root"))
(expand-file-name (file-name-as-directory my-repo-pins-code-root))))
@ -757,7 +757,7 @@ TODO: split that mess before release. We shouldn't query here."
(progn
(my-repo-pins--update-forges-state ,forge-str new-state ,repo-query))))))))
my-repo-pins-forge-fetchers))
((equal repo-query-kind 'repo) (error "Can't checkout %s (for now), please specify a owner" repo-query))
((equal repo-query-kind 'repo) (user-error "Can't checkout %s (for now), please specify a owner" repo-query))
((equal repo-query-kind 'full-url)
(let*
((code-root (my-repo-pins--safe-get-code-root))