picnoir/Systemd
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
30936 commits 2 branches 0 tags 166 MiB
Commit graph

30936 commits

This branch
This branch
All branches
Author SHA1 Message Date
Lennart Poettering 6171b8225f core: drop specifier expansion when parsing transient dbus properties 
Specifier expansion (much like C escape handling) should be a helper for
writing unit files, but should be nothing we do on programatic APIs. For
those, the client can do the necessary replacements anyway, and we
really should be careful with doing such string processing of data we
get via lower level programmatic APIs.

We currently do specifier expansion only for the env var transient unit
APIs, no other properties do this. Let's remove it here too, to be fully
systematic.

Yes, in a way this is API breakage, but then again this API isn't
documented yet, and an outlier, hence let's clear this up now, before it
is too late.
 2017-11-29 12:32:53 +01:00
Yu Watanabe 3235b4e70c
Merge pull request #7492 from keszybz/coverity-fixes 
A few more cleanups based on coverity and valgrind
 2017-11-29 12:50:49 +09:00
Zbigniew Jędrzejewski-Szmek ae34a10bac udev/collect: use _cleanup_ in one more place 
This doesn't make the code pretty, but it at least makes it a tiny bit shorter.
 2017-11-28 21:34:50 +01:00
Zbigniew Jędrzejewski-Szmek 3176084ff2 udev/collect: remove dead conditional 
Coverity rightly says that 'word' is assigned to 'ptr', and 'word'
was assigned from 'ptr' (yikes) right after a non-null check.
 2017-11-28 21:34:50 +01:00
Zbigniew Jędrzejewski-Szmek 2504834861 journal: avoid undefined behaviour in float division by 0.0 
Coverity says that's undefined. I'm pretty sure we always would get a nan, but
let's avoid (formally) undefined behaviour since that can cause compilers to do
strange things.
 2017-11-28 21:34:50 +01:00
Zbigniew Jędrzejewski-Szmek b921fcb2ac networkd: fix memleak of Rules 
This was the issue mentioned in 93f9da6e0a.
 2017-11-28 21:34:50 +01:00
Zbigniew Jędrzejewski-Szmek f916819053 journal: use new helpers with journal_file_close 
journal_file_close_set() is not necessary anymore.
 2017-11-28 21:34:50 +01:00
Zbigniew Jędrzejewski-Szmek 1599f593d6 journal-remote: add helper function and use hashmap_free_with_destructor 2017-11-28 21:34:46 +01:00
Zbigniew Jędrzejewski-Szmek 6dd1c36839 cryptsetup-generator: add helper function and use hashmap_free_with_destructor 2017-11-28 21:34:41 +01:00
Zbigniew Jędrzejewski-Szmek 39ab16e397 coredump: fix typo and use hashmap_free_with_destructor 2017-11-28 21:34:34 +01:00
Zbigniew Jędrzejewski-Szmek e85b096b43 machine-image: convert image_hashmap_free() to an static inline helper 2017-11-28 21:30:43 +01:00
Zbigniew Jędrzejewski-Szmek 224b0e7ad0 Add set/hashmap helpers for non-trivial freeing and use where straighforward 
A macro is needed because otherwise we couldn't ensure type safety.
Some simple tests are included.
No functional change intended.
 2017-11-28 21:30:30 +01:00
Zbigniew Jędrzejewski-Szmek ec1d290903 Use hashmap_free_free where appropriate 2017-11-28 21:26:37 +01:00
Zbigniew Jędrzejewski-Szmek 5c4912ea61
Merge pull request #7490 from yuwata/test-basic 
add more tests for basic functions
 2017-11-28 18:15:30 +01:00
Susant Sahani fbdb6605b5 networkd: Add comment for setting_mtu #7460 (#7489) 
Follow up #7460
 2017-11-28 17:24:52 +01:00
Lennart Poettering 4de8d3f59e
Merge pull request #7486 from keszybz/coverity-fixes 
Fixes for issues spotted by coverity (and some cleanups)
 2017-11-28 15:04:11 +01:00
Yu Watanabe 23cc81e7c2 test-cap-list: add more tests about capability_set_{from,to}_string() 2017-11-28 22:17:00 +09:00
Yu Watanabe 4c1a95fd84 test: move tests about cap_list_cap() from test-cap-list to test-capability 2017-11-28 22:14:54 +09:00
Yu Watanabe db4bd5bd62 cap-list: check range of numeric value 2017-11-28 22:06:34 +09:00
Yu Watanabe 6b86b9e65d test-bitmap: add tests for bitmap_copy() 2017-11-28 20:34:36 +09:00
Yu Watanabe ade0eb2190 test-architecture: add more tests 2017-11-28 20:34:32 +09:00
Yu Watanabe f30788ee23 test-alloc-util: add tests for memdup_suffix0() and greedy_realloc() 2017-11-28 20:33:58 +09:00
Yu Watanabe a4e6e06bc7 tests: add tests for empty string 2017-11-28 20:21:25 +09:00
Yu Watanabe d40c54fe56 alloc-util: coding style fix 2017-11-28 20:21:15 +09:00
Lennart Poettering b39367a1a7
Merge pull request #7398 from keszybz/udev-list 
udev: use list.h instead of udev_list_node
 2017-11-28 11:35:02 +01:00
Lennart Poettering c9f034a10a
Merge pull request #7484 from poettering/sd-resolve-timeout 
timeout sd-resolve tests
 2017-11-28 11:33:38 +01:00
Zbigniew Jędrzejewski-Szmek ba77dac291 pid1: improve syntax in error message 2017-11-28 09:26:14 +01:00
Zbigniew Jędrzejewski-Szmek d387cfdddd pid1: clarify that min_max is always initialized 
read_one_line_file() always returns <= 0, so the code was OK, but let's write
the check a bit differently to make it obvious that min_max is always set.
 2017-11-28 09:26:14 +01:00
Zbigniew Jędrzejewski-Szmek 7beb3baf16 test-hostname-util: add assert_se's to make coverity happy 2017-11-28 09:26:14 +01:00
Zbigniew Jędrzejewski-Szmek c47a9f909a test-process-util: add (void) cast to make coverity happy 
The intent is for the call to succeed only when privileged, so make
that clear.
 2017-11-28 09:25:39 +01:00
Zbigniew Jędrzejewski-Szmek ca9b2b4dc1 test-fd-util: add assert_se to make coverity happy 2017-11-28 09:25:39 +01:00
Zbigniew Jędrzejewski-Szmek b0fe73d740 udevadm-monitor: add some assert_se's to make coverity happy 
We do that elsewhere and it's nice to be consistent.
 2017-11-28 09:25:38 +01:00
Zbigniew Jędrzejewski-Szmek 595c66a3db core/umount: use _cleanup_ in one more place 2017-11-28 09:25:38 +01:00
Zbigniew Jędrzejewski-Szmek 1a96c8e1cc sd-resolve: check that name fits in the specified packet length 
Coverity complained that we didn't check if the data is long enough.
 2017-11-28 09:25:38 +01:00
Zbigniew Jędrzejewski-Szmek 8d44f5a637 shim: fix logically dead code 
The alternate verification path could never be taken.

Found by coverity.
 2017-11-28 09:25:38 +01:00
Zbigniew Jędrzejewski-Szmek 1e40b7490a networkd: remove dead code 
Found by coverity.
 2017-11-28 09:25:38 +01:00
Zbigniew Jędrzejewski-Szmek ef51180b62 test-ndisc-ra: add assert_se() to make coverity happy 2017-11-28 09:25:38 +01:00
Zbigniew Jędrzejewski-Szmek 10a6e01eaa boot/shim: fix char ** vs char * mismatch 
This code cannot have ever worked ;(

Found by coverity, obvious when the type is not obfuscated to void*.
 2017-11-28 09:25:38 +01:00
Zbigniew Jędrzejewski-Szmek bceda88b52 boot/efi: fix NULL dereference 
The comment above makes the intent of the code pretty clear:
"use security2_protocol == NULL as indicator".
So revert the condition in the check and fix the logic in the comment while
at it.

The question is how this could have ever worked: if BS->LocateProtocol
(which is supposedly optional) ever failed, we'd crash here. Strange.

Found by coverity.
 2017-11-28 09:25:38 +01:00
Zbigniew Jędrzejewski-Szmek bdd73ac5c2 dissect-image: simplify check for passphrase presence 
m->encrypted is set when fstype=="crypto_LUKS", but this is not obvious when
reading decrypt_partition(). Just check if passphrase is set before using
it.
 2017-11-28 09:25:38 +01:00
Zbigniew Jędrzejewski-Szmek bbd1590085 networkd: fix reversed arguments 
Found by coverity.

Also drop unused return value while at it.
 2017-11-28 09:25:38 +01:00
Zbigniew Jędrzejewski-Szmek 93f9da6e0a networkd: plug some memleaks in rule serialization/deserialization 
This fixes the (mostly theoretical, since we're only parsing data that we write
ourselves) memleak when iif or oif is deserialized multiple times. Unfortunately
it does not fix the memleak when rule is freed, but that'll require a bigger
effort.
 2017-11-28 09:25:38 +01:00
Zbigniew Jędrzejewski-Szmek 9491f55f74 networkd: fix serialization of {Incoming,Outgoing}Interface 
Let's just say that the code wasn't fully functional ;(

Since we only had the parser for serialization, and not the writer, we are
free to change the format. So while at it, let's use shorter names in the
serialization format that match the surrounding style.
 2017-11-28 09:25:38 +01:00
Zbigniew Jędrzejewski-Szmek 7379f3de7f Add test-routing-policy-rule 2017-11-28 09:25:38 +01:00
Zbigniew Jędrzejewski-Szmek 6f349a4f9c test-network: use automatic cleanup 2017-11-28 09:25:38 +01:00
Zbigniew Jędrzejewski-Szmek e4aca57df8 networkd: parse the rvalue, not the option name 
:(
 2017-11-28 09:25:38 +01:00
Zbigniew Jędrzejewski-Szmek 458d8ae302 networkd: move rule loading to a separate function 
No functional change.
 2017-11-28 09:25:38 +01:00
Zbigniew Jędrzejewski-Szmek edb5318cbc
Merge pull request #7316 from poettering/fd-store-remove 
add new FDSTOREREMOVE=1 sd_notify() message
 2017-11-28 09:15:00 +01:00
Ari 05608fcd38 Added Logitech MX Master 2s (#7487) 2017-11-28 12:30:31 +10:00
Lennart Poettering 5bf5510b8f test-resolve: make sure we don't hang forever 
If test-resolve is running in some CI environment that doesn't have
reliably working DNS, it's a good idea not to hang forever, let's
time-out after 20s
 2017-11-27 17:08:34 +01:00